discourse/plugins/chat/spec/system/drawer_spec.rb
Joffrey JAFFEUX 90efdd7f9d
PERF: cook message in background (#24227)
This commit starts from a simple observation: cooking messages on the hot path can be slow. Especially with a lot of mentions.

To move cooking from the hot path, this commit has made the following changes:

- updating cooked, inserting mentions and notifying user of new mentions has been moved inside the `process_message` job. It happens right after the `Chat::MessageProcessor` run, which is where the cooking happens.
- the similar existing code in `rebake!` has also been moved to rely on the `process_message`job only
- refactored `create_mentions` and `update_mentions` into one single `upsert_mentions` which can be called invariably
- allows services to decide if their job is ran inline or later. It avoids to need to know you have to use `Jobs.run_immediately!` in this case, in tests it will be inline per default
- made various frontend changes to make the chat-channel component lifecycle clearer. we had to handle `did-update @channel` which was super awkward and creating bugs with listeners which the changes of the PR made clear in failing specs
- adds a new `-processed` (and `-not-processed`) class on the chat message, this is made to have a good lifecyle hook in system specs
2023-11-06 15:45:30 +01:00

155 lines
4.0 KiB
Ruby

# frozen_string_literal: true
RSpec.describe "Drawer", type: :system do
fab!(:current_user) { Fabricate(:admin) }
let(:chat_page) { PageObjects::Pages::Chat.new }
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
let(:drawer_page) { PageObjects::Pages::ChatDrawer.new }
before do
chat_system_bootstrap
sign_in(current_user)
end
context "when on channel" do
fab!(:channel) { Fabricate(:chat_channel) }
fab!(:membership) do
Fabricate(:user_chat_channel_membership, user: current_user, chat_channel: channel)
end
context "when clicking channel title" do
it "opens channel info page" do
visit("/")
chat_page.open_from_header
drawer_page.open_channel(channel)
page.find(".chat-channel-title").click
expect(page).to have_current_path("/chat/c/#{channel.slug}/#{channel.id}/info/settings")
end
end
end
context "when opening" do
it "uses stored size" do
visit("/") # we need to visit the page first to set the local storage
page.execute_script "window.localStorage.setItem('discourse_chat_drawer_size_width','500');"
page.execute_script "window.localStorage.setItem('discourse_chat_drawer_size_height','500');"
visit("/")
chat_page.open_from_header
expect(page.find(".chat-drawer").native.style("width")).to eq("500px")
expect(page.find(".chat-drawer").native.style("height")).to eq("500px")
end
it "has a default size" do
visit("/")
chat_page.open_from_header
expect(page.find(".chat-drawer").native.style("width")).to eq("400px")
expect(page.find(".chat-drawer").native.style("height")).to eq("530px")
end
end
context "when toggling open/close" do
it "toggles a css class on body" do
visit("/")
chat_page.open_from_header
expect(page.find("body.chat-drawer-active")).to be_visible
drawer_page.close
expect(page.find("body:not(.chat-drawer-active)")).to be_visible
end
end
context "when closing the drawer" do
fab!(:channel_1) { Fabricate(:chat_channel) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1) }
before { channel_1.add(current_user) }
it "resets the active message" do
visit("/")
chat_page.open_from_header
drawer_page.open_channel(channel_1)
channel_page.hover_message(message_1)
expect(page).to have_css(".chat-message-actions-container", visible: :all)
drawer_page.close
expect(page).to have_no_css(".chat-message-actions-container")
end
end
context "when clicking the drawer's header" do
it "collapses the drawer" do
visit("/")
chat_page.open_from_header
expect(page).to have_selector(".chat-drawer.is-expanded")
page.find(".chat-drawer-header").click
expect(page).to have_selector(".chat-drawer:not(.is-expanded)")
end
end
context "when going from drawer to full page" do
fab!(:channel_1) { Fabricate(:chat_channel) }
fab!(:channel_2) { Fabricate(:chat_channel) }
fab!(:user_1) { Fabricate(:user) }
before do
channel_1.add(current_user)
channel_2.add(current_user)
channel_1.add(user_1)
channel_2.add(user_1)
end
it "correctly resets subscriptions" do
visit("/")
chat_page.open_from_header
drawer_page.maximize
chat_page.minimize_full_page
drawer_page.maximize
Fabricate(
:chat_message,
chat_channel: channel_1,
user: user_1,
use_service: true,
message: "onlyonce",
)
expect(page).to have_content("onlyonce", count: 1)
chat_page.visit_channel(channel_2)
expect(page).to have_content("onlyonce", count: 0)
end
end
context "when subfolder install" do
fab!(:channel) { Fabricate(:chat_channel) }
before do
channel.add(current_user)
set_subfolder "/discuss"
end
it "works to go from full page to drawer" do
visit("/discuss/chat")
chat_page.minimize_full_page
expect(drawer_page).to have_open_channel(channel)
end
end
end