discourse/spec/components/promotion_spec.rb
Andy Waite 3e50313fdc Prepare for separation of RSpec helper files
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`

`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).

For more information:

https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files

In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.

This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.

At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00

184 lines
5.4 KiB
Ruby

require 'rails_helper'
require 'promotion'
describe Promotion do
describe "review" do
it "skips regular users" do
# Reviewing users at higher trust levels is expensive, so trigger those reviews in a background job.
regular = Fabricate.build(:user, trust_level: TrustLevel[2])
promotion = described_class.new(regular)
promotion.expects(:review_tl2).never
promotion.review
end
end
context "newuser" do
let(:user) { Fabricate(:user, trust_level: TrustLevel[0], created_at: 2.days.ago)}
let(:promotion) { Promotion.new(user) }
it "doesn't raise an error with a nil user" do
expect { Promotion.new(nil).review }.not_to raise_error
end
context 'that has done nothing' do
let!(:result) { promotion.review }
it "returns false" do
expect(result).to eq(false)
end
it "has not changed the user's trust level" do
expect(user.trust_level).to eq(TrustLevel[0])
end
end
context "that has done the requisite things" do
before do
stat = user.user_stat
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
@result = promotion.review
end
it "returns true" do
expect(@result).to eq(true)
end
it "has upgraded the user to basic" do
expect(user.trust_level).to eq(TrustLevel[1])
end
end
context "that has done the requisite things" do
it "does not promote the user" do
user.created_at = 1.minute.ago
stat = user.user_stat
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
@result = promotion.review
expect(@result).to eq(false)
expect(user.trust_level).to eq(TrustLevel[0])
end
end
end
context "basic" do
let(:user) { Fabricate(:user, trust_level: TrustLevel[1], created_at: 2.days.ago)}
let(:promotion) { Promotion.new(user) }
context 'that has done nothing' do
let!(:result) { promotion.review }
it "returns false" do
expect(result).to eq(false)
end
it "has not changed the user's trust level" do
expect(user.trust_level).to eq(TrustLevel[1])
end
end
context "that has done the requisite things" do
before do
stat = user.user_stat
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
stat.likes_received = SiteSetting.tl2_requires_likes_received
stat.likes_given = SiteSetting.tl2_requires_likes_given
stat.topic_reply_count = SiteSetting.tl2_requires_topic_reply_count
@result = promotion.review
end
it "returns true" do
expect(@result).to eq(true)
end
it "has upgraded the user to regular" do
expect(user.trust_level).to eq(TrustLevel[2])
end
end
context "when the account hasn't existed long enough" do
it "does not promote the user" do
user.created_at = 1.minute.ago
stat = user.user_stat
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
stat.likes_received = SiteSetting.tl2_requires_likes_received
stat.likes_given = SiteSetting.tl2_requires_likes_given
stat.topic_reply_count = SiteSetting.tl2_requires_topic_reply_count
result = promotion.review
expect(result).to eq(false)
expect(user.trust_level).to eq(TrustLevel[1])
end
end
end
context "regular" do
let(:user) { Fabricate(:user, trust_level: TrustLevel[2])}
let(:promotion) { Promotion.new(user) }
context "doesn't qualify for promotion" do
before do
TrustLevel3Requirements.any_instance.expects(:requirements_met?).at_least_once.returns(false)
end
it "review_tl2 returns false" do
expect {
expect(promotion.review_tl2).to eq(false)
}.to_not change { user.reload.trust_level }
end
it "doesn't promote" do
expect {
promotion.review_tl2
}.to_not change { user.reload.trust_level }
end
it "doesn't log a trust level change" do
expect {
promotion.review_tl2
}.to_not change { UserHistory.count }
end
end
context "qualifies for promotion" do
before do
TrustLevel3Requirements.any_instance.expects(:requirements_met?).at_least_once.returns(true)
end
it "review_tl2 returns true" do
expect(promotion.review_tl2).to eq(true)
end
it "promotes to tl3" do
expect(promotion.review_tl2).to eq(true)
expect(user.reload.trust_level).to eq(TrustLevel[3])
end
it "logs a trust level change" do
expect {
promotion.review_tl2
}.to change { UserHistory.where(action: UserHistory.actions[:auto_trust_level_change]).count }.by(1)
end
end
end
end