github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-22 18:15:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
discourse/spec/models
History
Martin Brennan bd25627198
FIX: IMAP post alerter race condition and code improvements (#11711) 
This PR fixes a race condition with the IMAP notification code. In the `Email::Receiver` we call the `NewPostManager` to create the post and enqueue jobs and sends alerts via `PostAlerter`. However, if the post alerter reaches the `notify_pm_users` and the `group_notifying_via_smtp` method _before_ the incoming email is updated with the post and topic, we unnecessarily send a notification to the person who just posted. The result of this is that the IMAP syncer re-imports the email sent to the user about their own post, which looks like this in the group inbox:

To fix this, we skip the jobs enqueued by `NewPostManager` and only enqueue them with `PostJobsEnqueuer` manually _after_ the incoming email record has been updated with the post and topic.

Other improvements:

* Moved code to calculate email addresses from `IncomingEmail` records into the topic, with a group passed in, for easier testing and debugging. It is not the responsibility of the post alerter to figure this stuff out.
* Add shortcut methods on `IncomingEmail` to split or provide an empty array for to and cc addresses to avoid repetition.
2021-01-15 10:54:46 +10:00
..
about_spec.rb
PERF: speed up about page render time and limit category mods (#8112)
2019-10-03 21:48:56 +03:00
admin_dashboard_problem_spec.rb
Remove very bad tests
2020-03-06 09:35:55 -05:00
api_key_spec.rb
REFACTOR: Introduce RouteMatcher class
2020-10-19 10:40:55 +01:00
application_request_spec.rb
DEV: Clean up some Redis leaks in test env.
2020-05-18 17:27:37 +08:00
badge_spec.rb
FIX: error customizing text for badges from plugins
2020-04-28 14:34:41 -04:00
badge_type_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
bookmark_spec.rb
FEATURE: Add weekly bookmark cleanup code (#10899)
2020-10-14 09:38:57 +10:00
category_featured_topic_spec.rb
FEATURE: remove support for 'suppress_from_latest' category setting. (#8308)
2019-11-18 12:28:35 +05:30
category_group_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
category_list_spec.rb
DEV: Refactor draft attributes for CategoryList and TopicList.
2020-07-24 10:11:30 +08:00
category_spec.rb
FIX: Make category slugs lowercase (#11277)
2021-01-12 17:28:33 +02:00
category_user_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
child_theme_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
color_scheme_color_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
color_scheme_spec.rb
FEATURE: WCAG compliant color schemes (#10882)
2020-10-15 14:05:48 -04:00
developer_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
digest_email_site_setting_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
directory_item_spec.rb
DEV: improve flaky spec
2019-10-04 11:11:03 +10:00
discourse_single_sign_on_spec.rb
FEATURE: support SSO website and location overrides
2020-04-28 16:06:35 +10:00
do_not_disturb_timing_spec.rb
FEATURE: Do not disturb (#11484)
2020-12-18 09:03:51 -06:00
draft_sequence_spec.rb
FIX: Always return 0 for non-human user current DraftSequence.
2020-05-15 10:40:36 +08:00
draft_spec.rb
FEATURE: composer option to reload page and force save draft (#10773)
2020-09-29 22:29:03 +05:30
email_change_request_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
email_log_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
email_token_spec.rb
FEATURE: multiple use invite links (#9813)
2020-06-09 20:49:32 +05:30
embeddable_host_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
emoji_spec.rb
FIX: allows replacement of digits and symbols emojis (#7978)
2019-08-07 11:38:58 +02:00
given_daily_like_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
global_setting_spec.rb
FIX: use Redis replica host and port (#11566)
2020-12-23 13:14:19 +11:00
group_history_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
group_spec.rb
DEV: Ensure DiscourseEvent handlers cleaned up during specs (#11205)
2020-11-11 19:46:13 +00:00
group_user_spec.rb
linting (#10644)
2020-09-10 11:34:48 +02:00
incoming_link_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
incoming_links_report_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
invite_redeemer_spec.rb
FIX: on invite redemption only update pending ReviewableUser record (#11394)
2020-12-02 18:38:26 +05:30
invite_spec.rb
FIX: Reset invite when resending it (#11013)
2020-10-26 12:26:43 +02:00
javascript_cache_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
locale_site_setting_spec.rb
DEV: clean up potential locale leak
2019-06-03 12:42:29 +10:00
mailing_list_mode_site_setting_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
notification_spec.rb
FEATURE: Send notification emails when users leave do not disturb mode (#11643)
2021-01-07 10:49:49 -06:00
optimized_image_spec.rb
DEV: Clean up S3 specs, stubs, and helpers
2020-09-28 12:02:25 +01:00
permalink_spec.rb
DEV: Deprecate Category#url_with_id in favor of Category#url (#9972)
2020-06-18 11:32:14 +03:00
plugin_store_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
post_action_spec.rb
DEV: Split toggle topic close job (#11679)
2021-01-13 08:49:29 +10:00
post_action_type_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
post_analyzer_spec.rb
FIX - limit number of embedded media items in a post (#10391)
2020-08-07 12:08:59 -04:00
post_detail_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
post_mover_spec.rb
FIX: correct link in the notification about moved post (#11399)
2020-12-04 08:43:42 +11:00
post_reply_key_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
post_reply_spec.rb
DEV: update dependencies and add notes about exceptions
2019-12-06 13:00:28 +11:00
post_spec.rb
FIX: Hiding a post should not trigger the duplicate check (#11680)
2021-01-11 14:56:08 -05:00
post_timing_spec.rb
PERF: Keep track of first unread PM and first unread group PM for user.
2020-09-09 14:05:41 +08:00
post_upload_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
published_page_spec.rb
FEATURE: Support for publishing topics as pages (#9364)
2020-04-08 12:52:36 -04:00
quoted_post_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
remote_theme_spec.rb
FIX: Gracefully handle force pushes for remote themes (#11325)
2020-11-23 15:29:22 +02:00
report_spec.rb
FIX: Only cache reports with exceptions for 1 minute (#11447)
2020-12-09 10:54:41 -06:00
reviewable_claimed_topic_spec.rb
FIX: Don't log a claimed topic database error during tests
2020-01-09 12:32:05 -05:00
reviewable_flagged_post_spec.rb
FEATURE: Unassign the review queue topic when a flag is handled
2020-03-24 14:57:44 -07:00
reviewable_history_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
reviewable_queued_post_spec.rb
FIX: Return 422 when creating topics with tags w/out permission (#10400)
2020-08-10 16:14:15 -06:00
reviewable_score_spec.rb
FIX: Bots accuracy should be zero (#8654)
2020-01-02 13:24:24 -03:00
reviewable_spec.rb
FEATURE: Reviewed by filter. (#11405)
2020-12-04 14:09:05 -03:00
reviewable_user_spec.rb
FEATURE: reason to reject user signup (#11700)
2021-01-15 09:43:26 +11:00
s3_region_site_setting_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
screened_email_spec.rb
FEATURE: when blocking emails prefer blocking canonical
2020-04-24 14:09:51 +10:00
screened_ip_address_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
screened_url_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
search_log_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
site_setting_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
site_spec.rb
UX: Improve color scheme choices in user prefs (#11656)
2021-01-07 11:15:38 -05:00
skipped_email_log_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
stylesheet_cache_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
tag_group_spec.rb
FIX: remove parent tag from tag group
2020-03-13 12:25:58 -04:00
tag_spec.rb
FIX: URL encode tag name (#11393)
2020-12-02 12:36:41 +05:30
tag_user_spec.rb
Tag groups can belong to groups (#10854)
2020-10-14 13:15:54 -04:00
theme_field_spec.rb
FIX: Rebake theme fields if upload changes (#11341)
2020-11-25 10:49:12 +11:00
theme_modifier_set_spec.rb
DEV: Allow plugins to add theme modifiers via db migrations (#9192)
2020-03-12 16:35:28 +00:00
theme_spec.rb
DEV: updates js transpiler to use babel 7 (#10627)
2020-09-15 09:26:33 +02:00
top_menu_item_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
top_topic_spec.rb
DEV: correct spec failures in PG 12
2019-11-26 16:39:14 +11:00
topic_allowed_user_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
topic_converter_spec.rb
FIX: Limit personal message participants when converting from topic (#9343)
2020-04-03 16:42:01 +01:00
topic_embed_spec.rb
DEV: More robust processing of URLs (#11361)
2020-12-03 17:16:01 -05:00
topic_featured_users_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
topic_group_spec.rb
FIX: Constraint error when inserting the same topic group twice
2019-12-12 13:10:46 -05:00
topic_invite_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
topic_link_click_spec.rb
DEV: Clean up S3 specs, stubs, and helpers
2020-09-28 12:02:25 +01:00
topic_link_spec.rb
PERF: avoid race conditions when creating topic links
2020-05-13 16:05:57 +10:00
topic_list_spec.rb
FIX: Build correct topic list filter (#11473)
2020-12-11 14:20:48 +02:00
topic_participants_summary_spec.rb
DEV: Better topic participants summary spec
2019-11-18 09:43:14 -05:00
topic_posters_summary_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
topic_spec.rb
FIX: IMAP post alerter race condition and code improvements (#11711)
2021-01-15 10:54:46 +10:00
topic_tag_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
topic_thumbnail_spec.rb
PERF: we don't need to use a huge image to test thumbnails (#11025)
2020-10-27 12:39:52 +11:00
topic_timer_spec.rb
DEV: Split toggle topic close job (#11679)
2021-01-13 08:49:29 +10:00
topic_tracking_state_spec.rb
FIX: correct tracking when mute all categories (#11441)
2020-12-10 16:49:05 +11:00
topic_user_spec.rb
DEV: Ensure DiscourseEvent handlers cleaned up during specs (#11205)
2020-11-11 19:46:13 +00:00
topic_view_item_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
translation_override_spec.rb
FIX: deprecate whitelist constants (#10716)
2020-09-28 13:52:05 +10:00
trust_level3_requirements_spec.rb
DEV: Update tl3 spec to remove hard-coded primary keys
2020-04-17 17:24:14 +01:00
unsubscribe_key_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
upload_spec.rb
DEV: Make site setting type uploaded_image_list use upload IDs (#10401)
2020-10-13 16:17:06 +03:00
user_action_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
user_api_key_spec.rb
REFACTOR: Introduce RouteMatcher class
2020-10-19 10:40:55 +01:00
user_archived_message_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_auth_token_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
user_avatar_spec.rb
FIX: reset gravatar cache by adding random param to URL (#9370)
2020-04-08 07:35:42 +10:00
user_badge_spec.rb
PERF: Cache ranks for featured badges, to simplify user serialization (#8698)
2020-01-14 14:26:49 +00:00
user_email_spec.rb
FIX: : trigger user_updated event only if email changed after user creation.
2020-07-16 18:21:30 +05:30
user_export_spec.rb
REVERT: DEV: should ignore missing post uploads when a user export destroyed
2019-07-25 19:41:25 +05:30
user_field_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_history_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
user_option_spec.rb
FEATURE: add new user option skip_new_user_tips. (#10437)
2020-08-14 19:10:56 +05:30
user_profile_spec.rb
FIX: Make sure rel attributes are correctly set. (#10645)
2020-09-10 12:59:51 -03:00
user_profile_view_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
user_search_spec.rb
SECURITY: Check permissions when autocompleting mentions
2019-10-28 11:01:47 +00:00
user_second_factor_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_spec.rb
FEATURE: Use the site's small logo as the system user's avatar. (#11661)
2021-01-08 10:40:00 -03:00
user_stat_spec.rb
PERF: Keep track of first unread PM and first unread group PM for user.
2020-09-09 14:05:41 +08:00
user_summary_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_visit_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
username_validator_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
watched_word_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
web_crawler_request_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
web_hook_event_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
web_hook_spec.rb
FEATURE: Webhooks and Event for user being granted a badge
2020-04-08 14:38:30 -07:00