mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 20:43:39 +08:00
8ebd5edd1e
This commit renames all secure_media related settings to secure_uploads_* along with the associated functionality. This is being done because "media" does not really cover it, we aren't just doing this for images and videos etc. but for all uploads in the site. Additionally, in future we want to secure more types of uploads, and enable a kind of "mixed mode" where some uploads are secure and some are not, so keeping media in the name is just confusing. This also keeps compatibility with the `secure-media-uploads` path, and changes new secure URLs to be `secure-uploads`. Deprecated settings: * secure_media -> secure_uploads * secure_media_allow_embed_images_in_emails -> secure_uploads_allow_embed_images_in_emails * secure_media_max_email_embed_image_size_kb -> secure_uploads_max_email_embed_image_size_kb
178 lines
5.0 KiB
Ruby
178 lines
5.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class UrlHelper
|
|
|
|
# At the moment this handles invalid URLs that browser address bar accepts
|
|
# where second # is not encoded
|
|
#
|
|
# Longer term we can add support of simpleidn and encode unicode domains
|
|
def self.relaxed_parse(url)
|
|
url, fragment = url.split("#", 2)
|
|
uri = URI.parse(url)
|
|
if uri
|
|
# Addressable::URI::CharacterClasses::UNRESERVED is used here because without it
|
|
# the # in the fragment is not encoded
|
|
fragment = Addressable::URI.encode_component(fragment, Addressable::URI::CharacterClasses::UNRESERVED) if fragment&.include?('#')
|
|
uri.fragment = fragment
|
|
uri
|
|
end
|
|
rescue URI::Error
|
|
end
|
|
|
|
def self.encode_and_parse(url)
|
|
URI.parse(Addressable::URI.encode(url))
|
|
end
|
|
|
|
def self.encode(url)
|
|
Addressable::URI.encode(url)
|
|
end
|
|
|
|
def self.unencode(url)
|
|
Addressable::URI.unencode(url)
|
|
end
|
|
|
|
def self.encode_component(url_component)
|
|
Addressable::URI.encode_component(url_component)
|
|
end
|
|
|
|
def self.is_local(url)
|
|
url.present? && (
|
|
Discourse.store.has_been_uploaded?(url) ||
|
|
!!(url =~ Regexp.new("^#{Discourse.base_path}/(assets|plugins|images)/")) ||
|
|
url.start_with?(Discourse.asset_host || Discourse.base_url_no_prefix)
|
|
)
|
|
end
|
|
|
|
def self.absolute(url, cdn = Discourse.asset_host)
|
|
cdn = "https:#{cdn}" if cdn && cdn =~ /^\/\//
|
|
url =~ /^\/[^\/]/ ? (cdn || Discourse.base_url_no_prefix) + url : url
|
|
end
|
|
|
|
def self.absolute_without_cdn(url)
|
|
self.absolute(url, nil)
|
|
end
|
|
|
|
def self.schemaless(url)
|
|
url.sub(/^http:/i, "")
|
|
end
|
|
|
|
def self.secure_proxy_without_cdn(url)
|
|
self.absolute(Upload.secure_uploads_url_from_upload_url(url), nil)
|
|
end
|
|
|
|
def self.escape_uri(uri)
|
|
Discourse.deprecate(
|
|
"UrlHelper.escape_uri is deprecated. For normalization of user input use `.normalized_encode`. For true encoding, use `.encode`",
|
|
output_in_test: true,
|
|
drop_from: '3.0'
|
|
)
|
|
normalized_encode(uri)
|
|
end
|
|
|
|
def self.normalized_encode(uri)
|
|
validated = nil
|
|
url = uri.to_s
|
|
|
|
# Ideally we will jump straight to `Addressable::URI.normalized_encode`. However,
|
|
# that implementation has some edge-case issues like https://github.com/sporkmonger/addressable/issues/472.
|
|
# To temporaily work around those issues for the majority of cases, we try parsing with `::URI`.
|
|
# If that fails (e.g. due to non-ascii characters) then we will fall back to addressable.
|
|
# Hopefully we can simplify this back to `Addressable::URI.normalized_encode` in the future.
|
|
|
|
# edge case where we expect mailto:test%40test.com to normalize to mailto:test@test.com
|
|
if url.match(/\Amailto:/)
|
|
return normalize_with_addressable(url)
|
|
end
|
|
|
|
# If it doesn't pass the regexp, it's definitely not gonna parse with URI.parse. Skip
|
|
# to addressable
|
|
if !url.match?(/\A#{URI::regexp}\z/)
|
|
return normalize_with_addressable(url)
|
|
end
|
|
|
|
begin
|
|
normalize_with_ruby_uri(url)
|
|
rescue URI::Error
|
|
normalize_with_addressable(url)
|
|
end
|
|
end
|
|
|
|
def self.rails_route_from_url(url)
|
|
path = URI.parse(encode(url)).path
|
|
Rails.application.routes.recognize_path(path)
|
|
rescue Addressable::URI::InvalidURIError, URI::InvalidComponentError
|
|
nil
|
|
end
|
|
|
|
def self.cook_url(url, secure: false, local: nil)
|
|
is_secure = SiteSetting.secure_uploads && secure
|
|
local = is_local(url) if local.nil?
|
|
return url if !local
|
|
|
|
url = is_secure ? secure_proxy_without_cdn(url) : absolute_without_cdn(url)
|
|
|
|
# we always want secure uploads to come from
|
|
# Discourse.base_url_no_prefix/secure-uploads
|
|
# to avoid asset_host mixups
|
|
return schemaless(url) if is_secure
|
|
|
|
# PERF: avoid parsing url except for extreme conditions
|
|
# this is a hot path used on home page
|
|
filename = url
|
|
if url.include?("?")
|
|
uri = URI.parse(url)
|
|
filename = File.basename(uri.path)
|
|
end
|
|
|
|
# this technically requires a filename, but will work with a URL as long as it end with the
|
|
# extension and has no query params
|
|
is_attachment = !FileHelper.is_supported_media?(filename)
|
|
|
|
no_cdn = SiteSetting.login_required || SiteSetting.prevent_anons_from_downloading_files
|
|
unless is_attachment && no_cdn
|
|
url = Discourse.store.cdn_url(url)
|
|
url = local_cdn_url(url) if Discourse.store.external?
|
|
end
|
|
|
|
schemaless(url)
|
|
rescue URI::Error
|
|
url
|
|
end
|
|
|
|
def self.local_cdn_url(url)
|
|
return url if Discourse.asset_host.blank?
|
|
if url.start_with?("/#{Discourse.store.upload_path}/")
|
|
"#{Discourse.asset_host}#{url}"
|
|
else
|
|
url.sub(Discourse.base_url_no_prefix, Discourse.asset_host)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def self.normalize_with_addressable(url)
|
|
u = Addressable::URI.normalized_encode(url, Addressable::URI)
|
|
|
|
if u.host && !u.host.ascii_only?
|
|
u.host = ::Addressable::IDNA.to_ascii(u.host)
|
|
end
|
|
|
|
u.to_s
|
|
end
|
|
|
|
def self.normalize_with_ruby_uri(url)
|
|
u = URI.parse(url)
|
|
|
|
if u.scheme && u.scheme != u.scheme.downcase
|
|
u.scheme = u.scheme.downcase
|
|
end
|
|
|
|
if u.host && u.host != u.host.downcase
|
|
u.host = u.host.downcase
|
|
end
|
|
|
|
u.to_s
|
|
end
|
|
|
|
end
|