mirror of
https://github.com/discourse/discourse.git
synced 2024-12-23 21:33:49 +08:00
4e5de17e7c
Followup0568d36133
Followup97cf069a06
Due to the S3 dualstack endpoint change, sites with S3 backups configured but _not_ S3 uploads were erroring, with admins unable to access the backups page. This commit fixes the error by not enabling S3 dualstack endpoints if S3 uploads have not been enabled, backups don't need to use them. c.f. https://meta.discourse.org/t/unable-to-backup-or-navigate-to-backups/335899
239 lines
7.1 KiB
Ruby
239 lines
7.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe SiteSetting do
|
|
describe "topic_title_length" do
|
|
it "returns a range of min/max topic title length" do
|
|
expect(SiteSetting.topic_title_length).to eq(
|
|
(
|
|
SiteSetting.defaults[:min_topic_title_length]..SiteSetting.defaults[
|
|
:max_topic_title_length
|
|
]
|
|
),
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "post_length" do
|
|
it "returns a range of min/max post length" do
|
|
expect(SiteSetting.post_length).to eq(
|
|
SiteSetting.defaults[:min_post_length]..SiteSetting.defaults[:max_post_length],
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "first_post_length" do
|
|
it "returns a range of min/max first post length" do
|
|
expect(SiteSetting.first_post_length).to eq(
|
|
SiteSetting.defaults[:min_first_post_length]..SiteSetting.defaults[:max_post_length],
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "private_message_title_length" do
|
|
it "returns a range of min/max pm topic title length" do
|
|
expect(SiteSetting.private_message_title_length).to eq(
|
|
SiteSetting.defaults[:min_personal_message_title_length]..SiteSetting.defaults[
|
|
:max_topic_title_length
|
|
],
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "in test we do some judo to ensure SiteSetting is always reset between tests" do
|
|
it "is always the correct default" do
|
|
expect(SiteSetting.contact_email).to eq("")
|
|
end
|
|
|
|
it "sets a setting" do
|
|
SiteSetting.contact_email = "sam@sam.com"
|
|
end
|
|
end
|
|
|
|
describe "anonymous_homepage" do
|
|
it "returns latest" do
|
|
expect(SiteSetting.anonymous_homepage).to eq("latest")
|
|
end
|
|
end
|
|
|
|
describe "top_menu" do
|
|
describe "validations" do
|
|
it "always demands latest" do
|
|
expect do SiteSetting.top_menu = "categories" end.to raise_error(
|
|
Discourse::InvalidParameters,
|
|
)
|
|
end
|
|
|
|
it "does not allow random text" do
|
|
expect do SiteSetting.top_menu = "latest|random" end.to raise_error(
|
|
Discourse::InvalidParameters,
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "items" do
|
|
let(:items) { SiteSetting.top_menu_items }
|
|
|
|
it "returns TopMenuItem objects" do
|
|
expect(items[0]).to be_kind_of(TopMenuItem)
|
|
end
|
|
end
|
|
|
|
describe "homepage" do
|
|
it "has homepage" do
|
|
SiteSetting.top_menu = "bookmarks|latest"
|
|
expect(SiteSetting.homepage).to eq("bookmarks")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "min_redirected_to_top_period" do
|
|
context "when has_enough_top_topics" do
|
|
before do
|
|
SiteSetting.topics_per_period_in_top_page = 2
|
|
SiteSetting.top_page_default_timeframe = "daily"
|
|
|
|
2.times { TopTopic.create!(daily_score: 2.5) }
|
|
|
|
TopTopic.refresh!
|
|
end
|
|
|
|
it "should_return_a_time_period" do
|
|
expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).to eq(:daily)
|
|
end
|
|
end
|
|
|
|
context "when does_not_have_enough_top_topics" do
|
|
before do
|
|
SiteSetting.topics_per_period_in_top_page = 20
|
|
SiteSetting.top_page_default_timeframe = "daily"
|
|
TopTopic.refresh!
|
|
end
|
|
|
|
it "should_return_a_time_period" do
|
|
expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).to eq(nil)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "scheme" do
|
|
before { SiteSetting.force_https = true }
|
|
|
|
it "returns http when ssl is disabled" do
|
|
SiteSetting.force_https = false
|
|
expect(SiteSetting.scheme).to eq("http")
|
|
end
|
|
|
|
it "returns https when using ssl" do
|
|
expect(SiteSetting.scheme).to eq("https")
|
|
end
|
|
end
|
|
|
|
describe ".shared_drafts_enabled?" do
|
|
it "returns false by default" do
|
|
expect(SiteSetting.shared_drafts_enabled?).to eq(false)
|
|
end
|
|
|
|
it "returns false when the category is uncategorized" do
|
|
SiteSetting.shared_drafts_category = SiteSetting.uncategorized_category_id
|
|
expect(SiteSetting.shared_drafts_enabled?).to eq(false)
|
|
end
|
|
|
|
it "returns true when the category is valid" do
|
|
SiteSetting.shared_drafts_category = Fabricate(:category).id
|
|
expect(SiteSetting.shared_drafts_enabled?).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe "cached settings" do
|
|
it "should recalculate cached setting when dependent settings are changed" do
|
|
SiteSetting.blocked_attachment_filenames = "foo"
|
|
expect(SiteSetting.blocked_attachment_filenames_regex).to eq(/foo/)
|
|
|
|
SiteSetting.blocked_attachment_filenames = "foo|bar"
|
|
expect(SiteSetting.blocked_attachment_filenames_regex).to eq(/foo|bar/)
|
|
end
|
|
end
|
|
|
|
it "sanitizes the client settings when they are overridden" do
|
|
xss = "<b onmouseover=alert('Wufff!')>click me!</b><script>alert('TEST');</script>"
|
|
|
|
SiteSetting.global_notice = xss
|
|
|
|
expect(SiteSetting.global_notice).to eq("<b>click me!</b>alert('TEST');")
|
|
end
|
|
|
|
it "doesn't corrupt site settings with special characters" do
|
|
value = 'OX5y3Oljb+Qt9Bu809vsBQ==<>!%{}*&!@#$%..._-A'
|
|
settings = new_settings(SiteSettings::LocalProcessProvider.new)
|
|
settings.setting(:test_setting, "", client: true)
|
|
|
|
settings.test_setting = value
|
|
|
|
expect(settings.test_setting).to eq(value)
|
|
end
|
|
|
|
describe "#all_settings" do
|
|
it "does not include the `default_locale` setting if include_locale_setting is false" do
|
|
expect(SiteSetting.all_settings.map { |s| s[:setting] }).to include("default_locale")
|
|
expect(
|
|
SiteSetting.all_settings(include_locale_setting: false).map { |s| s[:setting] },
|
|
).not_to include("default_locale")
|
|
end
|
|
|
|
it "does not include the `default_locale` setting if filter_categories are specified" do
|
|
expect(
|
|
SiteSetting.all_settings(filter_categories: ["branding"]).map { |s| s[:setting] },
|
|
).not_to include("default_locale")
|
|
end
|
|
|
|
it "does not include the `default_locale` setting if filter_plugin is specified" do
|
|
expect(
|
|
SiteSetting.all_settings(filter_plugin: "chat").map { |s| s[:setting] },
|
|
).not_to include("default_locale")
|
|
end
|
|
|
|
it "includes only settings for the specified category" do
|
|
expect(SiteSetting.all_settings(filter_categories: ["required"]).count).to eq(12)
|
|
end
|
|
end
|
|
|
|
describe "Upload" do
|
|
before { setup_s3 }
|
|
|
|
describe "#use_dualstack_endpoint" do
|
|
context "when the s3 endpoint has been set" do
|
|
before { SiteSetting.s3_endpoint = "https://s3clone.test.com" }
|
|
|
|
it "returns false " do
|
|
expect(SiteSetting.Upload.use_dualstack_endpoint).to eq(false)
|
|
end
|
|
end
|
|
|
|
context "when enable_s3_uploads is false" do
|
|
before { SiteSetting.enable_s3_uploads = false }
|
|
|
|
it "returns false" do
|
|
expect(SiteSetting.Upload.use_dualstack_endpoint).to eq(false)
|
|
end
|
|
end
|
|
|
|
context "when enable_s3_uploads is true" do
|
|
before do
|
|
SiteSetting.enable_s3_uploads = true
|
|
SiteSetting.s3_endpoint = ""
|
|
end
|
|
|
|
it "returns false if the s3_region is in China" do
|
|
SiteSetting.s3_region = "cn-north-1"
|
|
expect(SiteSetting.Upload.use_dualstack_endpoint).to eq(false)
|
|
end
|
|
|
|
it "returns true if the s3_region is not in China" do
|
|
SiteSetting.s3_region = "us-west-1"
|
|
expect(SiteSetting.Upload.use_dualstack_endpoint).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|