mirror of
https://github.com/discourse/discourse.git
synced 2024-12-02 17:53:43 +08:00
a17d54d0bf
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks. Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps. It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli. (I might later add a custom rule to eslint-discourse-ember to enforce this) |
||
|---|---|---|
| .. | ||
| poll-breakdown-test.js.es6 | ||
| poll-builder-disabled-test.js.es6 | ||
| poll-builder-enabled-test.js.es6 | ||
| poll-pie-chart-test.js.es6 | ||
| poll-quote-test.js.es6 | ||
| polls-bar-chart-test-desktop.js.es6 | ||
| polls-bar-chart-test-mobile.js.es6 | ||