mirror of
https://github.com/discourse/discourse.git
synced 2025-02-24 05:31:27 +08:00
d8102cb532
We have many problem check trackers, and some of them like `OutOfDateThemes` can have a message which has variable data in it shown to admins. In this case, a list of themes that need updating. Currently if you resolve one of these out of date themes and refresh the list of problems, you do not see any change. This is happening because we are only updating the `details` of the `ProblemCheckTracker` record, not the corresponding `AdminNotice` record which is what is displayed to the admins on their dashboard. This commit fixes the issue by updating the details of the notice at the same time as the problem check tracker details.
110 lines
2.4 KiB
Ruby
110 lines
2.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class ProblemCheckTracker < ActiveRecord::Base
|
|
validates :identifier, presence: true, uniqueness: { scope: :target }
|
|
validates :blips, presence: true, numericality: { greater_than_or_equal_to: 0 }
|
|
|
|
scope :failing, -> { where("last_problem_at = last_run_at") }
|
|
scope :passing, -> { where("last_success_at = last_run_at") }
|
|
|
|
def self.[](identifier, target = ProblemCheck::NO_TARGET)
|
|
find_or_create_by(identifier:, target:)
|
|
end
|
|
|
|
def ready_to_run?
|
|
next_run_at.blank? || next_run_at.past?
|
|
end
|
|
|
|
def failing?
|
|
last_problem_at == last_run_at
|
|
end
|
|
|
|
def passing?
|
|
last_success_at == last_run_at
|
|
end
|
|
|
|
def problem!(next_run_at: nil, details: {})
|
|
now = Time.current
|
|
|
|
update!(blips: blips + 1, details:, last_run_at: now, last_problem_at: now, next_run_at:)
|
|
|
|
update_notice_details(details)
|
|
|
|
sound_the_alarm if sound_the_alarm?
|
|
end
|
|
|
|
def no_problem!(next_run_at: nil)
|
|
reset
|
|
silence_the_alarm
|
|
end
|
|
|
|
def reset(next_run_at: nil)
|
|
now = Time.current
|
|
|
|
update!(blips: 0, last_run_at: now, last_success_at: now, next_run_at:)
|
|
end
|
|
|
|
def check
|
|
check = ProblemCheck[identifier]
|
|
|
|
return check if check.present?
|
|
|
|
silence_the_alarm
|
|
destroy
|
|
|
|
nil
|
|
end
|
|
|
|
private
|
|
|
|
def resolved_target
|
|
self.target || ProblemCheck::NO_TARGET
|
|
end
|
|
|
|
def details_with_target(details)
|
|
details.merge(target: resolved_target)
|
|
end
|
|
|
|
def update_notice_details(details)
|
|
admin_notice.where(identifier:).update_all(details: details_with_target(details))
|
|
end
|
|
|
|
def sound_the_alarm?
|
|
failing? && blips > check.max_blips
|
|
end
|
|
|
|
def sound_the_alarm
|
|
admin_notice.create_with(
|
|
priority: check.priority,
|
|
details: details_with_target(self.details),
|
|
).find_or_create_by(identifier:)
|
|
end
|
|
|
|
def silence_the_alarm
|
|
admin_notice.where(identifier:).delete_all
|
|
end
|
|
|
|
def admin_notice
|
|
AdminNotice.problem.where("details->>'target' = ?", resolved_target)
|
|
end
|
|
end
|
|
|
|
# == Schema Information
|
|
#
|
|
# Table name: problem_check_trackers
|
|
#
|
|
# id :bigint not null, primary key
|
|
# identifier :string not null
|
|
# blips :integer default(0), not null
|
|
# last_run_at :datetime
|
|
# next_run_at :datetime
|
|
# last_success_at :datetime
|
|
# last_problem_at :datetime
|
|
# details :json
|
|
# target :string default("__NULL__")
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_problem_check_trackers_on_identifier_and_target (identifier,target) UNIQUE
|
|
#
|