mirror of
https://github.com/discourse/discourse.git
synced 2024-12-30 08:33:45 +08:00
9c85ea5945
Introduced back in 2022 in
e3d495850d
,
our new more specific message-id format for inbound and
outbound emails has now been in use for a very long time,
we can remove the support for the old formats:
`topic/:topic_id/:post_id.:random@:host`
`topic/:topic_id@:host`
`topic/:topic_id.:random@:host`
141 lines
5.0 KiB
Ruby
141 lines
5.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Email::MessageIdService do
|
|
fab!(:topic)
|
|
fab!(:post) { Fabricate(:post, topic: topic) }
|
|
fab!(:second_post) { Fabricate(:post, topic: topic) }
|
|
|
|
describe "#generate_or_use_existing" do
|
|
it "does not override a post's existing outbound_message_id" do
|
|
post.update!(outbound_message_id: "blah@host.test")
|
|
result = described_class.generate_or_use_existing(post.id)
|
|
expect(result).to eq(["<blah@host.test>"])
|
|
end
|
|
|
|
it "generates an outbound_message_id in the correct format if it's blank for the post" do
|
|
post.update!(outbound_message_id: nil)
|
|
result = described_class.generate_or_use_existing(post.id)
|
|
expect(result).to eq(["<discourse/post/#{post.id}@#{Email::MessageIdService.host}>"])
|
|
end
|
|
|
|
it "handles bulk posts with a mixture of existing and new outbound_message_ids, returning in created_at order" do
|
|
topic = Fabricate(:topic)
|
|
post_bulk1 =
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
created_at: 10.days.ago,
|
|
outbound_message_id: "blah@test.host",
|
|
)
|
|
post_bulk2 = Fabricate(:post, topic: topic, created_at: 12.days.ago, outbound_message_id: nil)
|
|
post_bulk3 =
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
created_at: 11.days.ago,
|
|
outbound_message_id: "sf92c349438509=3453@test.host",
|
|
)
|
|
post_bulk4 = Fabricate(:post, topic: topic, created_at: 3.days.ago, outbound_message_id: nil)
|
|
result =
|
|
described_class.generate_or_use_existing(
|
|
[post_bulk1.id, post_bulk2.id, post_bulk3.id, post_bulk4.id],
|
|
)
|
|
expect(result).to eq(
|
|
[
|
|
"<discourse/post/#{post_bulk2.id}@#{Email::MessageIdService.host}>",
|
|
"<sf92c349438509=3453@test.host>",
|
|
"<blah@test.host>",
|
|
"<discourse/post/#{post_bulk4.id}@#{Email::MessageIdService.host}>",
|
|
],
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "find_post_from_message_ids" do
|
|
let(:discourse_format_message_id) { "<discourse/post/#{post.id}@test.localhost>" }
|
|
let(:default_format_message_id) { "<36ac1ddd-5083-461d-b72c-6372fb0e7f33@test.localhost>" }
|
|
let(:gmail_format_message_id) do
|
|
"<CAPGrNgZ7QEFuPcsxJBRZLhBhAYPO_ruYpCANSdqiQEbc9Otpiw@mail.gmail.com>"
|
|
end
|
|
it "finds a post based only on a discourse-format message id" do
|
|
expect(described_class.find_post_from_message_ids([discourse_format_message_id])).to eq(post)
|
|
end
|
|
|
|
it "finds a post from the post's outbound_message_id" do
|
|
post.update!(
|
|
outbound_message_id: described_class.message_id_clean(discourse_format_message_id),
|
|
)
|
|
expect(described_class.find_post_from_message_ids([discourse_format_message_id])).to eq(post)
|
|
end
|
|
|
|
it "finds a post from the email log" do
|
|
email_log =
|
|
Fabricate(
|
|
:email_log,
|
|
message_id: described_class.message_id_clean(default_format_message_id),
|
|
)
|
|
expect(described_class.find_post_from_message_ids([default_format_message_id])).to eq(
|
|
email_log.post,
|
|
)
|
|
end
|
|
|
|
it "finds a post from the incoming email log" do
|
|
incoming_email =
|
|
Fabricate(
|
|
:incoming_email,
|
|
message_id: described_class.message_id_clean(gmail_format_message_id),
|
|
post: Fabricate(:post),
|
|
)
|
|
expect(described_class.find_post_from_message_ids([gmail_format_message_id])).to eq(
|
|
incoming_email.post,
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "#discourse_generated_message_id?" do
|
|
def check_format(message_id)
|
|
described_class.discourse_generated_message_id?(message_id)
|
|
end
|
|
|
|
it "works correctly for the different possible formats" do
|
|
expect(check_format("discourse/post/1223@test.localhost")).to eq(true)
|
|
expect(check_format("<discourse/post/1223@test.localhost>")).to eq(true)
|
|
|
|
expect(check_format("topic/1223@blah")).to eq(false)
|
|
expect(
|
|
check_format("<CAPGrNgZ7QEFuPcsxJBRZLhBhAYPO_ruYpCANSdqiQEbc9Otpiw@mail.gmail.com>"),
|
|
).to eq(false)
|
|
expect(check_format("t/1223@test.localhost")).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "#message_id_rfc_format" do
|
|
it "returns message ID in RFC format" do
|
|
expect(Email::MessageIdService.message_id_rfc_format("test@test")).to eq("<test@test>")
|
|
end
|
|
|
|
it "returns input if already in RFC format" do
|
|
expect(Email::MessageIdService.message_id_rfc_format("<test@test>")).to eq("<test@test>")
|
|
end
|
|
end
|
|
|
|
describe "#message_id_clean" do
|
|
it "returns message ID if in RFC format" do
|
|
expect(Email::MessageIdService.message_id_clean("<test@test>")).to eq("test@test")
|
|
end
|
|
|
|
it "returns input if a clean message ID is not in RFC format" do
|
|
message_id = "<" + "@" * 50
|
|
expect(Email::MessageIdService.message_id_clean(message_id)).to eq(message_id)
|
|
end
|
|
end
|
|
|
|
describe "#host" do
|
|
it "handles hostname changes at runtime" do
|
|
expect(Email::MessageIdService.host).to eq("test.localhost")
|
|
SiteSetting.force_hostname = "other.domain.example.com"
|
|
expect(Email::MessageIdService.host).to eq("other.domain.example.com")
|
|
end
|
|
end
|
|
end
|