discourse/app
David Taylor 33d5845991
FIX: Avoid scroll jumping for topics on slow connections (#23290)
When the 'loading slider' navigation indicator is enabled, and a connection is very slow, we `display: none` most of the page and display a spinner. The `still-loading` body class for this was being added in the `afterRender` step in the Ember runloop. This meant that, depending on the order they were scheduled, other `afterRender` jobs may run before it. This caused an issue with topic scroll locations because we would attempt to scroll to an element which was `display: none` at the point its position was calculated.

This commit moves the `still-loading` class manipulations to the `render` step of the runloop, which is technically more correct, and means that anything scheduled in the `afterRender` step is guaranteed to run without the `display: none` CSS.

https://meta.discourse.org/t/276305/29
2023-08-28 12:23:02 +01:00
..
assets FIX: Avoid scroll jumping for topics on slow connections (#23290) 2023-08-28 12:23:02 +01:00
controllers FIX: Infinite loading broken on group members list (#23214) 2023-08-24 08:50:20 +08:00
helpers FIX: Add site name to sitelinks structured data (#23151) 2023-08-24 10:07:45 -04:00
jobs DEV: there is no need anymore to wrap export methods into enumerators (#22567) 2023-08-17 22:09:58 +04:00
mailers FIX: Order tags shown in email subject by topics count and name (#22586) 2023-07-13 15:39:58 +08:00
models DEV: Move option to delete user under reviewable reject menu (#23257) 2023-08-27 10:05:05 +08:00
serializers DEV: Remove need for reloading cached summary thanks to Range#max (#23106) 2023-08-15 15:03:42 -03:00
services DEV: Add S3 upload system specs using minio (#22975) 2023-08-23 11:18:33 +10:00
views PERF: Avoid calling the same translation twice when rendering lists view (#22976) 2023-08-04 13:38:41 +08:00