mirror of
https://github.com/discourse/discourse.git
synced 2024-12-23 22:34:01 +08:00
aaec80413d
When a post containing an apostrophe (') is being cooked, the apostrophe is being converted to the "typographic" version (’) (because we enable markdown-it's **typographer** mode by default in Discourse)
When you select text that contains such apostrophe and then try to save your fast edit, it fails miserably without any error.
That's because when you select text from the DOM, it uses the cooked version which has the typographic apostrophe.
When you save your fast edit, we fetch the raw version of the post, which has the "regular" apostrophe. Thus doing `raw.replace(selectedText, editedText)` doesn't work because `raw` has the regular apostrophe but `selectedText` has the typographic apostrophe.
Since it's somewhat complicated to handle all typographic characters, we would basically have to reverse the process done in `custom-typographer-replacements.js`, we instead bail out and show the composer when we detect such character in the selection.
Internal ref - t/143836
|
||
|---|---|---|
| .. | ||
| admin | ||
| custom-proxy | ||
| deprecation-silencer | ||
| dialog-holder | ||
| discourse | ||
| discourse-common | ||
| discourse-hbr | ||
| discourse-i18n | ||
| discourse-markdown-it | ||
| discourse-plugins | ||
| discourse-widget-hbs | ||
| docs | ||
| ember-addons | ||
| ember-cli-progress-ci | ||
| ember-production-deprecations | ||
| float-kit | ||
| locales | ||
| pretty-text | ||
| select-kit | ||
| theme-transpiler | ||
| truth-helpers | ||
| .npmrc | ||
| handlebars-shim.js | ||
| polyfills.js | ||
| service-worker.js.erb | ||