mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 14:13:48 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
48 lines
917 B
Ruby
48 lines
917 B
Ruby
require 'rails_helper'
|
|
|
|
describe 'pool drainer' do
|
|
let(:pool) do
|
|
ActiveRecord::Base.connection_pool
|
|
end
|
|
|
|
it 'can correctly drain the connection pool' do
|
|
pool.drain
|
|
old = pool.connections.length
|
|
expect(old).to eq(1)
|
|
|
|
Thread.new do
|
|
conn = pool.checkout
|
|
pool.checkin conn
|
|
end.join
|
|
|
|
expect(pool.connections.length).to eq(old+1)
|
|
pool.drain
|
|
expect(pool.connections.length).to eq(old)
|
|
end
|
|
|
|
it 'can drain with idle time setting' do
|
|
pool.drain
|
|
old = pool.connections.length
|
|
expect(old).to eq(1)
|
|
|
|
|
|
Thread.new do
|
|
conn = pool.checkout
|
|
pool.checkin conn
|
|
end.join
|
|
|
|
expect(pool.connections.length).to eq(old+1)
|
|
pool.drain(1.minute)
|
|
expect(pool.connections.length).to eq(old+1)
|
|
|
|
# make sure we don't corrupt internal state
|
|
20.times do
|
|
conn = pool.checkout
|
|
pool.checkin conn
|
|
pool.drain
|
|
end
|
|
|
|
end
|
|
|
|
end
|