github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 11:13:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
35bc27a36d
discourse/lib/tasks
History
Alan Guo Xiang Tan 35bc27a36d
FIX: themes:update rake task not rolling back transaction on error (#26750) 
This commit fixes a bug in the `themes:update` rake task which resulted
in the ActiveRecord transaction not being rolled back when an error was
encountered. The transaction was first introduced in
7f0682f4f2 which changed a `begin..rescue`
block to `transaction do..rescue`. The problem with that change
prevented the transaction from ever rolling back as the code block
looks something like this:

```
transaction do
  begin
    update_theme
  rescue => e
    # surpress error
  end
end
```

From the transaction's point of view now, it will never rollback even if
an error was encountered when updating the remote theme because it will
never see the error.

Instead we should have done something like this if we wanted to surpress
the errors encountered while still ensuring that the transaction is
rolled back.

```
begin
  transaction do
    update_theme
  end
rescue => e
  # surpress error
end
```
2024-04-25 15:19:23 +08:00
..
add_topic_to_quotes.rake
admin.rake
annotate.rake DEV: Extensively use exception: true in system() (#25911) 2024-02-27 11:33:28 +01:00
api.rake
assets.rake DEV: Drop workbox dependency (#26735) 2024-04-24 10:19:12 +01:00
auto_annotate_models.rake
autospec.rake
avatars.rake
backfill.thor DEV: Format .thor files (#23059) 2023-08-10 13:59:13 +02:00
categories.rake FIX: Update category tag stats with new or deleted (#21531) 2023-05-18 12:46:44 +03:00
cdn.rake
compatibility.rake DEV: Introduce rake task to validate discourse-compatibility file (#26158) 2024-03-13 13:57:41 +00:00
db.rake DEV: Extensively use exception: true in system() (#25911) 2024-02-27 11:33:28 +01:00
destroy.rake
dev.rake
docker.rake DEV: Support customizing docker:test:setup with envs (#24508) 2023-11-22 15:12:02 +08:00
documentation.rake DEV: Remove unmaintained tidy-jsdoc dependency (#25110) 2024-01-03 10:30:54 +00:00
emails.rake FIX: in EmailSettingsValidator, unset smtp authentication when there's no user and password 2024-04-19 14:02:22 -04:00
emoji.rake DEV: Remove direct minitest dependency to appease ruby-lsp (#26056) 2024-03-06 15:41:14 +00:00
export.rake
groups.rake
hashtags.rake
i18n.rake
images.rake
import.rake DEV: Import script should insert more data into user_stats table (#26551) 2024-04-11 14:05:21 +02:00
incoming_emails.rake
integration.rake
javascript.rake UX: Show loading spinner while loading dependencies for ace-editor (#26099) 2024-03-11 06:56:17 +08:00
log.rake
maxminddb.rake FIX: maxmind:refresh does not respect refresh_maxmind_db_during_precompile_days (#26457) 2024-04-02 14:25:05 +08:00
plugin.rake DEV: Suppress verbose command failure output in plugin:turbo_spec (#25952) 2024-02-29 14:35:31 +10:00
populate.rake DEV: Convert admin-incoming-email modal to component-based API (#22701) 2023-07-20 16:31:20 -05:00
populate.thor DEV: Format .thor files (#23059) 2023-08-10 13:59:13 +02:00
posts.rake DEV: Allow rebakes to generate optimized images at the same time 2024-01-16 14:33:16 +01:00
profile.rake
qunit.rake DEV: Restore qunit 'tap' reporter, but collapse verbose output in CI (#26484) 2024-04-03 10:22:20 +01:00
redis.rake
release_note.rake DEV: Add link to PR when generating release notes 2023-09-12 09:26:46 +02:00
revisions.rake
rspec.rake
s3.rake FEATURE: allow S3 ACLs to be disabled (#21769) 2023-06-06 15:47:40 +10:00
scheduler.rake FEATURE: call hub API to update Discourse discover enrollment. (#25634) 2024-02-23 11:42:28 +05:30
search.rake
site_settings.rake DEV: Add rake command to help detect dead settings (#23300) 2023-08-29 09:42:52 -06:00
site.rake FEATURE: Add dark mode option for category backgrounds (#24003) 2023-10-20 12:48:06 +00:00
smoke_test.rake DEV: Extensively use exception: true in system() (#25911) 2024-02-27 11:33:28 +01:00
svg_icons.rake DEV: Extensively use exception: true in system() (#25911) 2024-02-27 11:33:28 +01:00
svg_sprites.rake
tags.rake
themes.rake FIX: themes:update rake task not rolling back transaction on error (#26750) 2024-04-25 15:19:23 +08:00
topics.rake FEATURE: do not bump topics when retroactively closing (#23115) 2023-08-16 11:20:47 +10:00
turbo.rake
typepad.thor DEV: Format .thor files (#23059) 2023-08-10 13:59:13 +02:00
uploads.rake DEV: Rename with_secure_uploads? to should_secure_uploads? on Post (#26549) 2024-04-09 13:23:11 +10:00
users.rake DEV: Add task to anonymize user data (#20522) 2023-10-03 16:59:43 +08:00
version_bump.rake DEV: Don't create backups during version bumps (#25484) 2024-01-30 11:41:15 -07:00