mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 03:34:17 +08:00
6b0aeced7e
This PR is introducing glimmer usage in the chat-live-pane, for components but also for models. RestModel usage has been dropped in favor of native classes. Other changes/additions in this PR: sticky dates, scrolling will now keep the date separator of the current section at the top of the screen better unread management, marking a channel as unread will correctly mark the correct message and not mark the whole channel as read. Tracking state will also now correctly return unread count and unread mentions. adds an animation on bottom arrow better scrolling behavior, we should now always correctly keep the scroll position while loading more reactions are now more reactive, and will update their tooltip without needed to close/reopen it skeleton has been improved with placeholder images and reactions when making a reaction on the desktop message actions, the menu won't move anymore simplify logic and stop maintaining a list of unloaded messages
165 lines
4.5 KiB
Ruby
165 lines
4.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Navigating to message", type: :system, js: true do
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:category_channel) }
|
|
fab!(:first_message) { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:chat_drawer_page) { PageObjects::Pages::ChatDrawer.new }
|
|
let(:link) { "My favorite message" }
|
|
|
|
before do
|
|
chat_system_bootstrap
|
|
channel_1.add(current_user)
|
|
75.times { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "when in full page mode" do
|
|
before { chat_page.prefers_full_page }
|
|
|
|
context "when clicking a link containing a message id" do
|
|
fab!(:topic_1) { Fabricate(:topic) }
|
|
|
|
before do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic_1,
|
|
raw: "<a href=\"/chat/c/-/#{channel_1.id}/#{first_message.id}\">#{link}</a>",
|
|
)
|
|
end
|
|
|
|
it "highlights the correct message" do
|
|
visit("/t/-/#{topic_1.id}")
|
|
click_link(link)
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when clicking a link to a message from the current channel" do
|
|
before do
|
|
Fabricate(
|
|
:chat_message,
|
|
chat_channel: channel_1,
|
|
message: "[#{link}](/chat/c/-/#{channel_1.id}/#{first_message.id})",
|
|
)
|
|
end
|
|
|
|
it "highlights the correct message" do
|
|
chat_page.visit_channel(channel_1)
|
|
click_link(link)
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
|
|
it "highlights the correct message after using the bottom arrow" do
|
|
chat_page.visit_channel(channel_1)
|
|
|
|
click_link(link)
|
|
click_button(class: "chat-scroll-to-bottom")
|
|
click_link(link)
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when clicking a link to a message from another channel" do
|
|
fab!(:channel_2) { Fabricate(:category_channel) }
|
|
|
|
before do
|
|
Fabricate(
|
|
:chat_message,
|
|
chat_channel: channel_2,
|
|
message: "[#{link}](/chat/c/-/#{channel_1.id}/#{first_message.id})",
|
|
)
|
|
channel_2.add(current_user)
|
|
end
|
|
|
|
it "highlights the correct message" do
|
|
chat_page.visit_channel(channel_2)
|
|
click_link(link)
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when navigating directly to a message link" do
|
|
it "highglights the correct message" do
|
|
visit("/chat/c/-/#{channel_1.id}/#{first_message.id}")
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when in drawer" do
|
|
context "when clicking a link containing a message id" do
|
|
fab!(:topic_1) { Fabricate(:topic) }
|
|
|
|
before do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic_1,
|
|
raw: "<a href=\"/chat/c/-/#{channel_1.id}/#{first_message.id}\">#{link}</a>",
|
|
)
|
|
end
|
|
|
|
it "highlights correct message" do
|
|
visit("/t/-/#{topic_1.id}")
|
|
click_link(link)
|
|
|
|
expect(page).to have_css(
|
|
".chat-drawer.is-expanded .chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when clicking a link to a message from the current channel" do
|
|
before do
|
|
Fabricate(
|
|
:chat_message,
|
|
chat_channel: channel_1,
|
|
message: "[#{link}](/chat/c/-/#{channel_1.id}/#{first_message.id})",
|
|
)
|
|
end
|
|
|
|
it "highlights the correct message" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.open_channel(channel_1)
|
|
click_link(link)
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
|
|
it "highlights the correct message after using the bottom arrow" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.open_channel(channel_1)
|
|
|
|
click_link(link)
|
|
click_button(class: "chat-scroll-to-bottom")
|
|
click_link(link)
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-container.highlighted[data-id='#{first_message.id}']",
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|