mirror of
https://github.com/discourse/discourse.git
synced 2025-02-15 03:13:02 +08:00
9c8043a4d2
* FEATURE: Enforce mention limits for chat messages The first part of these changes adds a new setting called `max_mentions_per_chat_message`, which skips notifications when the message contains too many mentions. It also respects the `max_users_notified_per_group_mention` setting and skips notifications if expanding a group mention would exceed it. We also include a new component to display JIT warning for these limits to the user while composing a message. * Simplify ignoring/muting filter in chat_notifier * Post-send warnings for unsent warnings * Improve pluralization * Address review feedback * Fix test * Address second feedback round * Third round of feedback Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
104 lines
3.4 KiB
Ruby
104 lines
3.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Chat::Api::HintsController do
|
|
describe "#check_group_mentions" do
|
|
context "for anons" do
|
|
it "returns a 404" do
|
|
get "/chat/api/mentions/groups.json", params: { mentions: %w[group1] }
|
|
|
|
expect(response.status).to eq(403)
|
|
end
|
|
end
|
|
|
|
context "for logged in users" do
|
|
fab!(:user) { Fabricate(:user) }
|
|
fab!(:mentionable_group) { Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:everyone]) }
|
|
fab!(:admin_mentionable_group) { Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:only_admins]) }
|
|
|
|
before { sign_in(user) }
|
|
|
|
it "returns a 400 when no mentions are given" do
|
|
get "/chat/api/mentions/groups.json"
|
|
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "returns a warning when a group is not mentionable" do
|
|
get "/chat/api/mentions/groups.json", params: {
|
|
mentions: [mentionable_group.name, admin_mentionable_group.name]
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["unreachable"]).to contain_exactly(admin_mentionable_group.name)
|
|
end
|
|
|
|
it "returns no warning if the user is allowed to mention" do
|
|
user.update!(admin: true)
|
|
get "/chat/api/mentions/groups.json", params: {
|
|
mentions: [mentionable_group.name, admin_mentionable_group.name]
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["unreachable"]).to be_empty
|
|
end
|
|
|
|
it "returns a warning if the group has too many users" do
|
|
user_1 = Fabricate(:user)
|
|
user_2 = Fabricate(:user)
|
|
mentionable_group.add(user_1)
|
|
mentionable_group.add(user_2)
|
|
SiteSetting.max_users_notified_per_group_mention = 1
|
|
|
|
get "/chat/api/mentions/groups.json", params: {
|
|
mentions: [mentionable_group.name, admin_mentionable_group.name]
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["over_members_limit"]).to contain_exactly(mentionable_group.name)
|
|
end
|
|
|
|
it "returns no warnings when the group doesn't exist" do
|
|
get "/chat/api/mentions/groups.json", params: {
|
|
mentions: ["a_fake_group"]
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["unreachable"]).to be_empty
|
|
expect(response.parsed_body["over_members_limit"]).to be_empty
|
|
end
|
|
|
|
it "doesn't leak groups that are not visible" do
|
|
invisible_group = Fabricate(:group,
|
|
visibility_level: Group.visibility_levels[:staff],
|
|
mentionable_level: Group::ALIAS_LEVELS[:only_admins]
|
|
)
|
|
|
|
get "/chat/api/mentions/groups.json", params: {
|
|
mentions: [invisible_group.name]
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["unreachable"]).to be_empty
|
|
expect(response.parsed_body["over_members_limit"]).to be_empty
|
|
expect(response.parsed_body["invalid"]).to contain_exactly(invisible_group.name)
|
|
end
|
|
|
|
it "triggers a rate-limit on too many requests" do
|
|
RateLimiter.enable
|
|
|
|
5.times do
|
|
get "/chat/api/mentions/groups.json", params: {
|
|
mentions: [mentionable_group.name]
|
|
}
|
|
end
|
|
|
|
get "/chat/api/mentions/groups.json", params: {
|
|
mentions: [mentionable_group.name]
|
|
}
|
|
|
|
expect(response.status).to eq(429)
|
|
end
|
|
end
|
|
end
|
|
end
|