mirror of
https://github.com/discourse/discourse.git
synced 2024-11-27 06:13:43 +08:00
68eba53e09
This is also fixes the issue of chat composer warnings persisting across channels. Currently if you try to mention more groups than is allowed for example, a mention warning pops up. When you change channels the mention warning will not disappear even if there is no text in the composer. This adds a reset function to the chat-composer-warnings-tracker.js, which is called when the channel is changed and the message is empty. In the event that the message is not empty we call captureMentions to check the loaded drafts' mentions. This PR would be nicer if the post-send notice used the new chat notices API to publish the mention warnings but we would have to change the existing ones and I thought that would be too much change for this PR. It'd be a good followup though.
112 lines
4.0 KiB
Ruby
112 lines
4.0 KiB
Ruby
# frozen_string_literal: true
|
||
|
||
RSpec.describe "Mentions warnings", type: :system do
|
||
fab!(:current_user) { Fabricate(:user) }
|
||
fab!(:channel_1) { Fabricate(:chat_channel) }
|
||
fab!(:channel_2) { Fabricate(:chat_channel) }
|
||
|
||
let(:chat_page) { PageObjects::Pages::Chat.new }
|
||
let(:chat_channel_page) { PageObjects::Pages::ChatChannel.new }
|
||
|
||
before do
|
||
chat_system_bootstrap(current_user, [channel_1, channel_2])
|
||
sign_in(current_user)
|
||
end
|
||
|
||
describe "composing a message with mentions" do
|
||
context "when mentioning a group" do
|
||
context "when the group doesn’t allow mentions" do
|
||
fab!(:admin_mentionable_group) do
|
||
Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:only_admins])
|
||
end
|
||
|
||
it "displays a warning" do
|
||
chat_page.visit_channel(channel_1)
|
||
chat_channel_page.type_in_composer("@#{admin_mentionable_group.name} ")
|
||
|
||
expect(page).to have_css(".chat-mention-warnings")
|
||
expect(page.find(".chat-mention-warnings-list__simple")).to have_content(
|
||
admin_mentionable_group.name,
|
||
)
|
||
end
|
||
end
|
||
|
||
context "when the group allow mentions" do
|
||
fab!(:publicly_mentionable_group) do
|
||
Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:everyone])
|
||
end
|
||
fab!(:user_2) { Fabricate(:user) }
|
||
|
||
context "when the group has too many members" do
|
||
before do
|
||
SiteSetting.max_users_notified_per_group_mention = 1
|
||
publicly_mentionable_group.add(user_2)
|
||
publicly_mentionable_group.add(Fabricate(:user))
|
||
end
|
||
|
||
it "displays a warning" do
|
||
chat_page.visit_channel(channel_1)
|
||
chat_channel_page.type_in_composer("@#{publicly_mentionable_group.name} ")
|
||
|
||
expect(page).to have_css(".chat-mention-warnings")
|
||
expect(page.find(".chat-mention-warnings-list__simple")).to have_content(
|
||
publicly_mentionable_group.name,
|
||
)
|
||
end
|
||
end
|
||
|
||
context "when typing too many mentions" do
|
||
before { SiteSetting.max_mentions_per_chat_message = 1 }
|
||
|
||
it "displays a warning" do
|
||
chat_page.visit_channel(channel_1)
|
||
chat_channel_page.type_in_composer(
|
||
"@#{user_2.username} @#{publicly_mentionable_group.name} ",
|
||
)
|
||
|
||
expect(page).to have_css(".chat-mention-warnings")
|
||
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
|
||
end
|
||
end
|
||
end
|
||
end
|
||
|
||
context "when channel has allow_channel_wide_mentions disabled" do
|
||
before { channel_1.update(allow_channel_wide_mentions: false) }
|
||
|
||
%w[@here @all].each do |mention_text|
|
||
it "displays a warning" do
|
||
chat_page.visit_channel(channel_1)
|
||
chat_channel_page.type_in_composer(mention_text)
|
||
|
||
expect(page).to have_css(".chat-mention-warnings")
|
||
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
|
||
end
|
||
end
|
||
|
||
it "retains warnings when loading drafts or changing channels with no draft" do
|
||
Chat::Draft.create!(
|
||
chat_channel: channel_1,
|
||
user: current_user,
|
||
data: { message: "@all" }.to_json,
|
||
)
|
||
chat_page.visit_channel(channel_1)
|
||
|
||
# Channel 1 has a draft that causes a mention warning. Should appear on load
|
||
expect(page).to have_css(".chat-mention-warnings")
|
||
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
|
||
|
||
# Channel 2 doesn't have a draft so it should disappear
|
||
chat_page.visit_channel(channel_2)
|
||
expect(page).to have_no_css(".chat-mention-warnings")
|
||
|
||
# Navigating back to channel 1 will make the mention warnings appear b/c the draft
|
||
# will trigger the @all mention warning again
|
||
chat_page.visit_channel(channel_1)
|
||
expect(page).to have_css(".chat-mention-warnings")
|
||
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
|
||
end
|
||
end
|
||
end
|
||
end
|