mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 03:03:44 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
48 lines
1.1 KiB
Ruby
48 lines
1.1 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe OneboxController do
|
|
|
|
let(:url) { "http://google.com" }
|
|
|
|
it 'invalidates the cache if refresh is passed' do
|
|
Oneboxer.expects(:preview).with(url, invalidate_oneboxes: true)
|
|
xhr :get, :show, url: url, refresh: 'true'
|
|
end
|
|
|
|
describe "found onebox" do
|
|
|
|
let(:body) { "this is the onebox body"}
|
|
|
|
before do
|
|
Oneboxer.expects(:preview).with(url, invalidate_oneboxes: false).returns(body)
|
|
xhr :get, :show, url: url
|
|
end
|
|
|
|
it 'returns success' do
|
|
expect(response).to be_success
|
|
end
|
|
|
|
it 'returns the onebox response in the body' do
|
|
expect(response.body).to eq(body)
|
|
end
|
|
|
|
end
|
|
|
|
describe "missing onebox" do
|
|
|
|
it "returns 404 if the onebox is nil" do
|
|
Oneboxer.expects(:preview).with(url, invalidate_oneboxes: false).returns(nil)
|
|
xhr :get, :show, url: url
|
|
expect(response.response_code).to eq(404)
|
|
end
|
|
|
|
it "returns 404 if the onebox is an empty string" do
|
|
Oneboxer.expects(:preview).with(url, invalidate_oneboxes: false).returns(" \t ")
|
|
xhr :get, :show, url: url
|
|
expect(response.response_code).to eq(404)
|
|
end
|
|
|
|
end
|
|
|
|
end
|