discourse/app/models/user_email_observer.rb
Ricardo Mendes 37f4022f73 Refactors UserEmailObserver to improve Code Climate score
- Extracts certain logic to private methods and remove unnecessary
comments
- Extracts email enqueueing methods into a separate class
- Fix specs involving UserEmailObserver to call #after_commit instead
of the specific methods
2013-08-24 12:21:39 +01:00

79 lines
1.9 KiB
Ruby

class UserEmailObserver < ActiveRecord::Observer
observe :notification
class EmailUser
attr_reader :notification
def initialize(notification)
@notification = notification
end
def mentioned
enqueue :user_mentioned
end
def posted
enqueue :user_posted
end
def quoted
enqueue :user_quoted
end
def replied
enqueue :user_replied
end
def private_message
enqueue_private :user_private_message
end
def invited_to_private_message
enqueue :user_invited_to_private_message
end
private
def enqueue(type)
return unless notification.user.email_direct?
Jobs.enqueue_in(SiteSetting.email_time_window_mins.minutes,
:user_email,
type: type,
user_id: notification.user_id,
notification_id: notification.id)
end
def enqueue_private(type)
return unless (notification.user.email_direct? && notification.user.email_private_messages?)
Jobs.enqueue_in(SiteSetting.email_time_window_mins.minutes,
:user_email,
type: type,
user_id: notification.user_id,
notification_id: notification.id)
end
end
def after_commit(notification)
transaction_includes_action = if rails4?
notification.send(:transaction_include_any_action?, [:create])
else
notification.send(:transaction_include_action?, :create)
end
delegate_to_email_user notification if transaction_includes_action
end
private
def extract_notification_type(notification)
Notification.types[notification.notification_type]
end
def delegate_to_email_user(notification)
email_user = EmailUser.new(notification)
email_method = extract_notification_type notification
email_user.send(email_method) if email_user.respond_to? email_method
end
end