mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 02:50:00 +08:00
6e161d3e75
The most common thing that we do with fab! is:
fab!(:thing) { Fabricate(:thing) }
This commit adds a shorthand for this which is just simply:
fab!(:thing)
i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
49 lines
1.3 KiB
Ruby
49 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe PermalinksController do
|
|
fab!(:topic)
|
|
fab!(:permalink) { Fabricate(:permalink, url: "deadroute/topic/546") }
|
|
|
|
describe "show" do
|
|
it "should redirect to a permalink's target_url with status 301" do
|
|
permalink.update!(topic_id: topic.id)
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should work for subfolder installs too" do
|
|
permalink.update!(topic_id: topic.id)
|
|
set_subfolder "/forum"
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should apply normalizations" do
|
|
permalink.update!(external_url: "/topic/100")
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response).to redirect_to("/topic/100")
|
|
expect(response.status).to eq(301)
|
|
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1X"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it "return 404 if permalink record does not exist" do
|
|
get "/not/a/valid/url"
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
end
|