mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 04:19:05 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
133 lines
3.4 KiB
Ruby
133 lines
3.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Admin::GroupsController do
|
|
|
|
before do
|
|
@admin = log_in(:admin)
|
|
end
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::GroupsController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
context ".index" do
|
|
|
|
it "produces valid json for groups" do
|
|
group = Fabricate.build(:group, name: "test")
|
|
group.add(@admin)
|
|
group.save
|
|
|
|
xhr :get, :index
|
|
expect(response.status).to eq(200)
|
|
expect(::JSON.parse(response.body).keep_if {|r| r["id"] == group.id }).to eq([{
|
|
"id"=>group.id,
|
|
"name"=>group.name,
|
|
"user_count"=>1,
|
|
"automatic"=>false,
|
|
"alias_level"=>0,
|
|
"visible"=>true,
|
|
"automatic_membership_email_domains"=>nil,
|
|
"automatic_membership_retroactive"=>false,
|
|
"title"=>nil,
|
|
"primary_group"=>false,
|
|
"grant_trust_level"=>nil
|
|
}])
|
|
end
|
|
|
|
end
|
|
|
|
context ".bulk" do
|
|
it "can assign users to a group by email or username" do
|
|
group = Fabricate(:group, name: "test", primary_group: true, title: 'WAT')
|
|
user = Fabricate(:user)
|
|
user2 = Fabricate(:user)
|
|
|
|
xhr :put, :bulk_perform, group_id: group.id, users: [user.username.upcase, user2.email, 'doesnt_exist']
|
|
|
|
expect(response).to be_success
|
|
|
|
user.reload
|
|
expect(user.primary_group).to eq(group)
|
|
expect(user.title).to eq("WAT")
|
|
|
|
user2.reload
|
|
expect(user2.primary_group).to eq(group)
|
|
|
|
end
|
|
end
|
|
|
|
context ".create" do
|
|
|
|
it "strip spaces on the group name" do
|
|
xhr :post, :create, name: " bob "
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
groups = Group.where(name: "bob").to_a
|
|
|
|
expect(groups.count).to eq(1)
|
|
expect(groups[0].name).to eq("bob")
|
|
end
|
|
|
|
end
|
|
|
|
context ".update" do
|
|
|
|
it "ignore name change on automatic group" do
|
|
xhr :put, :update, id: 1, name: "WAT", visible: "true"
|
|
expect(response).to be_success
|
|
|
|
group = Group.find(1)
|
|
expect(group.name).not_to eq("WAT")
|
|
expect(group.visible).to eq(true)
|
|
end
|
|
|
|
it "doesn't launch the 'automatic group membership' job when it's not retroactive" do
|
|
Jobs.expects(:enqueue).never
|
|
group = Fabricate(:group)
|
|
xhr :put, :update, id: group.id, automatic_membership_retroactive: "false"
|
|
expect(response).to be_success
|
|
end
|
|
|
|
it "launches the 'automatic group membership' job when it's retroactive" do
|
|
group = Fabricate(:group)
|
|
Jobs.expects(:enqueue).with(:automatic_group_membership, group_id: group.id)
|
|
xhr :put, :update, id: group.id, automatic_membership_retroactive: "true"
|
|
expect(response).to be_success
|
|
end
|
|
|
|
end
|
|
|
|
context ".destroy" do
|
|
|
|
it "returns a 422 if the group is automatic" do
|
|
group = Fabricate(:group, automatic: true)
|
|
xhr :delete, :destroy, id: group.id
|
|
expect(response.status).to eq(422)
|
|
expect(Group.where(id: group.id).count).to eq(1)
|
|
end
|
|
|
|
it "is able to destroy a non-automatic group" do
|
|
group = Fabricate(:group)
|
|
xhr :delete, :destroy, id: group.id
|
|
expect(response.status).to eq(200)
|
|
expect(Group.where(id: group.id).count).to eq(0)
|
|
end
|
|
|
|
end
|
|
|
|
context ".refresh_automatic_groups" do
|
|
|
|
it "is able to refresh automatic groups" do
|
|
Group.expects(:refresh_automatic_groups!).returns(true)
|
|
|
|
xhr :post, :refresh_automatic_groups
|
|
expect(response.status).to eq(200)
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
end
|