mirror of
https://github.com/discourse/discourse.git
synced 2025-02-02 00:03:50 +08:00
f9608c0af5
There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and `INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they were DRYing up: `inline-onebox-loading` and `inline-onebox` I normally appreciate constants, but in this case it meant that we had a lot of JS imports resulting in many more lines of code (and CPU cycles spent figuring them out.) It also meant we had an `.erb` file and had to invoke Ruby to create the JS file, which meant the app was harder to port to Ember CLI. I removed the constants. It's less DRY but faster and simpler, and arguably the loss of DRYness is not significant as you can still search for the `inline-onebox-loading` and `inline-onebox` strings easily if you are refactoring. |
||
|---|---|---|
| .. | ||
| bbcode-test.js | ||
| bookmark-test.js | ||
| break-string-test.js | ||
| category-badge-test.js | ||
| click-track-edit-history-test.js | ||
| click-track-profile-page-test.js | ||
| click-track-test.js | ||
| computed-test.js | ||
| discourse-test.js | ||
| emoji-store-test.js | ||
| emoji-test.js | ||
| formatter-test.js | ||
| highlight-search-test.js.es6 | ||
| i18n-test.js | ||
| icon-library-test.js | ||
| key-value-store-test.js | ||
| link-mentions-test.js | ||
| load-script-test.js | ||
| oneboxer-test.js | ||
| preload-store-test.js | ||
| pretty-text-test.js | ||
| sanitizer-test.js | ||
| screen-track-test.js | ||
| search-test.js | ||
| sharing-test.js | ||
| text-direction-test.js | ||
| to-markdown-test.js | ||
| tooltip-test.js | ||
| upload-short-url-test.js | ||
| uploads-test.js | ||
| url-test.js | ||
| user-search-test.js | ||
| utilities-test.js | ||
| white-lister-test.js | ||