discourse/spec/models/badge_spec.rb
Vinoth Kannan 3358ab6b59
FIX: don't update allow_title column of existing badges in seed. (#13190)
The default `allow_title` column value is "true" for regular and leader badges. After we disable it in admin side the seed method enabling it again while upgrading. So we shouldn't do it for existing badges.
2021-05-28 00:30:57 +05:30

231 lines
6.9 KiB
Ruby

# frozen_string_literal: true
require 'rails_helper'
describe Badge do
it 'has a valid system attribute for new badges' do
expect(Badge.create!(name: "test", badge_type_id: 1).system?).to be false
end
it 'auto translates name' do
badge = Badge.find_by_name("Basic User")
name_english = badge.name
I18n.with_locale(:fr) do
expect(badge.display_name).not_to eq(name_english)
end
end
it 'handles changes on badge description and long description correctly for system badges' do
badge = Badge.find_by_name("Basic User")
badge.description = badge.description.dup
badge.long_description = badge.long_description.dup
badge.save
badge.reload
expect(badge[:description]).to eq(nil)
expect(badge[:long_description]).to eq(nil)
badge.description = "testing"
badge.long_description = "testing it"
badge.save
badge.reload
expect(badge[:description]).to eq("testing")
expect(badge[:long_description]).to eq("testing it")
end
it 'can ensure consistency' do
b = Badge.first
b.grant_count = 100
b.save
UserBadge.create!(user_id: -100, badge_id: b.id, granted_at: 1.minute.ago, granted_by_id: -1)
UserBadge.create!(user_id: User.first.id, badge_id: b.id, granted_at: 1.minute.ago, granted_by_id: -1)
Badge.ensure_consistency!
b.reload
expect(b.grant_count).to eq(1)
end
describe '#manually_grantable?' do
fab!(:badge) { Fabricate(:badge, name: 'Test Badge') }
subject { badge.manually_grantable? }
context 'when system badge' do
before { badge.system = true }
it { is_expected.to be false }
end
context 'when has query' do
before { badge.query = 'SELECT id FROM users' }
it { is_expected.to be false }
end
context 'when neither system nor has query' do
before { badge.update_columns(system: false, query: nil) }
it { is_expected.to be true }
end
end
describe '#image_url' do
it 'has CDN url' do
SiteSetting.enable_s3_uploads = true
SiteSetting.s3_cdn_url = "https://some-s3-cdn.amzn.com"
upload = Fabricate(:upload_s3)
badge = Fabricate(:badge, image_upload_id: upload.id)
expect(badge.image_url).to start_with("https://some-s3-cdn.amzn.com")
end
end
describe '.i18n_name' do
it 'transforms to lower case letters, and replaces spaces with underscores' do
expect(Badge.i18n_name('Basic User')).to eq('basic_user')
end
end
describe '.display_name' do
it 'fetches from translations when i18n_name key exists' do
expect(Badge.display_name('basic_user')).to eq('Basic')
expect(Badge.display_name('Basic User')).to eq('Basic')
end
it 'fallbacks to argument value when translation does not exist' do
expect(Badge.display_name('Not In Translations')).to eq('Not In Translations')
end
end
describe '.find_system_badge_id_from_translation_key' do
let(:translation_key) { 'badges.regular.name' }
it 'uses a translation key to get a system badge id, mainly to find which badge a translation override corresponds to' do
expect(Badge.find_system_badge_id_from_translation_key(translation_key)).to eq(
Badge::Regular
)
end
context 'when the translation key is snake case' do
let(:translation_key) { 'badges.crazy_in_love.name' }
it 'works to get the badge' do
expect(Badge.find_system_badge_id_from_translation_key(translation_key)).to eq(
Badge::CrazyInLove
)
end
end
context 'when a translation key not for a badge is provided' do
let(:translation_key) { 'reports.flags.title' }
it 'returns nil' do
expect(Badge.find_system_badge_id_from_translation_key(translation_key)).to eq(nil)
end
end
context "when translation key doesn't match its class" do
let(:translation_key) { "badges.licensed.long_description" }
it "returns nil" do
expect(Badge.find_system_badge_id_from_translation_key(translation_key)).to eq(nil)
end
end
end
context "First Quote" do
let(:quoted_post_badge) do
Badge.find(Badge::FirstQuote)
end
it "Awards at the correct award date" do
freeze_time
post1 = create_post
raw = <<~RAW
[quote="#{post1.user.username}, post:#{post1.post_number}, topic:#{post1.topic_id}"]
lorem
[/quote]
RAW
post2 = create_post(raw: raw)
quoted_post = QuotedPost.find_by(post_id: post2.id)
freeze_time 1.year.from_now
quoted_post.update!(created_at: Time.now)
BadgeGranter.backfill(quoted_post_badge)
user_badge = post2.user.user_badges.find_by(badge_id: quoted_post_badge.id)
expect(user_badge.granted_at).to eq_time(post2.created_at)
end
end
context "WikiEditor badge" do
it "is awarded" do
wiki_editor_badge = Badge.find(Badge::WikiEditor)
post = Fabricate(:post, wiki: true)
revisor = PostRevisor.new(post)
revisor.revise!(post.user, { raw: "I am editing a wiki" }, force_new_version: true)
BadgeGranter.backfill(wiki_editor_badge)
expect(UserBadge.where(user_id: post.user.id, badge_id: Badge::WikiEditor).count).to eq(1)
end
end
context "PopularLink badge" do
let(:popular_link_badge) do
Badge.find(Badge::PopularLink)
end
before do
popular_link_badge.query = BadgeQueries.linking_badge(2)
popular_link_badge.save!
end
it "is awarded" do
post = create_post(raw: "https://www.discourse.org/")
TopicLinkClick.create_from(url: "https://www.discourse.org/", post_id: post.id, topic_id: post.topic.id, ip: "192.168.0.100")
BadgeGranter.backfill(popular_link_badge)
expect(UserBadge.where(user_id: post.user.id, badge_id: Badge::PopularLink).count).to eq(0)
TopicLinkClick.create_from(url: "https://www.discourse.org/", post_id: post.id, topic_id: post.topic.id, ip: "192.168.0.101")
BadgeGranter.backfill(popular_link_badge)
expect(UserBadge.where(user_id: post.user.id, badge_id: Badge::PopularLink).count).to eq(1)
end
it "is not awarded for links in a restricted category" do
category = Fabricate(:category)
post = create_post(raw: "https://www.discourse.org/", category: category)
category.set_permissions({})
category.save!
TopicLinkClick.create_from(url: "https://www.discourse.org/", post_id: post.id, topic_id: post.topic.id, ip: "192.168.0.100")
TopicLinkClick.create_from(url: "https://www.discourse.org/", post_id: post.id, topic_id: post.topic.id, ip: "192.168.0.101")
BadgeGranter.backfill(popular_link_badge)
expect(UserBadge.where(user_id: post.user.id, badge_id: Badge::PopularLink).count).to eq(0)
end
end
context "#seed" do
let(:regular_badge) do
Badge.find(Badge::Regular)
end
it "`allow_title` is not updated for existing records" do
regular_badge.update(allow_title: false)
SeedFu.seed
regular_badge.reload
expect(regular_badge.allow_title).to eq(false)
end
end
end