mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 23:06:57 +08:00
3f9e7eb326
This reverts commit c279792130
.
This commit inadvertently removed all of the non-staff email logic, rather than just for the 'test email' button.
https://meta.discourse.org/t/112231/5
246 lines
7.1 KiB
Ruby
246 lines
7.1 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Admin::EmailController do
|
|
let(:admin) { Fabricate(:admin) }
|
|
let(:email_log) { Fabricate(:email_log) }
|
|
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::EmailController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
describe '#index' do
|
|
before do
|
|
Admin::EmailController.any_instance
|
|
.expects(:action_mailer_settings)
|
|
.returns(
|
|
username: 'username',
|
|
password: 'secret'
|
|
)
|
|
end
|
|
|
|
it 'does not include the password in the response' do
|
|
get "/admin/email.json"
|
|
mail_settings = JSON.parse(response.body)['settings']
|
|
|
|
expect(
|
|
mail_settings.select { |setting| setting['name'] == 'password' }
|
|
).to be_empty
|
|
end
|
|
end
|
|
|
|
describe '#sent' do
|
|
let(:post) { Fabricate(:post) }
|
|
let(:email_log) { Fabricate(:email_log, post: post) }
|
|
|
|
let(:post_reply_key) do
|
|
Fabricate(:post_reply_key, post: post, user: email_log.user)
|
|
end
|
|
|
|
it "should return the right response" do
|
|
email_log
|
|
get "/admin/email/sent.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
log = JSON.parse(response.body).first
|
|
expect(log["id"]).to eq(email_log.id)
|
|
expect(log["reply_key"]).to eq(nil)
|
|
|
|
post_reply_key
|
|
|
|
get "/admin/email/sent.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
log = JSON.parse(response.body).first
|
|
expect(log["id"]).to eq(email_log.id)
|
|
expect(log["reply_key"]).to eq(post_reply_key.reply_key)
|
|
end
|
|
|
|
it 'should be able to filter by reply key' do
|
|
email_log_2 = Fabricate(:email_log, post: post)
|
|
|
|
post_reply_key_2 = Fabricate(:post_reply_key,
|
|
post: post,
|
|
user: email_log_2.user,
|
|
reply_key: "2d447423-c625-4fb9-8717-ff04ac60eee8"
|
|
)
|
|
|
|
[
|
|
"17ff04",
|
|
"2d447423c6254fb98717ff04ac60eee8"
|
|
].each do |reply_key|
|
|
get "/admin/email/sent.json", params: {
|
|
reply_key: reply_key
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
logs = JSON.parse(response.body)
|
|
|
|
expect(logs.size).to eq(1)
|
|
expect(logs.first["reply_key"]).to eq(post_reply_key_2.reply_key)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#skipped' do
|
|
let(:user) { Fabricate(:user) }
|
|
let!(:log1) { Fabricate(:skipped_email_log, user: user) }
|
|
let!(:log2) { Fabricate(:skipped_email_log) }
|
|
|
|
it "succeeds" do
|
|
get "/admin/email/skipped.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
logs = JSON.parse(response.body)
|
|
|
|
expect(logs.first["id"]).to eq(log2.id)
|
|
expect(logs.last["id"]).to eq(log1.id)
|
|
end
|
|
|
|
describe 'when filtered by username' do
|
|
it 'should return the right response' do
|
|
get "/admin/email/skipped.json", params: {
|
|
user: user.username
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
logs = JSON.parse(response.body)
|
|
|
|
expect(logs.count).to eq(1)
|
|
expect(logs.first["id"]).to eq(log1.id)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#test' do
|
|
it 'raises an error without the email parameter' do
|
|
post "/admin/email/test.json"
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
context 'with an email address' do
|
|
it 'enqueues a test email job' do
|
|
post "/admin/email/test.json", params: { email_address: 'eviltrout@test.domain' }
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(ActionMailer::Base.deliveries.map(&:to).flatten).to include('eviltrout@test.domain')
|
|
end
|
|
end
|
|
|
|
context 'with SiteSetting.disable_emails' do
|
|
let(:eviltrout) { Fabricate(:evil_trout) }
|
|
let(:admin) { Fabricate(:admin) }
|
|
|
|
it 'does not sends mail to anyone when setting is "yes"' do
|
|
SiteSetting.disable_emails = 'yes'
|
|
|
|
post "/admin/email/test.json", params: { email_address: admin.email }
|
|
|
|
incoming = JSON.parse(response.body)
|
|
expect(incoming['sent_test_email_message']).to eq(I18n.t("admin.email.sent_test_disabled"))
|
|
end
|
|
|
|
it 'sends mail to staff only when setting is "non-staff"' do
|
|
SiteSetting.disable_emails = 'non-staff'
|
|
|
|
post "/admin/email/test.json", params: { email_address: admin.email }
|
|
incoming = JSON.parse(response.body)
|
|
expect(incoming['sent_test_email_message']).to eq(I18n.t("admin.email.sent_test"))
|
|
|
|
post "/admin/email/test.json", params: { email_address: eviltrout.email }
|
|
incoming = JSON.parse(response.body)
|
|
expect(incoming['sent_test_email_message']).to eq(I18n.t("admin.email.sent_test_disabled_for_non_staff"))
|
|
end
|
|
|
|
it 'sends mail to everyone when setting is "no"' do
|
|
SiteSetting.disable_emails = 'no'
|
|
|
|
post "/admin/email/test.json", params: { email_address: eviltrout.email }
|
|
|
|
incoming = JSON.parse(response.body)
|
|
expect(incoming['sent_test_email_message']).to eq(I18n.t("admin.email.sent_test"))
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#preview_digest' do
|
|
it 'raises an error without the last_seen_at parameter' do
|
|
get "/admin/email/preview-digest.json"
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "returns the right response when username is invalid" do
|
|
get "/admin/email/preview-digest.json", params: {
|
|
last_seen_at: 1.week.ago, username: "somerandomeusername"
|
|
}
|
|
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "previews the digest" do
|
|
get "/admin/email/preview-digest.json", params: {
|
|
last_seen_at: 1.week.ago, username: admin.username
|
|
}
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
|
|
describe '#handle_mail' do
|
|
it 'should enqueue the right job' do
|
|
expect { post "/admin/email/handle_mail.json", params: { email: email('cc') } }
|
|
.to change { Jobs::ProcessEmail.jobs.count }.by(1)
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
|
|
describe '#rejected' do
|
|
it 'should provide a string for a blank error' do
|
|
Fabricate(:incoming_email, error: "")
|
|
get "/admin/email/rejected.json"
|
|
expect(response.status).to eq(200)
|
|
rejected = JSON.parse(response.body)
|
|
expect(rejected.first['error']).to eq(I18n.t("emails.incoming.unrecognized_error"))
|
|
end
|
|
end
|
|
|
|
describe '#incoming' do
|
|
it 'should provide a string for a blank error' do
|
|
incoming_email = Fabricate(:incoming_email, error: "")
|
|
get "/admin/email/incoming/#{incoming_email.id}.json"
|
|
expect(response.status).to eq(200)
|
|
incoming = JSON.parse(response.body)
|
|
expect(incoming['error']).to eq(I18n.t("emails.incoming.unrecognized_error"))
|
|
end
|
|
end
|
|
|
|
describe '#advanced_test' do
|
|
it 'should ...' do
|
|
email = <<~EMAIL
|
|
From: "somebody" <somebody@example.com>
|
|
To: someone@example.com
|
|
Date: Mon, 3 Dec 2018 00:00:00 -0000
|
|
Subject: This is some subject
|
|
Content-Type: text/plain; charset="UTF-8"
|
|
|
|
Hello, this is a test!
|
|
|
|
---
|
|
|
|
This part should be elided.
|
|
EMAIL
|
|
post "/admin/email/advanced-test.json", params: { email: email }
|
|
expect(response.status).to eq(200)
|
|
incoming = JSON.parse(response.body)
|
|
expect(incoming['format']).to eq(1)
|
|
expect(incoming['text']).to eq("Hello, this is a test!")
|
|
expect(incoming['elided']).to eq("---\n\nThis part should be elided.")
|
|
end
|
|
end
|
|
end
|