github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 10:13:45 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity
417ade98f9
discourse/spec/system
History
Penar Musaraj fe3d82a44a
FIX: Respect the End key when last post is already rendered (#28524) 
Given we are a single-page-app, we hijack the browser's default behavior
for keyboard shortcuts like End because on long topics (20+ posts) we
need to load the last post before really reaching the end of the page.

However, when the last post is already rendered, the End shortcut
currently does nothing, it takes the user to the start of the last post.
If that post is too long, the user will have to scroll down manually.

This change ensures that if the last post of a topic is already rendered
(whether it is in the viewport or not), pressing End will take the user
to the very bottom of the page.

Note for the reviewer: the test added here is for the general case, it
is too hard to test the case where the last post is already rendered,
that isn't covered here.
2024-08-26 14:39:30 -04:00
..
composer FIX: Destroy draft when clicking the Discard button (#28552) 2024-08-26 12:49:26 -03:00
emojis FEATURE: Introduce site settings which require confirmation (#27315) 2024-06-19 16:01:24 +10:00
groups FIX: deleting a groups was throwing an error (#26623) 2024-04-15 08:35:50 +02:00
helpers DEV: make sure we don't load all data into memory when exporting chat messages (#22276) 2023-07-12 18:52:18 +04:00
page_objects FIX: Destroy draft when clicking the Discard button (#28552) 2024-08-26 12:49:26 -03:00
topic_list FIX: Bulk (glimmer) topic selection on mobile (#28100) 2024-07-26 21:16:19 +02:00
user_page FEATURE: "Hot" replacing "Top" as default in the top menu (#28252) 2024-08-08 13:57:42 -04:00
about_page_spec.rb FEATURE: Add estimated number of global and EU visitors to the about page (#28382) 2024-08-21 00:03:42 +03:00
admin_about_config_area_spec.rb FIX: Don't show blank space when there's no banner image (#28366) 2024-08-14 10:34:34 +03:00
admin_backups_spec.rb UX: Apply admin interface guidelines to Backups page (#28051) 2024-08-20 09:59:43 +10:00
admin_badges_spec.rb FIX: correctly reset form before destroying it (#28516) 2024-08-23 14:58:31 +02:00
admin_customize_form_templates_spec.rb FIX: Customize form template view modal footer buttons (#25804) 2024-02-21 22:20:56 -08:00
admin_customize_themes_spec.rb DEV: fix flaky admin_customize_themes spec (#26842) 2024-05-02 08:26:07 +08:00
admin_dashboard_new_features_spec.rb FEATURE: Unseen feature indicator in admin sidebar (#28397) 2024-08-19 14:50:30 +10:00
admin_editing_objects_typed_theme_setting_spec.rb DEV: Remove experimental_objects_type_for_theme_settings site setting (#26507) 2024-04-04 12:01:31 +08:00
admin_embeddable_hosts_spec.rb FEATURE: Extend embeddable hosts with Individual tags and author assignments (#26868) 2024-05-16 15:47:01 -04:00
admin_flags_spec.rb FIX: limit the number of custom flags to 50 (#28221) 2024-08-06 10:50:12 +10:00
admin_plugins_list_spec.rb UX: Remove the link from the title; add external icon; style adjustment (#27571) 2024-06-24 11:02:08 +10:00
admin_sidebar_navigation_spec.rb DEV: Allow system tests to assert on values at the correct time (#27988) 2024-07-20 00:39:22 +08:00
admin_site_setting_requires_confirmation_spec.rb DEV: Fix flaky admin confirmation spec (#27784) 2024-07-09 12:05:31 +10:00
admin_site_setting_search_spec.rb FEATURE: Introduce site settings which require confirmation (#27315) 2024-06-19 16:01:24 +10:00
admin_site_texts_spec.rb FEATURE: Allow showing site text search in selected locale (#28453) 2024-08-26 11:25:36 +10:00
admin_staff_action_logs_spec.rb DEV: Allow for setting a message with SiteSetting.set_and_log (#27447) 2024-06-13 14:59:49 +10:00
admin_user_badges_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
admin_user_fields_spec.rb FEATURE: User fields required for existing users - Part 2 (#27172) 2024-06-25 19:32:18 +08:00
admin_user_spec.rb FIX: Don't show silence button on staff users and display similar users (#28423) 2024-08-20 15:27:29 +03:00
admin_watched_words_spec.rb UX: limit "outputs HTML" watched word option to replacements (#28063) 2024-07-25 16:25:56 -03:00
admin_web_hook_events_spec.rb FEATURE: Add Filter for Webhook Events by Status (#27332) 2024-06-07 10:26:00 -05:00
bookmarks_spec.rb DEV: Resolve TODO comments for martin-brennan 2024-07-01 15:32:30 +10:00
bootstrap_error_pages_spec.rb FIX: Improve handling of 'PublicExceptions' when bootstrap_error_pages enabled (#26700) 2024-04-24 09:40:13 +01:00
category_edit_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
category_topics_spec.rb DEV: Remove unnecessary js: true options from specs (#24463) 2023-11-20 17:22:14 +01:00
change_owner_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
composer_spec.rb FIX: Restore user-cards in composer preview (#27514) 2024-06-19 14:41:32 +02:00
composer_uploads_spec.rb FIX: Video uploads sometimes hang indefinitely (#28523) 2024-08-23 15:58:54 -06:00
content_security_policy_spec.rb DEV: remove legacy CSP implementation to make strict-dynamic only accepted behaviour (#27486) 2024-06-18 16:40:53 +08:00
create_account_spec.rb UX: Registration design and validation improvements (#27666) 2024-07-04 09:17:07 -03:00
csv_exports_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
custom_sidebar_sections_spec.rb A11Y: attempt to refocus modal trigger on modal close (#27972) 2024-07-18 11:55:28 -04:00
discovery_breadcrumb_navigation_spec.rb FEATURE: Show remaining count in category-drop (#25938) 2024-03-07 16:14:50 +02:00
discovery_list_spec.rb FIX: Sorting toggles on topic list (#24465) 2023-11-20 17:45:13 +00:00
dismissing_new_spec.rb UX: Don't hide new navigation item in experimental new new view (#26094) 2024-03-08 09:26:09 +08:00
editing_sidebar_categories_navigation_spec.rb FIX: Make edit categories sidebar modal work more intuitively (#27111) 2024-06-14 11:37:32 -05:00
editing_sidebar_community_section_spec.rb FEATURE: Force admin sidebar for all admins in admin_sidebar_enabled_groups and handle legacy "hamburger dropdown" in this mode (#26899) 2024-05-13 14:40:23 +10:00
editing_sidebar_tags_navigation_spec.rb UX: Fix edit navigation tags modal height too long on desktop (#24765) 2023-12-07 09:42:04 +08:00
email_change_spec.rb FIX: User can't reset password with backup codes when only security key is enabled (#27368) 2024-06-06 14:30:42 +08:00
ember_deprecation_spec.rb DEV: Ensure deprecation warning banner works in development builds (#28302) 2024-08-09 15:04:05 +01:00
filtering_topics_spec.rb FEATURE: enable list keyboard shortcuts on filter route (#27551) 2024-06-20 21:28:52 +10:00
flagging_post_spec.rb DEV: move post flags into database (#27125) 2024-05-23 12:19:07 +10:00
forgot_password_spec.rb FIX: User can't reset password with backup codes when only security key is enabled (#27368) 2024-06-06 14:30:42 +08:00
grant_badge_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
group_activity_spec.rb DEV: Update rubocop-discourse to latest version 2024-03-04 15:08:35 +01:00
group_card_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
hashtag_autocomplete_spec.rb FEATURE: Async load of category and chat hashtags (#25526) 2024-02-12 12:07:14 +02:00
header_spec.rb FIX: Ensure do-not-disturb icon updates correctly (#28253) 2024-08-06 19:13:13 +01:00
homepage_spec.rb FEATURE: "Hot" replacing "Top" as default in the top menu (#28252) 2024-08-08 13:57:42 -04:00
keyboard_shortcuts_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
legacy_widget_header_spec.rb UX: Streamline reset password page (#27341) 2024-06-05 15:22:59 +10:00
login_spec.rb DEV: Convert account activation pages to use Ember (#28206) 2024-08-12 18:02:00 -03:00
navigation_menu_state_integration_spec.rb DEV: Fix typos and formatting (#27320) 2024-06-04 15:16:24 +02:00
network_disconnected_spec.rb DEV: Skip flaky topic map spec on CI (#28159) 2024-07-31 13:04:05 +10:00
new_category_spec.rb FIX: should not raise error when minimum_required_tags value not defined for category. (#27658) 2024-07-01 07:14:34 +05:30
new_topic_list_spec.rb DEV: Add/use two topic fabricators (#27603) 2024-06-25 13:47:53 +02:00
post_menu_spec.rb DEV: Try until success for clipboard copies (#27986) 2024-07-19 19:44:10 +08:00
post_selection_copy_quote_spec.rb DEV: Try until success for clipboard copies (#27986) 2024-07-19 19:44:10 +08:00
post_selection_fast_edit_spec.rb FIX: bypass fast edit when selected text isn't editable 2024-05-24 18:19:28 +02:00
post_small_action_spec.rb DEV: Remove flaky spec (#24641) 2023-11-30 11:06:27 +08:00
powered_by_discourse_spec.rb FEATURE: optionally show "Powered by Discourse" link to discourse.org (#26162) 2024-03-14 10:30:12 -04:00
private_message_map_spec.rb DEV: Skip flaky topic map spec on CI (#28159) 2024-07-31 13:04:05 +10:00
request_tracker_spec.rb DEV: adds logo page component (#28276) 2024-08-08 13:52:48 +02:00
reviewables_spec.rb DEV: Update Reviewables agree and edit action test (#27162) 2024-05-24 12:20:30 -07:00
s3_secure_uploads_spec.rb DEV: Re-enable minio specs by pre-installing minio binary before test run (#24050) 2023-10-24 12:43:14 +10:00
s3_uploads_spec.rb DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
scroll_manager_service_spec.rb DEV: adds logo page component (#28276) 2024-08-08 13:52:48 +02:00
search_spec.rb DEV: adds logo page component (#28276) 2024-08-08 13:52:48 +02:00
signup_spec.rb FIX: subfolder account activation (#28463) 2024-08-21 13:50:38 -03:00
social_authentication_spec.rb DEV: More system specs for signup/login (#27150) 2024-05-23 10:01:05 -03:00
table_builder_spec.rb FEATURE: allow plugins to specify keyboard shortcuts for hidden toolbar items (#28456) 2024-08-23 09:28:28 +10:00
tag_notification_level_spec.rb DEV: Remove superfluous js: true metadata (#21960) 2023-06-07 09:26:58 +08:00
tag_synonyms_spec.rb DEV: Fix random typos (#22078) 2023-06-13 22:02:21 +02:00
tag_view_spec.rb FIX: Refresh the edit tag section when navigating to another tag (#28519) 2024-08-23 20:08:24 +03:00
tags_intersection_spec.rb FIX: Transitioning to tag-intersection route (#23931) 2023-10-13 16:23:04 +01:00
theme_qunit_spec.rb DEV: Stop building test assets in production under Embroider (#23388) 2023-09-11 09:12:37 +01:00
topic_admin_menu_spec.rb FIX: shows errors when converting to public is impossible (#27103) 2024-05-21 12:14:31 +02:00
topic_bulk_select_spec.rb FEATURE: Use new topic bulk actions menu for all sites (#28003) 2024-07-23 11:39:27 +10:00
topic_list_focus_spec.rb DEV: Remove flaky spec (#24795) 2023-12-08 11:43:17 -05:00
topic_map_spec.rb UX: Show topic map in topics without replies by default (#28468) 2024-08-21 17:41:50 -03:00
topic_page_spec.rb FIX: Respect the End key when last post is already rendered (#28524) 2024-08-26 14:39:30 -04:00
topics_unread_when_closed_spec.rb FEATURE: Silence Close Notifications User Setting (#26072) 2024-03-08 15:14:46 -07:00
user_activation_spec.rb FIX: Pass email correctly when resending activation email (#23741) 2023-10-02 13:00:29 +01:00
user_invites_spec.rb FIX: Don't show that an existing user is invited_by another user (#27665) 2024-07-04 10:27:37 +08:00
user_selector_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
user_tips_spec.rb DEV: adds a tooltip system spec component (#28275) 2024-08-08 14:02:00 +02:00
viewing_category_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
viewing_group_members_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
viewing_navigation_menu_preferences_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
viewing_sidebar_as_anonymous_user_spec.rb UX: support links in tag descriptions (#22994) 2023-08-16 11:43:54 -04:00
viewing_sidebar_mobile_spec.rb DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
viewing_sidebar_spec.rb DEV: Untangle the admin sidebar from the sidebar code (#27640) 2024-07-05 13:11:15 -03:00
viewing_user_menu_spec.rb DEV: Add setUserMenuNotificationsLimit plugin-api method (#25119) 2024-01-09 08:38:00 +08:00
viewing_user_private_messages_spec.rb DEV: Fix ember/no-private-routing-service (#24009) 2023-11-29 12:26:52 +01:00
wizard_spec.rb DEV: Update member access wizard step to use toggle group (#28013) 2024-07-29 14:07:06 +08:00