mirror of
https://github.com/discourse/discourse.git
synced 2025-02-17 22:22:46 +08:00
54b2a85b27
When making the list of users to notify we set `all_mentioned_user_ids` key on the `to_notify` Hash.
This hash will be passed around until the actual moment where we send the notifications:
```ruby
identifier_text =
case identifier_type
when :here_mentions
"@here"
when :global_mentions
"@all"
when :direct_mentions
""
else
"@#{identifier_type}"
end
```
As not found `all_mentioned_user_ids` would end up being sent as `@all_mentioned_user_ids` which is obviously incorrect.
This commit is a direct fix to the issue and will remove the key as soon as we have used it sooner up in the chain.
This bug was reproducible when doing this sequence of events:
- create a message with a direct mention: `@bob hi`
- edit this message into a global mention `@all hi`
|
||
|---|---|---|
| .. | ||
| bookmark_extension.rb | ||
| category_extension.rb | ||
| channel_archive_service.rb | ||
| channel_fetcher.rb | ||
| channel_hashtag_data_source.rb | ||
| channel_membership_manager.rb | ||
| direct_message_channel_creator.rb | ||
| duplicate_message_validator.rb | ||
| engine.rb | ||
| guardian_extensions.rb | ||
| mailer.rb | ||
| message_bookmarkable.rb | ||
| message_creator.rb | ||
| message_mover.rb | ||
| message_processor.rb | ||
| message_rate_limiter.rb | ||
| message_reactor.rb | ||
| message_updater.rb | ||
| notifier.rb | ||
| parsed_mentions.rb | ||
| plugin_instance_extension.rb | ||
| post_notification_handler.rb | ||
| review_queue.rb | ||
| reviewable_extension.rb | ||
| secure_uploads_compatibility.rb | ||
| seeder.rb | ||
| slack_compatibility.rb | ||
| statistics.rb | ||
| steps_inspector.rb | ||
| transcript_service.rb | ||
| user_email_extension.rb | ||
| user_extension.rb | ||
| user_notifications_extension.rb | ||
| user_option_extension.rb | ||