mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 07:33:45 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
128 lines
4.6 KiB
Ruby
128 lines
4.6 KiB
Ruby
require 'rails_helper'
|
|
require_dependency 'jobs/base'
|
|
|
|
describe Jobs::EnqueueDigestEmails do
|
|
|
|
describe '#target_users' do
|
|
|
|
context 'disabled digests' do
|
|
before { SiteSetting.stubs(:default_email_digest_frequency).returns(0) }
|
|
let!(:user_no_digests) { Fabricate(:active_user, last_emailed_at: 8.days.ago, last_seen_at: 10.days.ago) }
|
|
|
|
it "doesn't return users with email disabled" do
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(user_no_digests.id)).to eq(false)
|
|
end
|
|
end
|
|
|
|
context 'unapproved users' do
|
|
Given!(:unapproved_user) { Fabricate(:active_user, approved: false, last_emailed_at: 8.days.ago, last_seen_at: 10.days.ago) }
|
|
When { SiteSetting.stubs(:must_approve_users?).returns(true) }
|
|
Then { expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(unapproved_user.id)).to eq(false) }
|
|
|
|
# As a moderator
|
|
And { unapproved_user.update_column(:moderator, true) }
|
|
And { expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(unapproved_user.id)).to eq(true) }
|
|
|
|
# As an admin
|
|
And { unapproved_user.update_attributes(admin: true, moderator: false) }
|
|
And { expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(unapproved_user.id)).to eq(true) }
|
|
|
|
# As an approved user
|
|
And { unapproved_user.update_attributes(admin: false, moderator: false, approved: true ) }
|
|
And { expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(unapproved_user.id)).to eq(true) }
|
|
end
|
|
|
|
context 'staged users' do
|
|
let!(:staged_user) { Fabricate(:active_user, staged: true, last_emailed_at: 1.year.ago, last_seen_at: 1.year.ago) }
|
|
|
|
it "doesn't return staged users" do
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(staged_user.id)).to eq(false)
|
|
end
|
|
end
|
|
|
|
context 'recently emailed' do
|
|
let!(:user_emailed_recently) { Fabricate(:active_user, last_emailed_at: 6.days.ago) }
|
|
|
|
it "doesn't return users who have been emailed recently" do
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(user_emailed_recently.id)).to eq(false)
|
|
end
|
|
|
|
end
|
|
|
|
context "inactive user" do
|
|
let!(:inactive_user) { Fabricate(:user, active: false) }
|
|
|
|
it "doesn't return users who have been emailed recently" do
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(inactive_user.id)).to eq(false)
|
|
end
|
|
end
|
|
|
|
context "suspended user" do
|
|
let!(:suspended_user) { Fabricate(:user, suspended_till: 1.week.from_now, suspended_at: 1.day.ago) }
|
|
|
|
it "doesn't return users who are suspended" do
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(suspended_user.id)).to eq(false)
|
|
end
|
|
end
|
|
|
|
context 'visited the site this week' do
|
|
let(:user_visited_this_week) { Fabricate(:active_user, last_seen_at: 6.days.ago) }
|
|
let(:user_visited_this_week_email_always) { Fabricate(:active_user, last_seen_at: 6.days.ago, email_always: true) }
|
|
|
|
it "doesn't return users who have been emailed recently" do
|
|
user = user_visited_this_week
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(user.id)).to eq(false)
|
|
end
|
|
end
|
|
|
|
context 'visited the site a year ago' do
|
|
let!(:user_visited_a_year_ago) { Fabricate(:active_user, last_seen_at: 370.days.ago) }
|
|
|
|
it "doesn't return the user who have not visited the site for more than 365 days" do
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids.include?(user_visited_a_year_ago.id)).to eq(false)
|
|
end
|
|
end
|
|
|
|
context 'regular users' do
|
|
let!(:user) { Fabricate(:active_user, last_seen_at: 360.days.ago) }
|
|
|
|
it "returns the user" do
|
|
expect(Jobs::EnqueueDigestEmails.new.target_user_ids).to eq([user.id])
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
describe '#execute' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
context "digest emails are enabled" do
|
|
before do
|
|
Jobs::EnqueueDigestEmails.any_instance.expects(:target_user_ids).returns([user.id])
|
|
end
|
|
|
|
it "enqueues the digest email job" do
|
|
SiteSetting.stubs(:disable_digest_emails?).returns(false)
|
|
Jobs.expects(:enqueue).with(:user_email, type: :digest, user_id: user.id)
|
|
Jobs::EnqueueDigestEmails.new.execute({})
|
|
end
|
|
end
|
|
|
|
context "digest emails are disabled" do
|
|
before do
|
|
Jobs::EnqueueDigestEmails.any_instance.expects(:target_user_ids).never
|
|
end
|
|
|
|
it "does not enqueue the digest email job" do
|
|
SiteSetting.stubs(:disable_digest_emails?).returns(true)
|
|
Jobs.expects(:enqueue).with(:user_email, type: :digest, user_id: user.id).never
|
|
Jobs::EnqueueDigestEmails.new.execute({})
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
|
|
end
|