mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 13:38:49 +08:00
ae74d5b32e
#### FIX: Do not use client lastReadMessageId when fetching channel messages We had an issue where the following happened: 1. User opened channel and saw the last message, and we set the lastReadMessageId on the server and the client 2. User navigated to another channel 3. Another user deleted the message in the original channel 4. The first user navigated back to the original channel before the MessageBus event for the deleted message arrived, and got a 404 error because we were sending the deleted lastReadMessageId as target_message_id to the channel controller. Instead of this which is a bit flaky and is hard to cover all the issues for, instead we can pass a fetch_from_last_read boolean param to the channels controller, and just get the user's last_read_message_id straight from the database to use for the target_message_id. This gets rid of any sources of race conditions or lack of updates from MessageBus. #### FIX: Include missing memberships for thread tracking publish When we publish the channel/message tracking state for a user and that message was a thread reply the publisher was erroring because we were not telling Chat::TrackingStateReportQuery to return missing memberships (which have zeroed out unread counts) as well, which is what we do for the channel tracking state here. Also just make sure that the TrackingStateReport does not error when passed an ID it doesn't have data for. |
||
|---|---|---|
| .. | ||
| chat | ||
| service | ||
| service.rb | ||