mirror of
https://github.com/discourse/discourse.git
synced 2024-11-27 13:53:44 +08:00
57ea56ee05
We have all these calls to Group.refresh_automatic_groups! littered throughout the tests. Including tests that are seemingly unrelated to groups. This is because automatic group memberships aren't fabricated when making a vanilla user. There are two places where you'd want to use this: You have fabricated a user that needs a certain trust level (which is now based on group membership.) You need the system user to have a certain trust level. In the first case, we can pass refresh_auto_groups: true to the fabricator instead. This is a more lightweight operation that only considers a single user, instead of all users in all groups. The second case is no longer a thing after #25400.
60 lines
2.4 KiB
Ruby
60 lines
2.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "spam_handler"
|
|
|
|
RSpec.describe SpamHandler do
|
|
describe "#should_prevent_registration_from_ip?" do
|
|
it "works" do
|
|
# max_new_accounts_per_registration_ip = 0 disables the check
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
# only prevents registration for TL0
|
|
SiteSetting.max_new_accounts_per_registration_ip = 2
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
expect {
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
}.to raise_error(ActiveRecord::RecordInvalid)
|
|
end
|
|
|
|
it "doesn't limit registrations since there is a TL2+ user with that IP" do
|
|
# setup
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[2])
|
|
|
|
# should not limit registration
|
|
SiteSetting.max_new_accounts_per_registration_ip = 1
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
it "doesn't limit registrations since there is a staff member with that IP" do
|
|
# setup
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
Fabricate(:moderator, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
# should not limit registration
|
|
SiteSetting.max_new_accounts_per_registration_ip = 1
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
it "doesn't limit registrations when the IP is allowlisted" do
|
|
# setup
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
ScreenedIpAddress.stubs(:is_allowed?).with("42.42.42.42").returns(true)
|
|
|
|
# should not limit registration
|
|
SiteSetting.max_new_accounts_per_registration_ip = 1
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
end
|
|
end
|