mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 18:43:37 +08:00
47f749744f
See: https://meta.discourse.org/t/cant-edit-topic-with-poll-bug-occurs/320845?u=merefield When the Poll is set to "results ON_CLOSE", vote numbers for each option are only streamed to the browser when the vote is Closed. It is therefore not possible to render the Results. The current issue is that when you refresh the page, for those that have voted the default view is results. For this type of poll this should NOT happen. The Results view in this mode should not be possible to see until closure, even for the Author. Because the votes are not yet serialised when this kind of poll remains open, an attempt to display results causes a JavaScript exception and in any case does not make logical sense. So the fix here is making sure the default view, for Polls that have results on close, is the voting view until the Poll is Closed. I've added a test to cover this scenario. Additionally, this requires a refresh of the page when the poll admin actions a Close to ensure the results are serialized in.
261 lines
6.9 KiB
JavaScript
261 lines
6.9 KiB
JavaScript
import EmberObject from "@ember/object";
|
|
import { click, render } from "@ember/test-helpers";
|
|
import hbs from "htmlbars-inline-precompile";
|
|
import { module, test } from "qunit";
|
|
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
|
|
import pretender, { response } from "discourse/tests/helpers/create-pretender";
|
|
import {
|
|
count,
|
|
exists,
|
|
query,
|
|
queryAll,
|
|
} from "discourse/tests/helpers/qunit-helpers";
|
|
import I18n from "discourse-i18n";
|
|
|
|
let requests = 0;
|
|
|
|
module("Poll | Component | poll", function (hooks) {
|
|
setupRenderingTest(hooks);
|
|
|
|
hooks.beforeEach(function () {
|
|
pretender.put("/polls/vote", () => {
|
|
++requests;
|
|
return response({
|
|
poll: {
|
|
name: "poll",
|
|
type: "regular",
|
|
status: "open",
|
|
results: "always",
|
|
options: [
|
|
{
|
|
id: "1f972d1df351de3ce35a787c89faad29",
|
|
html: "yes",
|
|
votes: 1,
|
|
},
|
|
{
|
|
id: "d7ebc3a9beea2e680815a1e4f57d6db6",
|
|
html: "no",
|
|
votes: 0,
|
|
},
|
|
],
|
|
voters: 1,
|
|
chart_type: "bar",
|
|
},
|
|
vote: ["1f972d1df351de3ce35a787c89faad29"],
|
|
});
|
|
});
|
|
});
|
|
|
|
test("shows vote", async function (assert) {
|
|
this.setProperties({
|
|
attributes: EmberObject.create({
|
|
post: EmberObject.create({
|
|
id: 42,
|
|
topic: {
|
|
archived: false,
|
|
},
|
|
user_id: 29,
|
|
}),
|
|
poll: EmberObject.create({
|
|
name: "poll",
|
|
type: "regular",
|
|
status: "closed",
|
|
results: "always",
|
|
options: [
|
|
{ id: "1f972d1df351de3ce35a787c89faad29", html: "yes", votes: 1 },
|
|
{ id: "d7ebc3a9beea2e680815a1e4f57d6db6", html: "no", votes: 0 },
|
|
],
|
|
voters: 1,
|
|
chart_type: "bar",
|
|
}),
|
|
vote: [],
|
|
groupableUserFields: [],
|
|
}),
|
|
preloadedVoters: [],
|
|
});
|
|
|
|
await render(
|
|
hbs`<Poll @attrs={{this.attributes}} @preloadedVoters={{this.preloadedVoters}} />`
|
|
);
|
|
|
|
assert.deepEqual(
|
|
Array.from(queryAll(".results li .option p")).map(
|
|
(span) => span.innerText
|
|
),
|
|
["100% yes", "0% no"]
|
|
);
|
|
});
|
|
|
|
test("does not show results after voting when results are to be shown only on closed", async function (assert) {
|
|
this.setProperties({
|
|
attributes: EmberObject.create({
|
|
post: EmberObject.create({
|
|
id: 42,
|
|
topic: {
|
|
archived: false,
|
|
},
|
|
user_id: 29,
|
|
}),
|
|
hasSavedVote: true,
|
|
poll: EmberObject.create({
|
|
name: "poll",
|
|
type: "regular",
|
|
status: "open",
|
|
results: "on_close",
|
|
options: [
|
|
{ id: "1f972d1df351de3ce35a787c89faad29", html: "yes" },
|
|
{ id: "d7ebc3a9beea2e680815a1e4f57d6db6", html: "no" },
|
|
],
|
|
voters: 1,
|
|
chart_type: "bar",
|
|
}),
|
|
vote: ["1f972d1df351de3ce35a787c89faad29"],
|
|
groupableUserFields: [],
|
|
}),
|
|
preloadedVoters: [],
|
|
});
|
|
|
|
await render(
|
|
hbs`<Poll @attrs={{this.attributes}} @preloadedVoters={{this.preloadedVoters}} />`
|
|
);
|
|
|
|
assert.ok(exists("ul.options"), "options are shown");
|
|
assert.ok(!exists("ul.results"), "results are not shown");
|
|
});
|
|
|
|
test("can vote", async function (assert) {
|
|
this.setProperties({
|
|
attributes: EmberObject.create({
|
|
post: EmberObject.create({
|
|
id: 42,
|
|
topic: {
|
|
archived: false,
|
|
},
|
|
user_id: 29,
|
|
}),
|
|
poll: EmberObject.create({
|
|
name: "poll",
|
|
type: "regular",
|
|
status: "open",
|
|
results: "always",
|
|
options: [
|
|
{ id: "1f972d1df351de3ce35a787c89faad29", html: "yes", votes: 0 },
|
|
{ id: "d7ebc3a9beea2e680815a1e4f57d6db6", html: "no", votes: 0 },
|
|
],
|
|
voters: 0,
|
|
chart_type: "bar",
|
|
}),
|
|
vote: [],
|
|
groupableUserFields: [],
|
|
}),
|
|
preloadedVoters: [],
|
|
});
|
|
|
|
await render(
|
|
hbs`<Poll @attrs={{this.attributes}} @preloadedVoters={{this.preloadedVoters}} />`
|
|
);
|
|
|
|
requests = 0;
|
|
|
|
await click(
|
|
"li[data-poll-option-id='1f972d1df351de3ce35a787c89faad29'] button"
|
|
);
|
|
assert.strictEqual(requests, 1);
|
|
assert.strictEqual(count(".chosen"), 1);
|
|
|
|
await click(".toggle-results");
|
|
assert.strictEqual(
|
|
count("li[data-poll-option-id='1f972d1df351de3ce35a787c89faad29']"),
|
|
1
|
|
);
|
|
});
|
|
|
|
test("cannot vote if not member of the right group", async function (assert) {
|
|
this.setProperties({
|
|
attributes: EmberObject.create({
|
|
post: EmberObject.create({
|
|
id: 42,
|
|
topic: {
|
|
archived: false,
|
|
},
|
|
user_id: 29,
|
|
}),
|
|
poll: EmberObject.create({
|
|
name: "poll",
|
|
type: "regular",
|
|
status: "open",
|
|
results: "always",
|
|
options: [
|
|
{ id: "1f972d1df351de3ce35a787c89faad29", html: "yes", votes: 0 },
|
|
{ id: "d7ebc3a9beea2e680815a1e4f57d6db6", html: "no", votes: 0 },
|
|
],
|
|
voters: 0,
|
|
chart_type: "bar",
|
|
groups: "foo",
|
|
}),
|
|
vote: [],
|
|
groupableUserFields: [],
|
|
}),
|
|
preloadedVoters: [],
|
|
});
|
|
|
|
await render(
|
|
hbs`<Poll @attrs={{this.attributes}} @preloadedVoters={{this.preloadedVoters}} />`
|
|
);
|
|
|
|
requests = 0;
|
|
|
|
await click(
|
|
"li[data-poll-option-id='1f972d1df351de3ce35a787c89faad29'] button"
|
|
);
|
|
assert.strictEqual(
|
|
query(".poll-container .alert").innerText,
|
|
I18n.t("poll.results.groups.title", { groups: "foo" })
|
|
);
|
|
assert.strictEqual(requests, 0);
|
|
assert.ok(!exists(".chosen"));
|
|
});
|
|
|
|
test("voting on a multiple poll with no min attribute", async function (assert) {
|
|
this.setProperties({
|
|
attributes: EmberObject.create({
|
|
post: EmberObject.create({
|
|
id: 42,
|
|
topic: {
|
|
archived: false,
|
|
},
|
|
user_id: 29,
|
|
}),
|
|
poll: EmberObject.create({
|
|
name: "poll",
|
|
type: "multiple",
|
|
status: "open",
|
|
results: "always",
|
|
max: 2,
|
|
options: [
|
|
{ id: "1f972d1df351de3ce35a787c89faad29", html: "yes", votes: 0 },
|
|
{ id: "d7ebc3a9beea2e680815a1e4f57d6db6", html: "no", votes: 0 },
|
|
],
|
|
voters: 0,
|
|
chart_type: "bar",
|
|
}),
|
|
vote: [],
|
|
groupableUserFields: [],
|
|
}),
|
|
preloadedVoters: [],
|
|
});
|
|
await render(
|
|
hbs`<Poll @attrs={{this.attributes}} @preloadedVoters={{this.preloadedVoters}} />`
|
|
);
|
|
|
|
assert.ok(exists(".poll-buttons .cast-votes:disabled"));
|
|
|
|
await click(
|
|
"li[data-poll-option-id='1f972d1df351de3ce35a787c89faad29'] button"
|
|
);
|
|
|
|
await click(".poll-buttons .cast-votes");
|
|
assert.ok(exists(".chosen"));
|
|
});
|
|
});
|