mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 23:05:30 +08:00
03b7b7d1bc
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core. In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`. In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance: ``` <a href {{on "click" (prevent-default (action "x"))}}>Do X</a> ``` Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR. Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform. This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier. Commits: * Enable `no-action-modifiers` template lint rule * Replace {{action "x"}} with {{on "click" (action "x")}} * Remove unnecessary action helper usage * Remove ctl+click tests for user-menu These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed. * Prevent default event handlers to avoid unwanted side effects Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary. * Restore UserCardContents#showUser action to avoid regression By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed. * Revert EditCategoryTab#selectTab -> EditCategoryTab#select Avoid potential breaking change in themes / plugins * Restore GroupCardContents#showGroup action to avoid regression By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed. * Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller. * Refactor away from `actions` hash in ChooseMessage component * Modernize EmojiPicker#onCategorySelection usage * Modernize SearchResultEntry#logClick usage * Modernize Discovery::Categories#showInserted usage * Modernize Preferences::Account#resendConfirmationEmail usage * Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage * Favor fn over action in SelectedChoice component * Modernize WizardStep event handlers * Favor fn over action usage in buttons * Restore Login#forgotPassword action to avoid possible regression * Introduce modKeysPressed utility Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`. * Don't interfere with click events on links with `href` values when modifier keys are pressed
64 lines
2.3 KiB
Handlebars
64 lines
2.3 KiB
Handlebars
<p>{{i18n "admin.email.preview_digest_desc"}}</p>
|
|
|
|
<div class="admin-controls email-preview">
|
|
<div class="controls">
|
|
<div class="inline-form">
|
|
<label for="last-seen">{{i18n "admin.email.last_seen_user"}}</label>
|
|
<DatePickerPast @value={{this.lastSeen}} @id="last-seen" />
|
|
<label>{{i18n "admin.email.user"}}:</label>
|
|
<EmailGroupUserChooser @value={{this.username}} @onChange={{action "updateUsername"}} @options={{hash
|
|
maximum=1
|
|
}} />
|
|
<DButton @class="btn-primary digest-refresh-button" @action={{action "refresh"}} @label="admin.email.refresh" />
|
|
<div class="toggle">
|
|
<label>{{i18n "admin.email.format"}}</label>
|
|
{{#if this.showHtml}}
|
|
<span>{{i18n "admin.email.html"}}</span>
|
|
|
|
|
<a href {{on "click" this.toggleShowHtml}}>
|
|
{{i18n "admin.email.text"}}
|
|
</a>
|
|
{{else}}
|
|
<a href {{on "click" this.toggleShowHtml}}>{{i18n "admin.email.html"}}</a> |
|
|
<span>{{i18n "admin.email.text"}}</span>
|
|
{{/if}}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<ConditionalLoadingSpinner @condition={{this.loading}}>
|
|
|
|
<div class="email-preview-digest">
|
|
{{#if this.showSendEmailForm}}
|
|
<div class="controls">
|
|
<div class="inline-form">
|
|
{{#if this.sendingEmail}}
|
|
{{i18n "admin.email.sending_test"}}
|
|
{{else}}
|
|
<label>{{i18n "admin.email.send_digest_label"}}</label>
|
|
<TextField @value={{this.email}} @placeholderKey="admin.email.test_email_address" />
|
|
<DButton @class="btn-default" @action={{action "sendEmail"}} @disabled={{this.sendEmailDisabled}} @label="admin.email.send_digest" />
|
|
{{#if this.sentEmail}}
|
|
<span class="result-message">{{i18n "admin.email.sent_test"}}</span>
|
|
{{/if}}
|
|
{{/if}}
|
|
</div>
|
|
</div>
|
|
{{/if}}
|
|
|
|
<div class="preview-output">
|
|
{{#if this.showHtml}}
|
|
{{#if this.htmlEmpty}}
|
|
<p>{{i18n "admin.email.no_result"}}</p>
|
|
{{else}}
|
|
<iframe title={{i18n "admin.email.html_preview"}} srcdoc={{this.model.html_content}} />
|
|
{{/if}}
|
|
{{else}}
|
|
<pre>{{html-safe this.model.text_content}}</pre>
|
|
{{/if}}
|
|
</div>
|
|
</div>
|
|
|
|
</ConditionalLoadingSpinner>
|