mirror of
https://github.com/discourse/discourse.git
synced 2024-12-23 01:28:43 +08:00
3894ee6cb6
This commit adds another plugin modifier related to post
actions, similar to ae24e04a5e
.
This will be used to exclude users who liked _and_ reacted to
the post, since now in discourse-reactions we make a Like when
a user reacts too. This will affect the display of the post footer.
179 lines
5.2 KiB
Ruby
179 lines
5.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe PostActionUsersController do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
let(:post) { Fabricate(:post, user: sign_in(user)) }
|
|
|
|
describe "index" do
|
|
describe "when limit params is invalid" do
|
|
include_examples "invalid limit params",
|
|
"/post_action_users.json",
|
|
described_class::INDEX_LIMIT
|
|
end
|
|
end
|
|
|
|
context "with render" do
|
|
it "always allows you to see your own actions" do
|
|
notify_mod = PostActionType.types[:notify_moderators]
|
|
|
|
PostActionCreator.new(
|
|
post.user,
|
|
post,
|
|
notify_mod,
|
|
message: "well something is wrong here!",
|
|
).perform
|
|
PostActionCreator.new(
|
|
Fabricate(:user),
|
|
post,
|
|
notify_mod,
|
|
message: "well something is not wrong here!",
|
|
).perform
|
|
|
|
get "/post_action_users.json", params: { id: post.id, post_action_type_id: notify_mod }
|
|
expect(response.status).to eq(200)
|
|
|
|
users = response.parsed_body["post_action_users"]
|
|
|
|
expect(users.length).to eq(1)
|
|
expect(users[0]["id"]).to eq(post.user.id)
|
|
end
|
|
end
|
|
|
|
it "raises an error without an id" do
|
|
get "/post_action_users.json", params: { post_action_type_id: PostActionType.types[:like] }
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "raises an error without a post action type" do
|
|
get "/post_action_users.json", params: { id: post.id }
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "fails when the user doesn't have permission to see the post" do
|
|
post.trash!
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: post.id,
|
|
post_action_type_id: PostActionType.types[:like],
|
|
}
|
|
|
|
expect(response).to be_forbidden
|
|
end
|
|
|
|
it "raises an error when anon tries to look at an invalid action" do
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: Fabricate(:post).id,
|
|
post_action_type_id: PostActionType.types[:notify_moderators],
|
|
}
|
|
|
|
expect(response).to be_forbidden
|
|
end
|
|
|
|
it "succeeds" do
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: post.id,
|
|
post_action_type_id: PostActionType.types[:like],
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
end
|
|
|
|
it "will return an unknown attribute for muted users" do
|
|
ignored_user = Fabricate(:user)
|
|
PostActionCreator.like(ignored_user, post)
|
|
regular_user = Fabricate(:user)
|
|
PostActionCreator.like(regular_user, post)
|
|
Fabricate(:ignored_user, user: user, ignored_user: ignored_user)
|
|
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: post.id,
|
|
post_action_type_id: PostActionType.types[:like],
|
|
}
|
|
expect(response.status).to eq(200)
|
|
json_users = response.parsed_body["post_action_users"]
|
|
expect(json_users.find { |u| u["id"] == regular_user.id }["unknown"]).to be_blank
|
|
expect(json_users.find { |u| u["id"] == ignored_user.id }["unknown"]).to eq(true)
|
|
end
|
|
|
|
it "paginates post actions" do
|
|
user_ids = []
|
|
5.times do
|
|
user = Fabricate(:user)
|
|
user_ids << user["id"]
|
|
PostActionCreator.like(user, post)
|
|
end
|
|
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: post.id,
|
|
post_action_type_id: PostActionType.types[:like],
|
|
page: 1,
|
|
limit: 2,
|
|
}
|
|
|
|
users = response.parsed_body["post_action_users"]
|
|
total = response.parsed_body["total_rows_post_action_users"]
|
|
|
|
expect(users.length).to eq(2)
|
|
expect(users.map { |u| u["id"] }).to eq(user_ids[2..3])
|
|
|
|
expect(total).to eq(5)
|
|
end
|
|
|
|
it "returns no users when the action type id is invalid" do
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: post.id,
|
|
post_action_type_id: "invalid_action_type",
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
users = response.parsed_body["post_action_users"]
|
|
total = response.parsed_body["total_rows_post_action_users"]
|
|
|
|
expect(users.length).to eq(0)
|
|
expect(total).to be_nil
|
|
end
|
|
|
|
describe "when a plugin registers the :post_action_users_list modifier" do
|
|
before do
|
|
@post_action_1 = PostActionCreator.like(Fabricate(:user), post).post_action
|
|
@post_action_2 = PostActionCreator.like(Fabricate(:user), post).post_action
|
|
end
|
|
|
|
after { DiscoursePluginRegistry.clear_modifiers! }
|
|
|
|
it "allows the plugin to modify the post action query" do
|
|
excluded_post_action_ids = [@post_action_1.id]
|
|
Plugin::Instance
|
|
.new
|
|
.register_modifier(:post_action_users_list) do |query, modifier_post|
|
|
expect(modifier_post.id).to eq(post.id)
|
|
query.where("post_actions.id NOT IN (?)", excluded_post_action_ids)
|
|
end
|
|
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: post.id,
|
|
post_action_type_id: PostActionType.types[:like],
|
|
}
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["post_action_users"].count).to eq(1)
|
|
|
|
DiscoursePluginRegistry.clear_modifiers!
|
|
|
|
get "/post_action_users.json",
|
|
params: {
|
|
id: post.id,
|
|
post_action_type_id: PostActionType.types[:like],
|
|
}
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["post_action_users"].count).to eq(2)
|
|
end
|
|
end
|
|
end
|