discourse/app
Jarek Radosz 4af7b4d543
FIX: Cache breadcrumb-item template (#27585)
…to avoid re-evaulation right before destroying.

With `DeferredTrackedSet` we delay both adding and removing elements from the set. That means when you're transitioning between routes, and breadcrumbs change, both old and new breadcrumbs are rendered (briefly, in a first render pass)

And since the arguments for the old breadcrumbs can be (and often are) destroyed - it would blow up the renderer. By caching the template it will reuse it in that first pass.

---

No test because I couldn't figure out a synthetic test setup where you have breadcrumbs in a deeply nested route and where you navigate from that route to one of the parent routes.
2024-06-24 11:00:05 +10:00
..
assets FIX: Cache breadcrumb-item template (#27585) 2024-06-24 11:00:05 +10:00
controllers FIX: Regression in custom homepage modifier used in theme components (#27569) 2024-06-21 11:24:11 -04:00
helpers FIX: Regression in custom homepage modifier used in theme components (#27569) 2024-06-21 11:24:11 -04:00
jobs FIX: Jobs::EnsureS3UploadsExistence broken for multisite (#27401) 2024-06-10 16:26:39 +08:00
mailers FIX: correctly compute the window for email summaries 2024-05-27 22:33:51 +02:00
models Revert "DEV: Upgrade Rails to version 7.1 (#27539)" 2024-06-21 11:20:40 +02:00
serializers FIX: post revision serializer when tags is a string (#27499) 2024-06-21 08:09:21 +10:00
services Revert "DEV: Upgrade Rails to version 7.1 (#27539)" 2024-06-21 11:20:40 +02:00
views UX: Rename FAQ to Guidelines (#27451) 2024-06-13 12:09:53 -03:00