mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 20:02:46 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
116 lines
2.7 KiB
Ruby
116 lines
2.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe ApplicationRequest do
|
|
before do
|
|
ApplicationRequest.last_flush = Time.now.utc
|
|
$redis.flushall
|
|
end
|
|
|
|
after do
|
|
ApplicationRequest.clear_cache!
|
|
end
|
|
|
|
def inc(key, opts = nil)
|
|
ApplicationRequest.increment!(key, opts)
|
|
end
|
|
|
|
def disable_date_flush!
|
|
freeze_time(Time.now)
|
|
ApplicationRequest.last_flush = Time.now.utc
|
|
end
|
|
|
|
context "readonly test" do
|
|
it 'works even if redis is in readonly' do
|
|
disable_date_flush!
|
|
|
|
inc(:http_total)
|
|
inc(:http_total)
|
|
|
|
$redis.without_namespace.stubs(:incr).raises(Redis::CommandError.new("READONLY"))
|
|
$redis.without_namespace.stubs(:eval).raises(Redis::CommandError.new("READONLY"))
|
|
|
|
# flush will be deferred no error raised
|
|
inc(:http_total, autoflush: 3)
|
|
ApplicationRequest.write_cache!
|
|
|
|
$redis.without_namespace.unstub(:incr)
|
|
$redis.without_namespace.unstub(:eval)
|
|
|
|
inc(:http_total, autoflush: 3)
|
|
expect(ApplicationRequest.http_total.first.count).to eq(3)
|
|
end
|
|
end
|
|
|
|
it 'logs nothing for an unflushed increment' do
|
|
ApplicationRequest.increment!(:anon)
|
|
expect(ApplicationRequest.count).to eq(0)
|
|
end
|
|
|
|
it 'can automatically flush' do
|
|
disable_date_flush!
|
|
|
|
inc(:http_total)
|
|
inc(:http_total)
|
|
inc(:http_total, autoflush: 3)
|
|
|
|
expect(ApplicationRequest.http_total.first.count).to eq(3)
|
|
|
|
inc(:http_total)
|
|
inc(:http_total)
|
|
inc(:http_total, autoflush: 3)
|
|
|
|
expect(ApplicationRequest.http_total.first.count).to eq(6)
|
|
end
|
|
|
|
it 'can flush based on time' do
|
|
t1 = Time.now.utc.at_midnight
|
|
freeze_time(t1)
|
|
ApplicationRequest.write_cache!
|
|
inc(:http_total)
|
|
expect(ApplicationRequest.count).to eq(0)
|
|
|
|
freeze_time(t1 + ApplicationRequest.autoflush_seconds + 1)
|
|
inc(:http_total)
|
|
|
|
expect(ApplicationRequest.count).to eq(1)
|
|
end
|
|
|
|
it 'flushes yesterdays results' do
|
|
t1 = Time.now.utc.at_midnight
|
|
freeze_time(t1)
|
|
inc(:http_total)
|
|
freeze_time(t1.tomorrow)
|
|
inc(:http_total)
|
|
|
|
ApplicationRequest.write_cache!
|
|
expect(ApplicationRequest.count).to eq(2)
|
|
end
|
|
|
|
it 'clears cache correctly' do
|
|
# otherwise we have test pollution
|
|
inc(:anon)
|
|
ApplicationRequest.clear_cache!
|
|
ApplicationRequest.write_cache!
|
|
|
|
expect(ApplicationRequest.count).to eq(0)
|
|
end
|
|
|
|
it 'logs a few counts once flushed' do
|
|
time = Time.now.at_midnight
|
|
freeze_time(time)
|
|
|
|
3.times { inc(:http_total) }
|
|
2.times { inc(:http_2xx) }
|
|
4.times { inc(:http_3xx) }
|
|
|
|
ApplicationRequest.write_cache!
|
|
|
|
expect(ApplicationRequest.http_total.first.count).to eq(3)
|
|
expect(ApplicationRequest.http_2xx.first.count).to eq(2)
|
|
expect(ApplicationRequest.http_3xx.first.count).to eq(4)
|
|
|
|
end
|
|
end
|