mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 05:34:28 +08:00
d1984a0b4d
Previously we would raise a 500 error if a moderator tried to agree on a flag another moderator deferred. This can happen cause the UX for flags does not live refresh as flags are handled
86 lines
2.6 KiB
Ruby
86 lines
2.6 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Admin::FlagsController do
|
|
let(:admin) { Fabricate(:admin) }
|
|
let(:post_1) { Fabricate(:post) }
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
context '#index' do
|
|
it 'should return the right response when nothing is flagged' do
|
|
get '/admin/flags.json'
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
data = ::JSON.parse(response.body)
|
|
expect(data["users"]).to eq([])
|
|
expect(data["posts"]).to eq([])
|
|
end
|
|
|
|
it 'should return the right response' do
|
|
PostAction.act(user, post_1, PostActionType.types[:spam])
|
|
|
|
get '/admin/flags.json'
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
data = ::JSON.parse(response.body)
|
|
expect(data["users"].length).to eq(2)
|
|
expect(data["posts"].length).to eq(1)
|
|
end
|
|
end
|
|
|
|
context '#agree' do
|
|
it 'should raise a reasonable error if a flag was deferred and then someone else agreed' do
|
|
SiteSetting.queue_jobs = false
|
|
|
|
_post_action = PostAction.act(user, post_1, PostActionType.types[:spam], message: 'bad')
|
|
|
|
post "/admin/flags/defer/#{post_1.id}.json"
|
|
expect(response.status).to eq(200)
|
|
|
|
post "/admin/flags/agree/#{post_1.id}.json", params: { action_on_post: 'keep' }
|
|
# 409 means conflict which is what is happening here
|
|
expect(response.status).to eq(409)
|
|
error = JSON.parse(response.body)["errors"].first
|
|
expect(error).to eq(I18n.t("flags.errors.already_handled"))
|
|
end
|
|
|
|
it 'should be able to agree and keep content' do
|
|
SiteSetting.queue_jobs = false
|
|
|
|
post_action = PostAction.act(user, post_1, PostActionType.types[:spam], message: 'bad')
|
|
|
|
post "/admin/flags/agree/#{post_1.id}.json", params: { action_on_post: 'keep' }
|
|
expect(response.status).to eq(200)
|
|
|
|
post_action.reload
|
|
expect(post_action.agreed_by_id).to eq(admin.id)
|
|
|
|
post_1.reload
|
|
expect(post_1.deleted_at).to eq(nil)
|
|
end
|
|
|
|
it 'should be able to hide spam' do
|
|
SiteSetting.allow_user_locale = true
|
|
SiteSetting.queue_jobs = false
|
|
|
|
post_action = PostAction.act(user, post_1, PostActionType.types[:spam], message: 'bad')
|
|
admin.update!(locale: 'ja')
|
|
|
|
post "/admin/flags/agree/#{post_1.id}.json"
|
|
expect(response.status).to eq(200)
|
|
|
|
post_action.reload
|
|
|
|
expect(post_action.agreed_by_id).to eq(admin.id)
|
|
|
|
agree_post = Topic.joins(:topic_allowed_users).where('topic_allowed_users.user_id = ?', user.id).order(:id).last.posts.last
|
|
expect(agree_post.raw).to eq(I18n.with_locale(:en) { I18n.t('flags_dispositions.agreed') })
|
|
end
|
|
end
|
|
end
|