mirror of
https://github.com/discourse/discourse.git
synced 2024-12-14 06:06:29 +08:00
9ebf7c9c37
Some combinations of start_date and frequency/interval values can cause a recurring automation rule to either trigger before its start_date or never trigger. Example repros: - Configure a recurring automation with hourly recurrence and a start_date several days ahead. What this will do is make the automation start running hourly immediately even though the start_date is several days ahead. - Configure a recurring automation with a weekly recurrence and a start_date several weeks ahead. This will result in the automation never triggering even after the start_date. These 2 scenarios share the same cause which is that the automation plugin doesn't use the start_date as the date for the first run and instead uses the frequency/interval values from the current time to calculate the first run date. This PR fixes this bug by adding an explicit check for start_date and using it as the first run's date if it's ahead of the current time. |
||
|---|---|---|
| .. | ||
| after_post_cook_spec.rb | ||
| category_created_edited_spec.rb | ||
| pm_created_spec.rb | ||
| point_in_time_spec.rb | ||
| post_created_edited_spec.rb | ||
| recurring_spec.rb | ||
| stalled_wiki_spec.rb | ||
| topic_spec.rb | ||
| user_added_to_group_spec.rb | ||
| user_badge_granted_spec.rb | ||
| user_first_logged_in_spec.rb | ||
| user_promoted_spec.rb | ||
| user_removed_from_group_spec.rb | ||
| user_updated_spec.rb | ||