mirror of
https://github.com/discourse/discourse.git
synced 2025-03-13 08:45:19 +08:00
8ca2c14874
Previously the return to forum link would automatically take you to the forum homepage, however this was not intended functionality. We should attempt to take the user to their last viewed forum page. This change fixes a bug in how we determined what the destination link should be. Internal ref: /t/110508
325 lines
11 KiB
Ruby
325 lines
11 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Separate sidebar mode", type: :system do
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:sidebar_page) { PageObjects::Pages::Sidebar.new }
|
|
let(:sidebar_component) { PageObjects::Components::NavigationMenu::Sidebar.new }
|
|
let(:chat_drawer_page) { PageObjects::Pages::ChatDrawer.new }
|
|
let(:header_component) { PageObjects::Components::Chat::Header.new }
|
|
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:chat_channel) }
|
|
fab!(:channel_2) { Fabricate(:chat_channel) }
|
|
|
|
before do
|
|
SiteSetting.navigation_menu = "sidebar"
|
|
channel_1.add(current_user)
|
|
channel_2.add(current_user)
|
|
chat_system_bootstrap
|
|
sign_in(current_user)
|
|
end
|
|
|
|
describe "when separate sidebar mode is not set" do
|
|
before do
|
|
SiteSetting.chat_separate_sidebar_mode = "always"
|
|
chat_page.prefers_full_page
|
|
end
|
|
|
|
it "uses the site setting" do
|
|
visit("/")
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
chat_page.open_from_header
|
|
|
|
expect(sidebar_component).to have_switch_button("main")
|
|
expect(header_component).to have_open_forum_button
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_no_section("Categories")
|
|
|
|
click_logo
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
end
|
|
end
|
|
|
|
describe "when separate sidebar mode is never" do
|
|
before do
|
|
current_user.user_option.update!(
|
|
chat_separate_sidebar_mode: UserOption.chat_separate_sidebar_modes[:never],
|
|
)
|
|
end
|
|
|
|
context "with drawer" do
|
|
before { chat_page.prefers_drawer }
|
|
|
|
it "has the expected behavior" do
|
|
visit("/")
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
sidebar_page.open_channel(channel_1)
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
chat_drawer_page.close
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
end
|
|
end
|
|
|
|
context "with full page" do
|
|
before { chat_page.prefers_full_page }
|
|
|
|
it "has the expected behavior" do
|
|
visit("/")
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
sidebar_page.open_channel(channel_1)
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
click_logo
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "when separate sidebar mode is always" do
|
|
before do
|
|
current_user.user_option.update(
|
|
chat_separate_sidebar_mode: UserOption.chat_separate_sidebar_modes[:always],
|
|
)
|
|
end
|
|
|
|
context "with drawer" do
|
|
before { chat_page.prefers_drawer }
|
|
|
|
it "has the expected behavior" do
|
|
visit("/")
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
|
|
chat_page.open_from_header
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
|
|
chat_drawer_page.close
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
chat_drawer_page.open_channel(channel_2)
|
|
|
|
expect(chat_drawer_page).to have_open_channel(channel_2)
|
|
|
|
chat_drawer_page.close
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(chat_drawer_page).to have_open_channel(channel_2)
|
|
end
|
|
end
|
|
|
|
context "with full page" do
|
|
before { chat_page.prefers_full_page }
|
|
|
|
it "has the expected behavior" do
|
|
visit("/")
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
chat_page.open_from_header
|
|
|
|
expect(sidebar_component).to have_switch_button("main")
|
|
expect(header_component).to have_open_forum_button
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_no_section("Categories")
|
|
|
|
click_logo
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_no_section("Categories")
|
|
|
|
sidebar_component.switch_to_main
|
|
|
|
expect(sidebar_component).to have_no_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
sidebar_component.switch_to_chat
|
|
sidebar_page.open_channel(channel_2)
|
|
|
|
expect(sidebar_component).to have_section_link(channel_2.name, active: true)
|
|
|
|
chat_page.close_from_header
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(sidebar_component).to have_section_link(channel_2.name, active: true)
|
|
end
|
|
end
|
|
|
|
context "with subfolder" do
|
|
let!(:channel_browse_page) { PageObjects::Pages::ChatBrowse.new }
|
|
|
|
before do
|
|
set_subfolder "/discuss"
|
|
chat_page.prefers_full_page
|
|
end
|
|
|
|
it "has the expected behavior" do
|
|
visit("/discuss/about")
|
|
|
|
sidebar_component.switch_to_chat
|
|
expect(channel_browse_page.component).to be_present
|
|
|
|
sidebar_component.switch_to_main
|
|
expect(page).to have_current_path("/discuss/about")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "when separate sidebar mode is fullscreen" do
|
|
before do
|
|
current_user.user_option.update(
|
|
chat_separate_sidebar_mode: UserOption.chat_separate_sidebar_modes[:fullscreen],
|
|
)
|
|
end
|
|
|
|
context "with drawer" do
|
|
before { chat_page.prefers_drawer }
|
|
|
|
it "has the expected behavior" do
|
|
visit("/")
|
|
|
|
expect(sidebar_component).to have_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
sidebar_page.open_channel(channel_1)
|
|
|
|
expect(sidebar_component).to have_no_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
chat_drawer_page.close
|
|
|
|
expect(sidebar_component).to have_switch_button
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(sidebar_component).to have_section("Categories")
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
|
|
sidebar_page.open_channel(channel_2)
|
|
|
|
expect(sidebar_component).to have_section_link(channel_2.name, active: true)
|
|
|
|
chat_drawer_page.close
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(sidebar_component).to have_section_link(channel_2.name, active: true)
|
|
end
|
|
end
|
|
|
|
context "with full page" do
|
|
before { chat_page.prefers_full_page }
|
|
|
|
it "has the expected behavior" do
|
|
visit("/")
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
sidebar_page.open_channel(channel_1)
|
|
|
|
expect(sidebar_component).to have_switch_button("main")
|
|
expect(header_component).to have_open_forum_button
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_no_section("Categories")
|
|
|
|
click_logo
|
|
|
|
expect(sidebar_component).to have_switch_button("chat")
|
|
expect(header_component).to have_open_chat_button
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_no_section("Categories")
|
|
|
|
sidebar_component.switch_to_main
|
|
|
|
expect(sidebar_component).to have_section("chat-channels")
|
|
expect(sidebar_component).to have_section("Categories")
|
|
|
|
sidebar_component.switch_to_chat
|
|
sidebar_page.open_channel(channel_2)
|
|
|
|
expect(sidebar_component).to have_section_link(channel_2.name, active: true)
|
|
|
|
chat_page.close_from_header
|
|
sidebar_component.switch_to_chat
|
|
|
|
expect(sidebar_component).to have_section_link(channel_2.name, active: true)
|
|
end
|
|
end
|
|
end
|
|
end
|