mirror of
https://github.com/discourse/discourse.git
synced 2024-12-13 13:33:47 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
43 lines
1.0 KiB
Ruby
43 lines
1.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe TopicViewItem do
|
|
|
|
def add(topic_id, ip, user_id = nil)
|
|
skip_redis = true
|
|
TopicViewItem.add(topic_id, ip, user_id, nil, skip_redis)
|
|
end
|
|
|
|
it "raises nothing for dupes" do
|
|
add(2, "1.1.1.1")
|
|
add(2, "1.1.1.1", 1)
|
|
|
|
TopicViewItem.create!(topic_id: 1, ip_address: "1.1.1.1", viewed_at: 1.day.ago)
|
|
add(1, "1.1.1.1")
|
|
|
|
expect(TopicViewItem.count).to eq(3)
|
|
end
|
|
|
|
it "increases a users view count" do
|
|
user = Fabricate(:user)
|
|
|
|
add(1, "1.1.1.1", user.id)
|
|
add(1, "1.1.1.1", user.id)
|
|
|
|
user.user_stat.reload
|
|
expect(user.user_stat.topics_entered).to eq(1)
|
|
end
|
|
|
|
it "does not log IP address for logged-in users" do
|
|
topic = Fabricate(:topic)
|
|
user = Fabricate(:user)
|
|
add(topic.id, "1.1.1.1", user.id)
|
|
|
|
expect(TopicViewItem.find_by(topic_id: topic.id, user_id: user.id).ip_address).to eq(nil)
|
|
add(topic.id, "1.2.3.4", nil)
|
|
expect(TopicViewItem.find_by(topic_id: topic.id, user_id: nil).ip_address).to eq("1.2.3.4")
|
|
end
|
|
|
|
end
|