mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 04:33:52 +08:00
03b7b7d1bc
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core. In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`. In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance: ``` <a href {{on "click" (prevent-default (action "x"))}}>Do X</a> ``` Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR. Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform. This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier. Commits: * Enable `no-action-modifiers` template lint rule * Replace {{action "x"}} with {{on "click" (action "x")}} * Remove unnecessary action helper usage * Remove ctl+click tests for user-menu These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed. * Prevent default event handlers to avoid unwanted side effects Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary. * Restore UserCardContents#showUser action to avoid regression By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed. * Revert EditCategoryTab#selectTab -> EditCategoryTab#select Avoid potential breaking change in themes / plugins * Restore GroupCardContents#showGroup action to avoid regression By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed. * Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller. * Refactor away from `actions` hash in ChooseMessage component * Modernize EmojiPicker#onCategorySelection usage * Modernize SearchResultEntry#logClick usage * Modernize Discovery::Categories#showInserted usage * Modernize Preferences::Account#resendConfirmationEmail usage * Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage * Favor fn over action in SelectedChoice component * Modernize WizardStep event handlers * Favor fn over action usage in buttons * Restore Login#forgotPassword action to avoid possible regression * Introduce modKeysPressed utility Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`. * Don't interfere with click events on links with `href` values when modifier keys are pressed
67 lines
1.8 KiB
JavaScript
67 lines
1.8 KiB
JavaScript
import { empty, notEmpty, or } from "@ember/object/computed";
|
|
import Controller from "@ember/controller";
|
|
import EmailPreview from "admin/models/email-preview";
|
|
import { action, get } from "@ember/object";
|
|
import { popupAjaxError } from "discourse/lib/ajax-error";
|
|
import { inject as service } from "@ember/service";
|
|
|
|
export default Controller.extend({
|
|
dialog: service(),
|
|
username: null,
|
|
lastSeen: null,
|
|
emailEmpty: empty("email"),
|
|
sendEmailDisabled: or("emailEmpty", "sendingEmail"),
|
|
showSendEmailForm: notEmpty("model.html_content"),
|
|
htmlEmpty: empty("model.html_content"),
|
|
|
|
@action
|
|
toggleShowHtml(event) {
|
|
event?.preventDefault();
|
|
this.toggleProperty("showHtml");
|
|
},
|
|
|
|
actions: {
|
|
updateUsername(selected) {
|
|
this.set("username", get(selected, "firstObject"));
|
|
},
|
|
|
|
refresh() {
|
|
const model = this.model;
|
|
|
|
this.set("loading", true);
|
|
this.set("sentEmail", false);
|
|
|
|
let username = this.username;
|
|
if (!username) {
|
|
username = this.currentUser.get("username");
|
|
this.set("username", username);
|
|
}
|
|
|
|
EmailPreview.findDigest(username, this.lastSeen).then((email) => {
|
|
model.setProperties(
|
|
email.getProperties("html_content", "text_content")
|
|
);
|
|
this.set("loading", false);
|
|
});
|
|
},
|
|
|
|
sendEmail() {
|
|
this.set("sendingEmail", true);
|
|
this.set("sentEmail", false);
|
|
|
|
EmailPreview.sendDigest(this.username, this.lastSeen, this.email)
|
|
.then((result) => {
|
|
if (result.errors) {
|
|
this.dialog.alert(result.errors);
|
|
} else {
|
|
this.set("sentEmail", true);
|
|
}
|
|
})
|
|
.catch(popupAjaxError)
|
|
.finally(() => {
|
|
this.set("sendingEmail", false);
|
|
});
|
|
},
|
|
},
|
|
});
|