mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 21:10:17 +08:00
59097b207f
Over the years we accrued many spelling mistakes in the code base. This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change - comments - test descriptions - other low risk areas
257 lines
8.4 KiB
Ruby
257 lines
8.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require 'promotion'
|
|
|
|
describe Promotion do
|
|
|
|
describe "review" do
|
|
it "skips regular users" do
|
|
# Reviewing users at higher trust levels is expensive, so trigger those reviews in a background job.
|
|
regular = Fabricate.build(:user, trust_level: TrustLevel[2])
|
|
promotion = described_class.new(regular)
|
|
promotion.expects(:review_tl2).never
|
|
promotion.review
|
|
end
|
|
end
|
|
|
|
context "newuser" do
|
|
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[0], created_at: 2.days.ago) }
|
|
let(:promotion) { Promotion.new(user) }
|
|
|
|
it "doesn't raise an error with a nil user" do
|
|
expect { Promotion.new(nil).review }.not_to raise_error
|
|
end
|
|
|
|
context 'that has done nothing' do
|
|
let!(:result) { promotion.review }
|
|
|
|
it "returns false" do
|
|
expect(result).to eq(false)
|
|
end
|
|
|
|
it "has not changed the user's trust level" do
|
|
expect(user.trust_level).to eq(TrustLevel[0])
|
|
end
|
|
end
|
|
|
|
context "that has done the requisite things" do
|
|
|
|
before do
|
|
stat = user.user_stat
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
@result = promotion.review
|
|
end
|
|
|
|
it "returns true" do
|
|
expect(@result).to eq(true)
|
|
end
|
|
|
|
it "has upgraded the user to basic" do
|
|
expect(user.trust_level).to eq(TrustLevel[1])
|
|
end
|
|
end
|
|
|
|
context "that has not done the requisite things" do
|
|
it "does not promote the user" do
|
|
user.created_at = 1.minute.ago
|
|
stat = user.user_stat
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
@result = promotion.review
|
|
expect(@result).to eq(false)
|
|
expect(user.trust_level).to eq(TrustLevel[0])
|
|
end
|
|
end
|
|
|
|
context "may send tl1 promotion messages" do
|
|
before do
|
|
stat = user.user_stat
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
end
|
|
it "sends promotion message by default" do
|
|
SiteSetting.send_tl1_welcome_message = true
|
|
@result = promotion.review
|
|
expect(Jobs::SendSystemMessage.jobs.length).to eq(1)
|
|
job = Jobs::SendSystemMessage.jobs[0]
|
|
expect(job["args"][0]["user_id"]).to eq(user.id)
|
|
expect(job["args"][0]["message_type"]).to eq("welcome_tl1_user")
|
|
end
|
|
|
|
it "does not not send when the user already has the tl1 badge when recalculating" do
|
|
SiteSetting.send_tl1_welcome_message = true
|
|
BadgeGranter.grant(Badge.find(1), user)
|
|
stat = user.user_stat
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
Promotion.recalculate(user)
|
|
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
|
|
end
|
|
|
|
it "can be turned off" do
|
|
SiteSetting.send_tl1_welcome_message = false
|
|
@result = promotion.review
|
|
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
|
|
end
|
|
end
|
|
|
|
context "may send tl2 promotion messages" do
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[1], created_at: (SiteSetting.tl2_requires_time_spent_mins * 60).minutes.ago) }
|
|
|
|
before do
|
|
stat = user.user_stat
|
|
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
|
|
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
|
|
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
|
|
stat.days_visited = SiteSetting.tl2_requires_days_visited
|
|
stat.likes_received = SiteSetting.tl2_requires_likes_received
|
|
stat.likes_given = SiteSetting.tl2_requires_likes_given
|
|
SiteSetting.tl2_requires_topic_reply_count = 0
|
|
SiteSetting.send_tl2_promotion_message = true
|
|
end
|
|
|
|
it "sends promotion message by default" do
|
|
expect_enqueued_with(job: :send_system_message, args: { user_id: user.id, message_type: 'tl2_promotion_message' }) do
|
|
@result = promotion.review
|
|
end
|
|
end
|
|
|
|
it "can be turned off" do
|
|
SiteSetting.send_tl2_promotion_message = false
|
|
expect_not_enqueued_with(job: :send_system_message) do
|
|
@result = promotion.review
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "basic" do
|
|
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[1], created_at: 2.days.ago) }
|
|
let(:promotion) { Promotion.new(user) }
|
|
|
|
context 'that has done nothing' do
|
|
let!(:result) { promotion.review }
|
|
|
|
it "returns false" do
|
|
expect(result).to eq(false)
|
|
end
|
|
|
|
it "has not changed the user's trust level" do
|
|
expect(user.trust_level).to eq(TrustLevel[1])
|
|
end
|
|
end
|
|
|
|
context "that has done the requisite things" do
|
|
|
|
before do
|
|
SiteSetting.tl2_requires_topic_reply_count = 3
|
|
|
|
stat = user.user_stat
|
|
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
|
|
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
|
|
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
|
|
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
|
|
stat.likes_received = SiteSetting.tl2_requires_likes_received
|
|
stat.likes_given = SiteSetting.tl2_requires_likes_given
|
|
SiteSetting.tl2_requires_topic_reply_count.times do |_|
|
|
topic = Fabricate(:topic)
|
|
reply = Fabricate(:post, topic: topic, user: user, post_number: 2)
|
|
end
|
|
|
|
@result = promotion.review
|
|
end
|
|
|
|
it "returns true" do
|
|
expect(@result).to eq(true)
|
|
end
|
|
|
|
it "has upgraded the user to regular" do
|
|
expect(user.trust_level).to eq(TrustLevel[2])
|
|
end
|
|
end
|
|
|
|
context "when the account hasn't existed long enough" do
|
|
it "does not promote the user" do
|
|
user.created_at = 1.minute.ago
|
|
SiteSetting.tl2_requires_topic_reply_count = 3
|
|
|
|
stat = user.user_stat
|
|
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
|
|
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
|
|
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
|
|
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
|
|
stat.likes_received = SiteSetting.tl2_requires_likes_received
|
|
stat.likes_given = SiteSetting.tl2_requires_likes_given
|
|
SiteSetting.tl2_requires_topic_reply_count.times do |_|
|
|
topic = Fabricate(:topic)
|
|
reply = Fabricate(:post, topic: topic, user: user, post_number: 2)
|
|
end
|
|
|
|
result = promotion.review
|
|
expect(result).to eq(false)
|
|
expect(user.trust_level).to eq(TrustLevel[1])
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
context "regular" do
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[2]) }
|
|
let(:promotion) { Promotion.new(user) }
|
|
|
|
context "doesn't qualify for promotion" do
|
|
before do
|
|
TrustLevel3Requirements.any_instance.expects(:requirements_met?).at_least_once.returns(false)
|
|
end
|
|
|
|
it "review_tl2 returns false" do
|
|
expect {
|
|
expect(promotion.review_tl2).to eq(false)
|
|
}.to_not change { user.reload.trust_level }
|
|
end
|
|
|
|
it "doesn't promote" do
|
|
expect {
|
|
promotion.review_tl2
|
|
}.to_not change { user.reload.trust_level }
|
|
end
|
|
|
|
it "doesn't log a trust level change" do
|
|
expect {
|
|
promotion.review_tl2
|
|
}.to_not change { UserHistory.count }
|
|
end
|
|
end
|
|
|
|
context "qualifies for promotion" do
|
|
before do
|
|
TrustLevel3Requirements.any_instance.expects(:requirements_met?).at_least_once.returns(true)
|
|
end
|
|
|
|
it "review_tl2 returns true" do
|
|
expect(promotion.review_tl2).to eq(true)
|
|
end
|
|
|
|
it "promotes to tl3" do
|
|
expect(promotion.review_tl2).to eq(true)
|
|
expect(user.reload.trust_level).to eq(TrustLevel[3])
|
|
end
|
|
|
|
it "logs a trust level change" do
|
|
expect {
|
|
promotion.review_tl2
|
|
}.to change { UserHistory.where(action: UserHistory.actions[:auto_trust_level_change]).count }.by(1)
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|