mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 15:25:10 +08:00
043b4a4187
As much as possible I would like us to avoid having to go the with a global event listener on click/mouseover. For now I have removed all cases of `data-tooltip`, if we clearly identify a use case of a global event listener we might reconsider this. The following changes are also included: - by default tooltips won't attempt to focus first focusable element anymore - tooltip will now use `cursor: pointer` by default - a new service has been introduced: `InternalTooltip` which is responsible to track the current instance displayed by a `<DTooltip />`. Portal elements when replaced are not properly cleaned and I couldn't figure out a way to have a proper hook to ensure the previous `DTooltipInstance` is properly set as not expanded; this problem was very visible when using a tooltip as interactive and hovering another tooltip, which would replace the interactive tooltip as not closed.
13 lines
479 B
JavaScript
13 lines
479 B
JavaScript
import { tracked } from "@glimmer/tracking";
|
|
import Service from "@ember/service";
|
|
|
|
/*
|
|
This service holds the current tooltip displayed when using <DTooltip> component.
|
|
All of these tooltips share a commong portal outlet element, which means
|
|
we have to ensure we close them before their html is replaced, otherwise
|
|
we end up with a detached element in the DOM and unexpected behavior.
|
|
*/
|
|
export default class InternalTooltip extends Service {
|
|
@tracked activeTooltip;
|
|
}
|