discourse/plugins/chat/lib/chat_message_reactor.rb
Gerhard Schlager 7ef482a292
REFACTOR: Fix pluralized strings in chat plugin (#20357)
* FIX: Use pluralized string

* REFACTOR: Fix misuse of pluralized string

* REFACTOR: Fix misuse of pluralized string

* DEV: Remove linting of `one` key in MessageFormat string, it doesn't work

* REFACTOR: Fix misuse of pluralized string

This also ensures that the URL works on subfolder and shows the site setting link only for admins instead of staff. The string is quite complicated, so the best option was to switch to MessageFormat.

* REFACTOR: Fix misuse of pluralized string

* FIX: Use pluralized string

This also ensures that the URL works on subfolder and shows the site setting link only for admins instead of staff.

* REFACTOR: Correctly pluralize reaction tooltips in chat

This also ensures that maximum 5 usernames are shown and fixes the number of "others" which was off by 1 if the current user reacted on a message.

* REFACTOR: Use translatable string as comma separator

* DEV: Add comment to translation to clarify the meaning of `%{identifier}`

* REFACTOR: Use translatable comma separator and use explicit interpolation keys

* REFACTOR: Don't interpolate lowercase channel status

* REFACTOR: Fix misuse of pluralized string

* REFACTOR: Don't interpolate channel status

* REFACTOR: Use %{count} interpolation key

* REFACTOR: Fix misuse of pluralized string

* REFACTOR: Correctly pluralize DM chat channel titles
2023-02-20 10:31:02 +01:00

84 lines
2.4 KiB
Ruby

# frozen_string_literal: true
class Chat::ChatMessageReactor
ADD_REACTION = :add
REMOVE_REACTION = :remove
MAX_REACTIONS_LIMIT = 30
def initialize(user, chat_channel)
@user = user
@chat_channel = chat_channel
@guardian = Guardian.new(user)
end
def react!(message_id:, react_action:, emoji:)
@guardian.ensure_can_join_chat_channel!(@chat_channel)
@guardian.ensure_can_react!
validate_channel_status!
validate_reaction!(react_action, emoji)
message = ensure_chat_message!(message_id)
validate_max_reactions!(message, react_action, emoji)
reaction = nil
ActiveRecord::Base.transaction do
enforce_channel_membership!
reaction = create_reaction(message, react_action, emoji)
end
publish_reaction(message, react_action, emoji)
reaction
end
private
def ensure_chat_message!(message_id)
message = ChatMessage.find_by(id: message_id, chat_channel: @chat_channel)
raise Discourse::NotFound unless message
message
end
def validate_reaction!(react_action, emoji)
if ![ADD_REACTION, REMOVE_REACTION].include?(react_action) || !Emoji.exists?(emoji)
raise Discourse::InvalidParameters
end
end
def enforce_channel_membership!
Chat::ChatChannelMembershipManager.new(@chat_channel).follow(@user)
end
def validate_channel_status!
return if @guardian.can_create_channel_message?(@chat_channel)
raise Discourse::InvalidAccess.new(
nil,
nil,
custom_message: "chat.errors.channel_modify_message_disallowed.#{@chat_channel.status}",
)
end
def validate_max_reactions!(message, react_action, emoji)
if react_action == ADD_REACTION &&
message.reactions.count("DISTINCT emoji") >= MAX_REACTIONS_LIMIT &&
!message.reactions.exists?(emoji: emoji)
raise Discourse::InvalidAccess.new(
nil,
nil,
custom_message: "chat.errors.max_reactions_limit_reached",
)
end
end
def create_reaction(message, react_action, emoji)
if react_action == ADD_REACTION
message.reactions.find_or_create_by!(user: @user, emoji: emoji)
else
message.reactions.where(user: @user, emoji: emoji).destroy_all
end
end
def publish_reaction(message, react_action, emoji)
ChatPublisher.publish_reaction!(@chat_channel, message, react_action, @user, emoji)
end
end