mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 07:26:17 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
52 lines
1.4 KiB
Ruby
52 lines
1.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Positionable do
|
|
|
|
def positions
|
|
TestItem.order('position asc, id asc').pluck(:id)
|
|
end
|
|
|
|
context "move_to" do
|
|
before do
|
|
class TestItem < ActiveRecord::Base
|
|
include Positionable
|
|
end
|
|
|
|
Topic.exec_sql("create temporary table test_items(id int primary key, position int)")
|
|
end
|
|
|
|
after do
|
|
Topic.exec_sql("drop table test_items")
|
|
|
|
# import is making my life hard, we need to nuke this out of orbit
|
|
des = ActiveSupport::DescendantsTracker.class_variable_get :@@direct_descendants
|
|
des[ActiveRecord::Base].delete(TestItem)
|
|
end
|
|
|
|
it "can position stuff correctly" do
|
|
5.times do |i|
|
|
Topic.exec_sql("insert into test_items(id,position) values(#{i}, #{i})")
|
|
end
|
|
|
|
expect(positions).to eq([0,1,2,3,4])
|
|
TestItem.find(3).move_to(0)
|
|
expect(positions).to eq([3,0,1,2,4])
|
|
expect(TestItem.pluck(:position).sort).to eq([0,1,2,3,4])
|
|
|
|
TestItem.find(3).move_to(1)
|
|
expect(positions).to eq([0,3,1,2,4])
|
|
|
|
# this is somewhat odd, but when there is no such position, not much we can do
|
|
TestItem.find(1).move_to(5)
|
|
expect(positions).to eq([0,3,2,4,1])
|
|
|
|
expect(TestItem.pluck(:position).sort).to eq([0,1,2,3,4])
|
|
|
|
item = TestItem.new
|
|
item.id = 7
|
|
item.save
|
|
expect(item.position).to eq(5)
|
|
end
|
|
end
|
|
end
|