mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 05:43:44 +08:00
57caf08e13
This commit introduces rails system tests run with chromedriver, selenium, and headless chrome to our testing toolbox. We use the `webdrivers` gem and `selenium-webdriver` which is what the latest Rails uses so the tests run locally and in CI out of the box. You can use `SELENIUM_VERBOSE_DRIVER_LOGS=1` to show extra verbose logs of what selenium is doing to communicate with the system tests. By default JS logs are verbose so errors from JS are shown when running system tests, you can disable this with `SELENIUM_DISABLE_VERBOSE_JS_LOGS=1` You can use `SELENIUM_HEADLESS=0` to run the system tests inside a chrome browser instead of headless, which can be useful to debug things and see what the spec sees. See note above about `bin/ember-cli` to avoid surprises. I have modified `bin/turbo_rspec` to exclude `spec/system` by default, support for parallel system specs is a little shaky right now and we don't want them slowing down the turbo by default either. ### PageObjects and System Tests To make querying and inspecting parts of the page easier and more reusable inbetween system tests, we are using the concept of [PageObjects](https://www.selenium.dev/documentation/test_practices/encouraged/page_object_models/) in our system tests. A "Page" here is generally corresponds to an overarching ember route, e.g. "Topic" for `/t/324345/some-topic`, and this contains logic for querying components within the topic such as "Posts". I have also split "Modals" into their own entity. Further down the line we may want to explore creating independent "Component" contexts. Capybara DSL should be included in each PageObject class, reference for this can be found at https://rubydoc.info/github/teamcapybara/capybara/master#the-dsl For system tests, since they are so slow, we want to focus on the "happy path" and not do every different possible context and branch check using them. They are meant to be overarching tests that check a number of things are correct using the full stack from JS and ember to rails to ruby and then the database. ### CI Setup Whenever a system spec fails, a screenshot is taken and a build artifact is produced _after the entire CI run is complete_, which can be downloaded from the Actions UI in the repo. Most importantly, a step to build the Ember app using Ember CLI is needed, otherwise the JS assets cannot be found by capybara: ``` - name: Build Ember CLI run: bin/ember-cli --build ``` A new `--build` argument has been added to `bin/ember-cli` for this case, which is not needed locally if you already have the discourse rails server running via `bin/ember-cli -u` since the whole server is built and set up by default. Co-authored-by: David Taylor <david@taylorhq.com>
68 lines
2.5 KiB
Ruby
68 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Bookmarking posts and topics", type: :system, js: true do
|
|
fab!(:topic) { Fabricate(:topic) }
|
|
fab!(:user) { Fabricate(:user, username: "bookmarkguy") }
|
|
fab!(:post) { Fabricate(:post, topic: topic, raw: "This is some post to bookmark") }
|
|
fab!(:post2) { Fabricate(:post, topic: topic, raw: "Some interesting post content") }
|
|
|
|
it "allows logged in user to create bookmarks with and without reminders" do
|
|
sign_in user
|
|
visit "/t/#{topic.id}"
|
|
topic_page = PageObjects::Pages::Topic.new
|
|
expect(topic_page).to have_post_content(post)
|
|
topic_page.expand_post_actions(post)
|
|
topic_page.click_post_action_button(post, :bookmark)
|
|
|
|
bookmark_modal = PageObjects::Modals::Bookmark.new
|
|
bookmark_modal.fill_name("something important")
|
|
bookmark_modal.save
|
|
|
|
expect(topic_page).to have_post_bookmarked(post)
|
|
bookmark = Bookmark.find_by(bookmarkable: post, user: user)
|
|
expect(bookmark.name).to eq("something important")
|
|
|
|
topic_page.expand_post_actions(post2)
|
|
topic_page.click_post_action_button(post2, :bookmark)
|
|
|
|
bookmark_modal = PageObjects::Modals::Bookmark.new
|
|
bookmark_modal.select_preset_reminder(:tomorrow)
|
|
expect(topic_page).to have_post_bookmarked(post2)
|
|
bookmark = Bookmark.find_by(bookmarkable: post2, user: user)
|
|
expect(bookmark.reminder_at).not_to eq(nil)
|
|
expect(bookmark.reminder_set_at).not_to eq(nil)
|
|
end
|
|
|
|
it "does not create a bookmark if the modal is closed with the cancel button" do
|
|
sign_in user
|
|
visit "/t/#{topic.id}"
|
|
topic_page = PageObjects::Pages::Topic.new
|
|
topic_page.expand_post_actions(post)
|
|
topic_page.click_post_action_button(post, :bookmark)
|
|
|
|
bookmark_modal = PageObjects::Modals::Bookmark.new
|
|
bookmark_modal.fill_name("something important")
|
|
bookmark_modal.cancel
|
|
|
|
expect(topic_page).not_to have_post_bookmarked(post)
|
|
expect(Bookmark.exists?(bookmarkable: post, user: user)).to eq(false)
|
|
end
|
|
|
|
it "allows the topic to be bookmarked" do
|
|
sign_in user
|
|
visit "/t/#{topic.id}"
|
|
topic_page = PageObjects::Pages::Topic.new
|
|
topic_page.click_topic_footer_button(:bookmark)
|
|
|
|
bookmark_modal = PageObjects::Modals::Bookmark.new
|
|
bookmark_modal.fill_name("something important")
|
|
bookmark_modal.save
|
|
|
|
expect(topic_page).to have_topic_bookmarked
|
|
bookmark = try_until_success do
|
|
expect(Bookmark.exists?(bookmarkable: topic, user: user)).to eq(true)
|
|
end
|
|
expect(bookmark).not_to eq(nil)
|
|
end
|
|
end
|