discourse/app/controllers/admin/robots_txt_controller.rb
Osama Sayegh 87883a1963
FIX: Show true content of robots.txt after restoring to default (#24980)
Meta topic: https://meta.discourse.org/t/reseting-robots-txt-override-doesnt-seem-to-work-as-expected/287880?u=osama

Discourse provides a default version for `/robots.txt` which can be customized by admins in `/admin/customize/robots`. In that page, there's a button to reset back to the default version that Discourse provides. However, there's currently a bug with the reset button where the content appears to change to some HTML document instead of the default `robots.txt` version when clicking the button. Refreshing the page shows the true/correct content of `robots.txt` which is the default version, so the reset button actually works but there's a display problem.

What causes this display problem is that we use Rails' `render_to_string` method to generate the default content for `robots.txt` from the template, and what we get from that method is the `robots.txt` content wrapped in the application layout. To fix this issue, we need to pass `layout: false` to the `render_to_string` method so that it renders the template without any layouts.
2023-12-20 23:00:37 +03:00

38 lines
988 B
Ruby

# frozen_string_literal: true
class Admin::RobotsTxtController < Admin::AdminController
def show
render json: { robots_txt: current_robots_txt, overridden: @overridden }
end
def update
params.require(:robots_txt)
SiteSetting.overridden_robots_txt = params[:robots_txt]
render json: { robots_txt: current_robots_txt, overridden: @overridden }
end
def reset
SiteSetting.overridden_robots_txt = ""
render json: { robots_txt: original_robots_txt, overridden: false }
end
private
def current_robots_txt
robots_txt = SiteSetting.overridden_robots_txt.presence
@overridden = robots_txt.present?
robots_txt ||= original_robots_txt
robots_txt
end
def original_robots_txt
if SiteSetting.allow_index_in_robots_txt?
@robots_info = ::RobotsTxtController.fetch_default_robots_info
render_to_string "robots_txt/index", layout: false
else
render_to_string "robots_txt/no_index", layout: false
end
end
end