mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 10:25:02 +08:00
bf6f8299a7
Previously, with the default `editing_grace_period`, hotlinked images were pulled 5 minutes after a post is created. This delay was added to reduce the chance of automated edits clashing with user edits. This commit refactors things so that we can pull hotlinked images immediately. URLs are immediately updated in the post's `cooked` HTML. The post's raw markdown is updated later, after the `editing_grace_period`. This involves a number of behind-the-scenes changes including: - Schedule Jobs::PullHotlinkedImages immediately after Jobs::ProcessPost. Move scheduling to after the `update_column` call to avoid race conditions - Move raw changes into a separate job, which is delayed until after the ninja-edit window - Move disable_if_low_on_disk_space logic into the `pull_hotlinked_images` job - Move raw-parsing/replacing logic into `InlineUpload` so it can be easily be shared between `UpdateHotlinkedRaw` and `PullUserProfileHotlinkedImages`
73 lines
2.4 KiB
Ruby
73 lines
2.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'image_sizer'
|
|
|
|
module Jobs
|
|
|
|
class ProcessPost < ::Jobs::Base
|
|
|
|
def execute(args)
|
|
DistributedMutex.synchronize("process_post_#{args[:post_id]}", validity: 10.minutes) do
|
|
post = Post.find_by(id: args[:post_id])
|
|
# two levels of deletion
|
|
return unless post.present? && post.topic.present?
|
|
|
|
orig_cooked = post.cooked
|
|
recooked = nil
|
|
|
|
if args[:cook].present?
|
|
cooking_options = args[:cooking_options] || {}
|
|
cooking_options[:topic_id] = post.topic_id
|
|
recooked = post.cook(post.raw, cooking_options.symbolize_keys)
|
|
post.update_columns(cooked: recooked, baked_at: Time.zone.now, baked_version: Post::BAKED_VERSION)
|
|
end
|
|
|
|
cp = CookedPostProcessor.new(post, args)
|
|
cp.post_process(new_post: args[:new_post])
|
|
|
|
# If we changed the document, save it
|
|
cooked = cp.html
|
|
|
|
if cooked != (recooked || orig_cooked)
|
|
if orig_cooked.present? && cooked.blank?
|
|
# TODO stop/restart the worker if needed, let's gather a few here first
|
|
Rails.logger.warn("Cooked post processor in FATAL state, bypassing. You need to urgently restart sidekiq\norig: #{orig_cooked}\nrecooked: #{recooked}\ncooked: #{cooked}\npost id: #{post.id}")
|
|
else
|
|
post.update_column(:cooked, cp.html)
|
|
post.topic.update_excerpt(post.excerpt_for_topic) if post.is_first_post?
|
|
extract_links(post)
|
|
post.publish_change_to_clients! :revised
|
|
end
|
|
end
|
|
|
|
enqueue_pull_hotlinked_images(post) unless args[:skip_pull_hotlinked_images]
|
|
|
|
if !post.user&.staff? && !post.user&.staged?
|
|
s = post.raw
|
|
s << " #{post.topic.title}" if post.post_number == 1
|
|
if !args[:bypass_bump] && WordWatcher.new(s).should_flag?
|
|
PostActionCreator.create(
|
|
Discourse.system_user,
|
|
post,
|
|
:inappropriate,
|
|
reason: :watched_word
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
# onebox may have added some links, so extract them now
|
|
def extract_links(post)
|
|
TopicLink.extract_from(post)
|
|
QuotedPost.extract_from(post)
|
|
end
|
|
|
|
def enqueue_pull_hotlinked_images(post)
|
|
Jobs.cancel_scheduled_job(:pull_hotlinked_images, post_id: post.id)
|
|
Jobs.enqueue(:pull_hotlinked_images, post_id: post.id)
|
|
end
|
|
end
|
|
|
|
end
|