github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-17 23:33:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
586d572e05
discourse/spec/lib
History
Osama Sayegh 586d572e05
FIX: Don't advance draft sequence when editing topic title (#16002) 
This commit handles the edge case where a draft is lost with no warnings if the user edits the title (or category/tags) of a topic while they're replying.to the same topic. Repro steps are as follows:

1. Start replying to a topic and type enough to get a draft saved.
2. Scroll up to the topic title and click the pencil icon next to the topic title, change the title, category and/or tags, and then save the changes.
3. Reload the page and you'll see that the draft is gone.

This happens because we only allow 1 draft per topic per user and when you edit the title of a topic that you're replying to, from the server perspective it'll look like as if you've submitted your reply so it will advance the draft sequence for the topic and delete the draft.

The fix in this commit makes `PostRevisor` skip advancing the draft sequence when a topic's title is edited using the pencil button next to the title.

Internal ticket: t60854.

Co-authored-by: Robin Ward <robin.ward@gmail.com>
2022-02-23 10:39:54 +03:00
..
auth DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
backup_restore DEV: Prevent extraneous log message in specs (#15504) 2022-01-09 20:26:52 +01:00
common_passwords DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
compression DEV: Split max decompressed setting for themes and backups (#8179) 2019-10-11 14:38:10 -03:00
concern PERF: perform all cached counting in background (#15991) 2022-02-22 16:45:25 +00:00
content_security_policy FIX: Allow CSP to work correctly for non-default hostnames/schemes (#9180) 2020-03-19 19:54:42 +00:00
email DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
file_store DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
freedom_patches DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
guardian DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
highlight_js DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
i18n FIX: translation precedence was different on client and server 2021-12-17 14:03:35 +01:00
imap DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
import DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
middleware PERF: perform all cached counting in background (#15991) 2022-02-22 16:45:25 +00:00
migration DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
onebox DEV: Add tests for wistia onebox. (#15860) 2022-02-08 13:04:32 +08:00
plugin DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
pretty_text DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
rate_limiter DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
scheduler DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
second_factor FEATURE: Centralized 2FA page (#15377) 2022-02-17 12:12:59 +03:00
seed_data DEV: Add rubocop-rspec (#9288) 2020-03-27 17:35:40 +01:00
site_settings DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
stylesheet DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
svg_sprite DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
theme_store DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
topic_query FIX: Exclude PMs that user sent to themselves. (#14496) 2021-10-04 11:55:35 +08:00
validators DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
webauthn DEV: Add Windows Hello webauthn authentication spec (#15871) 2022-02-09 12:47:47 +10:00
wizard DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
admin_confirmation_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
admin_user_index_query_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
archetype_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
bookmark_manager_spec.rb DEV: Rolling back bookmarkable column changes (#15482) 2022-01-07 12:16:43 +10:00
bookmark_query_spec.rb FEATURE: Go to last unread for topic-level bookmark links (#14396) 2021-09-21 13:49:56 +10:00
bookmark_reminder_notification_handler_spec.rb DEV: Ignore bookmarks.topic_id column and remove references to it in code (#14289) 2021-09-15 10:16:54 +10:00
browser_detection_spec.rb FIX: Detect DiscourseHub user agent. 2019-08-09 11:58:15 +03:00
cache_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
category_badge_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
composer_messages_finder_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
content_buffer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
content_security_policy_spec.rb DEV: prevents flakky spec when deleting plugin (#14701) 2021-10-25 10:24:21 +02:00
cooked_post_processor_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
crawler_detection_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
current_user_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
db_helper_spec.rb FEATURE: Include optimized thumbnails for topics (#9215) 2020-05-05 09:07:50 +01:00
directory_helper_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_diff_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_event_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_hub_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_js_processor_spec.rb Support for transpiling .js files (#9160) 2020-03-11 09:43:55 -04:00
discourse_plugin_registry_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_redis_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_tagging_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
discourse_updates_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
distributed_cache_spec.rb FIX: Handle nil values in DistributedCache#defer_get_set (#15978) 2022-02-17 14:52:14 +00:00
distributed_memoizer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
distributed_mutex_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
email_cook_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
email_updater_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
encodings_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
enum_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
excerpt_parser_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
feed_element_installer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
feed_item_accessor_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
file_helper_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
filter_best_posts_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
final_destination_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
flag_settings_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
gaps_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
global_path_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
group_email_credentials_check_spec.rb FEATURE: Scheduled group email credential problem check (#15396) 2022-01-04 10:14:33 +10:00
guardian_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
has_errors_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
hijack_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
html_prettify_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
html_to_markdown_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
image_sizer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
inline_oneboxer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
introduction_updater_spec.rb FIX: replace default welcome topic post with new value from wizard 2020-04-01 15:42:45 -04:00
js_locale_helper_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
json_error_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
letter_avatar_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
message_id_service_spec.rb FIX: Canonical Message-ID was incorrect for some cases (#15701) 2022-02-03 10:36:32 +10:00
method_profiler_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
mini_sql_multisite_connection_spec.rb DEV: upgrade mini_sql (#12465) 2021-03-24 08:48:04 +11:00
new_post_manager_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
new_post_result_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
onebox_spec.rb DEV: Absorb onebox gem into core (#12979) 2021-05-26 15:11:35 +05:30
oneboxer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
onpdiff_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
pbkdf2_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
pinned_check_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
plain_text_to_markdown_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
post_action_creator_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
post_creator_spec.rb PERF: Use a shared message for replies to tracked topics (#16022) 2022-02-22 15:27:46 +00:00
post_destroyer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
post_jobs_enqueuer_spec.rb FIX: Do not send emails to mailing_list_mode subscribers for PMs (#14159) 2021-08-26 15:16:35 +10:00
post_locker_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
post_merger_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
post_revisor_spec.rb FIX: Don't advance draft sequence when editing topic title (#16002) 2022-02-23 10:39:54 +03:00
presence_channel_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
pretty_text_spec.rb DEV: Add force_quote_link option to PrettyText (#16034) 2022-02-23 16:13:46 +10:00
promotion_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
quote_comparer_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
rate_limiter_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
redis_store_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
retrieve_title_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
rtl_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
s3_cors_rulesets_spec.rb DEV: Improve s3:ensure_cors_rules logging (#14832) 2021-11-08 11:44:12 +10:00
s3_helper_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
s3_inventory_multisite_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
s3_inventory_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
score_calculator_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
scss_checker_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
search_spec copy.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
search_spec.rb FEATURE: Split up text segmentation for Chinese and Japanese. 2022-02-07 09:21:14 +08:00
secure_session_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
shrink_uploaded_image_spec.rb DEV: Improve script/downsize_uploads.rb (#13508) 2021-06-24 00:09:40 +02:00
site_icon_manager_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
site_setting_extension_multisite_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
site_setting_extension_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
slug_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
spam_handler_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
suggested_topics_builder_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
system_message_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
text_cleaner_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
text_sentinel_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
theme_flag_modifier_spec.rb PERF: Eager load Theme associations in Stylesheet Manager. 2021-06-21 11:06:58 +08:00
theme_javascript_compiler_spec.rb FEATURE: Introduce theme/component QUnit tests (take 2) (#12661) 2021-04-12 15:02:58 +03:00
theme_settings_manager_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
theme_settings_parser_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
timeline_lookup_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
tiny_japanese_segmenter_spec.rb FEATURE: Split up text segmentation for Chinese and Japanese. 2022-02-07 09:21:14 +08:00
topic_creator_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
topic_publisher_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
topic_query_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
topic_retriever_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
topic_upload_security_manager_spec.rb DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
topic_view_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
topics_bulk_action_spec.rb FEATURE: Rename Reset Read bulk action to Defer (#15972) 2022-02-21 22:45:01 +02:00
trashable_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
trust_level_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
twitter_api_spec.rb FIX: Replace Twitter handles one at a time (#15870) 2022-02-09 13:54:02 +02:00
unread_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
upload_creator_spec.rb FIX: Blurry onebox favicon images (#15258) 2021-12-10 12:25:50 -07:00
upload_markdown_spec.rb DEV: Expand UploadMarkdown generation capabilities (#15930) 2022-02-14 15:48:27 +10:00
upload_recovery_spec.rb DEV: Fix methods removed in Ruby 3.2 (#15459) 2022-01-05 18:45:08 +01:00
upload_security_spec.rb FIX: manually adds frowning_face_with_open_mouth for apple (#13528) 2021-07-21 23:27:20 +02:00
url_helper_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
user_lookup_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
user_name_suggester_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00
version_spec.rb DEV: Move spec/components to spec/lib (#15987) 2022-02-18 19:41:54 +01:00