mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 23:54:16 +08:00
cedcdb0057
Due to default CSP web workers instantiated from CDN based assets are still
treated as "same-origin" meaning that we had no way of safely instansiating
a web worker from a theme.
This limits the theme system and adds the arbitrary restriction that WASM
based components can not be safely used.
To resolve this limitation all js assets in about.json are also cached on
local domain.
{
"name": "Header Icons",
"assets" : {
"worker" : "assets/worker.js"
}
}
This can then be referenced in JS via:
settings.theme_uploads_local.worker
local_js_assets are unconditionally served from the site directly and
bypass the entire CDN, using the pre-existing JavascriptCache
Previous to this change this code was completely dormant on sites which
used s3 based uploads, this reuses the very well tested and cached asset
system on s3 based sites.
Note, when creating local_js_assets it is highly recommended to keep the
assets lean and keep all the heavy working in CDN based assets. For example
wasm files can still live on the CDN but the lean worker that loads it can
live on local.
This change unlocks wasm in theme components, so wasm is now also allowed
in `theme_authorized_extensions`
* more usages of upload.content
* add a specific test for upload.content
* Adjust logic to ensure that after upgrades we still get a cached local js
on save
56 lines
1.3 KiB
Ruby
56 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
class JavascriptCache < ActiveRecord::Base
|
|
belongs_to :theme_field
|
|
belongs_to :theme
|
|
|
|
validate :content_cannot_be_nil
|
|
|
|
before_save :update_digest
|
|
|
|
def url
|
|
"#{GlobalSetting.cdn_url}#{Discourse.base_path}#{path}"
|
|
end
|
|
|
|
def local_url
|
|
"#{Discourse.base_url}#{path}"
|
|
end
|
|
|
|
private
|
|
|
|
def path
|
|
"/theme-javascripts/#{digest}.js?__ws=#{Discourse.current_hostname}"
|
|
end
|
|
|
|
def update_digest
|
|
self.digest = Digest::SHA1.hexdigest(content) if content_changed?
|
|
end
|
|
|
|
def content_cannot_be_nil
|
|
errors.add(:content, :empty) if content.nil?
|
|
end
|
|
end
|
|
|
|
# == Schema Information
|
|
#
|
|
# Table name: javascript_caches
|
|
#
|
|
# id :bigint not null, primary key
|
|
# theme_field_id :bigint
|
|
# digest :string
|
|
# content :text not null
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
# theme_id :bigint
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_javascript_caches_on_digest (digest)
|
|
# index_javascript_caches_on_theme_field_id (theme_field_id)
|
|
# index_javascript_caches_on_theme_id (theme_id)
|
|
#
|
|
# Foreign Keys
|
|
#
|
|
# fk_rails_... (theme_field_id => theme_fields.id) ON DELETE => cascade
|
|
# fk_rails_... (theme_id => themes.id) ON DELETE => cascade
|
|
#
|