github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 17:03:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
5a54aefd27
discourse/app/assets/stylesheets/common/float-kit
History
Osama Sayegh eff6e4b405
FIX: Position Float Kit elements correctly in RTL mode (#24908) 
Float-kit elements (menus/tooltips) are positioned where they should be by setting an inline `left` property in JavaScript when they're rendered. For some reasons, we also set `left: 0` on float-kit elements here:

25d9927785/app/assets/stylesheets/common/float-kit/d-menu.scss (L11-L15)

This property is overridden by the inline property that the library sets in JavaScript. However, in RTL mode, all of our scss files are flipped where everything left becomes right and vice versa. In this case, the `left: 0` property in the scss file above becomes `right: 0`.

This results in a conflict specific to RTL mode where both the `left` and `right` properties are defined on the same absolute-positioned element; the `right` property will always be set to 0 because it comes from the (flipped) scss file above, and the inline `left` property will be set to some px amount determined in JavaScript.

The `right` property will take precedence over the inline `left` property due to the page being right-to-left (source: https://developer.mozilla.org/en-US/docs/Web/CSS/right#description) and this causes float-kit elements to incorrectly always stick to the right.

This commit removes the `left: 0` property altogether for float-kit elements from our scss files. It's not clear from git history why the property was added, and removing it doesn't seem to cause any issues.

Meta topic: https://meta.discourse.org/t/positioning-issues-with-rtl-locales-after-recent-updates/280220?u=osama
2023-12-15 13:16:31 +03:00
..
_index.scss DEV: FloatKit (#23650) 2023-09-26 13:39:52 +02:00
d-button-tooltip.scss DEV: FloatKit (#23650) 2023-09-26 13:39:52 +02:00
d-default-toast.scss DEV: toasts improvements (#24046) 2023-10-23 15:23:10 +02:00
d-menu.scss FIX: Position Float Kit elements correctly in RTL mode (#24908) 2023-12-15 13:16:31 +03:00
d-toasts.scss DEV: toasts improvements (#24046) 2023-10-23 15:23:10 +02:00
d-tooltip.scss FIX: Position Float Kit elements correctly in RTL mode (#24908) 2023-12-15 13:16:31 +03:00