mirror of
https://github.com/discourse/discourse.git
synced 2024-12-11 21:44:08 +08:00
5cfe323445
What is this change required? I noticed that actions in `SidebarSectionsController` resulted in lots of N+1 queries problem and I wanted a solution to prevent such problems without having to write N+1 queries tests. I have also used strict loading for `SidebarSection` queries in performance sensitive spots. Note that in this commit, I have also set `config.active_record.action_on_strict_loading_violation = :log` for the production environment so that we have more visibility of potential N+1 queries problem in the logs. In development and test environment, we're sticking with the default of raising an error.
29 lines
1.0 KiB
Ruby
29 lines
1.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe SidebarSection do
|
|
fab!(:user) { Fabricate(:user) }
|
|
fab!(:sidebar_section) { Fabricate(:sidebar_section, user: user) }
|
|
let(:community_section) do
|
|
SidebarSection.find_by(section_type: SidebarSection.section_types[:community])
|
|
end
|
|
|
|
it "uses system user for public sections" do
|
|
expect(sidebar_section.user_id).to eq(user.id)
|
|
sidebar_section.update!(public: true)
|
|
expect(sidebar_section.user_id).to eq(Discourse.system_user.id)
|
|
end
|
|
|
|
it "resets Community section to the default state" do
|
|
community_section.update!(title: "test")
|
|
community_section.sidebar_section_links.first.linkable.update!(name: "everything edited")
|
|
community_section.sidebar_section_links.last.destroy!
|
|
community_section.reset_community!
|
|
|
|
expect(community_section.reload.title).to eq("Community")
|
|
|
|
expect(community_section.sidebar_section_links.all.map { |link| link.linkable.name }).to eq(
|
|
["Everything", "My Posts", "Review", "Admin", "Users", "About", "FAQ", "Groups", "Badges"],
|
|
)
|
|
end
|
|
end
|