discourse/spec/requests
Martin Brennan 1ba5ccd8af
FIX: When user has already hit bookmark limit, do not error for clear_reminder! or other updates (#12658)
We introduced a cap on the number of bookmarks the user can add in be145ccf2f. However this has caused unintended side effects; when the `jobs/scheduled/bookmark_reminder_notifications.rb` runs we get this error for users who already had more bookmarks than the limit:

> Job exception: Validation failed: Sorry, you have too many bookmarks, visit #{url}/my/activity/bookmarks to remove some.

This is because the `clear_reminder!` call was triggering a bookmark validation, which raised an error because the user already had to many, holding up other reminders.

This PR also adds `max_bookmarks_per_user` hidden site setting (default 2000). This replaces the BOOKMARK_LIMIT const so we can raise it for certain sites.
2021-04-09 13:06:35 +10:00
..
admin UX: move logs/watched_words to customize/watched_words in admin section (#12571) 2021-04-01 11:44:17 +05:30
api DEV: Remove draft attributes from topic lists (#12525) 2021-03-30 11:42:26 -04:00
about_controller_spec.rb FIX: Correct user profile URLs in /about crawler view 2020-07-14 16:09:27 +01:00
application_controller_spec.rb FEATURE: Implement nonces for Google Tag Manager integration (#12531) 2021-03-26 11:19:31 -04:00
associate_accounts_controller_spec.rb DEV: Introduce :before_auth DiscourseEvent (#11233) 2020-11-13 14:41:54 +00:00
badges_controller_spec.rb
bookmarks_controller_spec.rb FIX: When user has already hit bookmark limit, do not error for clear_reminder! or other updates (#12658) 2021-04-09 13:06:35 +10:00
bootstrap_controller_spec.rb FIX: Add appropriate classes to html element including lang (#12245) 2021-03-01 14:04:02 -05:00
categories_controller_spec.rb DEV: Remove draft attributes from topic lists (#12525) 2021-03-30 11:42:26 -04:00
clicks_controller_spec.rb
composer_messages_controller_spec.rb
csp_reports_controller_spec.rb
directory_items_controller_spec.rb UX: Do not include current user in group-filtered directory results (#11310) 2020-11-23 10:22:14 +11:00
do_not_disturb_controller_spec.rb DEV: Replace 'processed' column on notifications with new table (#11864) 2021-01-27 10:29:24 -06:00
draft_controller_spec.rb
drafts_controller_spec.rb
email_controller_spec.rb FEATURE: Mailing list mode default disabled (#11091) 2021-03-04 15:24:37 -05:00
embed_controller_spec.rb FEATURE: Add CSP frame-ancestors support (#12404) 2021-03-22 16:00:25 -03:00
exceptions_controller_spec.rb
export_csv_controller_spec.rb DEV: Switch to new ExportUserArchive job 2020-08-28 11:46:53 -07:00
extra_locales_controller_spec.rb FEATURE: Add English (UK) as locale (#11768) 2021-01-20 21:32:22 +01:00
finish_installation_controller_spec.rb
forums_controller_spec.rb FEATURE: Allow a cluster_name to be configured and used for /srv/status (#12365) 2021-03-15 15:41:59 +11:00
groups_controller_spec.rb FEATURE: Allow setting avatar flair for automatic groups (#12586) 2021-04-06 11:13:06 -04:00
hashtags_controller_spec.rb DEV: Merge category and tag hashtags code paths (#10216) 2020-07-13 19:13:17 +03:00
inline_onebox_controller_spec.rb
invites_controller_spec.rb FEATURE: Retrieve an existing link only invite (#12575) 2021-04-06 11:01:07 -04:00
list_controller_spec.rb FIX: Category redirect to correct slug should not loop (#11772) 2021-02-16 17:54:50 +02:00
metadata_controller_spec.rb PERF: cache all metadata for 60 seconds 2020-07-01 12:58:02 +10:00
notifications_controller_spec.rb FIX: Typo in NotificationsController#index not caught by tests. 2020-07-22 09:22:26 +08:00
offline_controller_spec.rb
omniauth_callbacks_controller_spec.rb FIX: Handle staged users as unregistered users for external auth (#12567) 2021-03-31 13:40:58 +01:00
onebox_controller_spec.rb FEATURE: Onebox local categories (#11311) 2020-11-25 10:53:05 +11:00
permalinks_controller_spec.rb
post_action_users_controller_spec.rb DEV: Cleanup ignored user logic (#11107) 2020-11-03 12:38:54 +00:00
post_actions_controller_spec.rb
post_readers_controller_spec.rb
posts_controller_spec.rb DEV: Change flakey posts controller spec (#12506) 2021-03-24 11:20:38 -05:00
published_pages_controller_spec.rb FIX: Do not enable published page if secure media enabled (#11131) 2020-11-06 10:33:19 +10:00
push_notification_controller_spec.rb
reviewable_claimed_topics_controller_spec.rb
reviewables_controller_spec.rb DEV: Remove debug print statement (#12390) 2021-03-12 15:12:50 -06:00
robots_txt_controller_spec.rb FEATURE: explicitly ban outlier traffic sources in robots.txt (#11553) 2020-12-23 08:51:14 +11:00
safe_mode_controller_spec.rb
search_controller_spec.rb FEATURE: Change very high/low search priority to rank at absolute ends. 2021-03-09 09:20:37 +08:00
session_controller_spec.rb FEATURE: Allow using invites when DiscourseConnect SSO is enabled (#12419) 2021-03-19 10:20:10 +10:00
similar_topics_controller_spec.rb FIX: reindex_search job should work on model with no search data (#11819) 2021-01-25 11:23:36 +01:00
site_controller_spec.rb DEV: Make site setting type uploaded_image_list use upload IDs (#10401) 2020-10-13 16:17:06 +03:00
static_controller_spec.rb DEV: apply allow origin response header for CDN requests. (#11893) 2021-01-29 07:44:49 +05:30
steps_controller_spec.rb
stylesheets_controller_spec.rb FEATURE: User selectable color schemes (#10544) 2020-08-28 10:36:52 -04:00
svg_sprite_controller_spec.rb
tag_groups_controller_spec.rb FEATURE: Make the tag_groups#search endpoint public. (#12643) 2021-04-08 14:23:13 -03:00
tags_controller_spec.rb DEV: Remove draft attributes from topic lists (#12525) 2021-03-30 11:42:26 -04:00
theme_javascripts_controller_spec.rb Revert "FEATURE: Introduce theme/component QUnit tests (#12517)" (#12632) 2021-04-07 17:45:49 +03:00
topics_controller_spec.rb DEV: Add tests for invite system (#12524) 2021-03-25 18:26:22 +02:00
uploads_controller_multisite_spec.rb DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
uploads_controller_spec.rb FIX: Be able to handle long file extensions (#12375) 2021-03-17 12:01:29 -06:00
user_actions_controller_spec.rb FEATURE - SiteSetting to disable user option to hide their profiles and presences (#10885) 2020-10-09 17:18:44 -04:00
user_api_keys_controller_spec.rb DEV: Move UserApiKey scopes to dedicated table (#10704) 2020-09-29 10:57:48 +01:00
user_avatars_controller_spec.rb DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
user_badges_controller_spec.rb FEATURE - SiteSetting to disable user option to hide their profiles and presences (#10885) 2020-10-09 17:18:44 -04:00
users_controller_spec.rb FIX: Perform better email validation (#12497) 2021-03-24 08:44:51 +11:00
users_email_controller_spec.rb DEV: Move logic for rate limiting user second factor to one place (#11941) 2021-02-04 09:03:30 +10:00
webhooks_controller_spec.rb Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse"" 2020-05-23 00:56:13 -04:00
wizard_controller_spec.rb