Jarek Radosz 694b5f108b

DEV: Fix various rubocop lints (#24749) ...

These (21 + 3 from previous PRs) are soon to be enabled in rubocop-discourse:

Capybara/VisibilityMatcher
Lint/DeprecatedOpenSSLConstant
Lint/DisjunctiveAssignmentInConstructor
Lint/EmptyConditionalBody
Lint/EmptyEnsure
Lint/LiteralInInterpolation
Lint/NonLocalExitFromIterator
Lint/ParenthesesAsGroupedExpression
Lint/RedundantCopDisableDirective
Lint/RedundantRequireStatement
Lint/RedundantSafeNavigation
Lint/RedundantStringCoercion
Lint/RedundantWithIndex
Lint/RedundantWithObject
Lint/SafeNavigationChain
Lint/SafeNavigationConsistency
Lint/SelfAssignment
Lint/UnreachableCode
Lint/UselessMethodDefinition
Lint/Void

Previous PRs:
Lint/ShadowedArgument
Lint/DuplicateMethods
Lint/BooleanSymbol
RSpec/SpecFilePathSuffix

2023-12-06 23:25:00 +01:00

..

admin

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

chat/composer

DEV: Remove unnecessary js: true options from specs (#24463)

2023-11-20 17:22:14 +01:00

chat_message

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

list_channels

FEATURE: Remove support for legacy navigation menu (#23752)

2023-10-09 07:24:10 +08:00

page_objects

DEV: Fix Lint/DuplicateMethods (#24746)

2023-12-06 13:18:34 +01:00

reply_to_message

DEV: improves reliability of delete/restore/update specs (#24265)

2023-11-07 11:34:35 +01:00

select_message

FEATURE: thread pagination (#22624)

2023-07-27 09:57:03 +02:00

shortcuts

DEV: Refactor chat specs related to message creation

2023-08-31 11:21:23 +02:00

thread_list

UX: refactor .d-modal to use BEM and improve styling (#23967)

2023-11-15 10:14:47 +00:00

thread_tracking

UX: opens thread on channel with unread threads (#23361)

2023-10-11 12:19:30 +02:00

user_menu_notifications

DEV: Refactor chat specs related to message creation

2023-08-31 11:21:23 +02:00

user_status

FEATURE: introduces group channels (#24288)

2023-11-10 11:29:28 +01:00

anonymous_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

archive_channel_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

bookmark_message_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

browse_page_spec.rb

FEATURE: enable_public_channels site setting (#22565)

2023-07-13 10:00:25 +02:00

channel_members_page_spec.rb

FEATURE: introduces group channels (#24288)

2023-11-10 11:29:28 +01:00

channel_message_upload_spec.rb

DEV: Fix various rubocop lints (#24749)

2023-12-06 23:25:00 +01:00

channel_settings_page_spec.rb

FIX: leaving a group channel should destroy membership (#24631)

2023-11-29 17:48:14 +01:00

channel_thread_message_echoing_spec.rb

DEV: makes every spec use new messages helper (#23163)

2023-08-21 16:31:58 +02:00

chat_channel_spec.rb

DEV: correctly uses link to message endpoint in spec (#24652)

2023-11-30 19:33:41 +01:00

chat_composer_draft_spec.rb

FEATURE: implements drafts for threads (#24483)

2023-11-22 11:54:23 +01:00

chat_composer_spec.rb

DEV: Fix flaky network-based upload spec (#23286)

2023-08-28 12:59:22 +08:00

chat_message_creator_spec.rb

UX: improves search of message creator

2023-11-13 22:03:47 +01:00

chat_message_onebox_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

chat_summarization_spec.rb

DEV: Remove unnecessary js: true options from specs (#24463)

2023-11-20 17:22:14 +01:00

closed_channel_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

create_channel_spec.rb

DEV: Remove experimental site setting for chat threads (#22720)

2023-07-26 12:46:23 +02:00

dates_separators_spec.rb

FEATURE: thread pagination (#22624)

2023-07-27 09:57:03 +02:00

deleted_channel_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

deleted_message_spec.rb

DEV: improves reliability of delete/restore/update specs (#24265)

2023-11-07 11:34:35 +01:00

document_title_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

drawer_spec.rb

FEATURE: introduces group channels (#24288)

2023-11-10 11:29:28 +01:00

edited_message_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

flag_message_spec.rb

UX: enhances chat copy features (#23770)

2023-10-04 16:14:37 +02:00

hashtag_autocomplete_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

invite_users_to_channel_spec.rb

FIX: ensures users can open channel invites (#24067)

2023-10-24 18:51:33 +02:00

kick_user_from_channel_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

mention_warnings_spec.rb

FEATURE: Chat global mention warnings (pre-send & post-send) (#22764)

2023-08-22 15:54:35 -05:00

message_errors_spec.rb

DEV: ensures we have error message before message check (#24647)

2023-11-30 10:55:05 +01:00

message_notifications_mobile_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

message_notifications_with_sidebar_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

message_thread_indicator_spec.rb

DEV: improves reliability of delete/restore/update specs (#24265)

2023-11-07 11:34:35 +01:00

message_user_info_spec.rb

DEV: Fix RSpec/SpecFilePathSuffix / enable 3 chat spec files (#24750)

2023-12-06 22:25:11 +01:00

move_message_to_channel_spec.rb

DEV: makes chat modals use the new <DModal /> component (#22495)

2023-07-10 13:43:33 +02:00

navigation_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

react_to_message_spec.rb

DEV: FloatKit (#23650)

2023-09-26 13:39:52 +02:00

read_only_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

removing_channel_spec.rb

FIX: redirects to browse after removing last followed (#22563)

2023-07-14 08:26:18 +02:00

restore_message_spec.rb

UX: enhances chat copy features (#23770)

2023-10-04 16:14:37 +02:00

reviewables_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

send_message_spec.rb

FIX: correctly makes dm creator to follow channel (#22470)

2023-07-06 21:42:19 +02:00

separate_sidebar_mode_spec.rb

FIX: prevents setPanel to also set separated mode (#23227)

2023-08-24 18:21:28 +02:00

sidebar_navigation_menu_spec.rb

DEV: correctly uses link to message endpoint in spec (#24652)

2023-11-30 19:33:41 +01:00

sidebars_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

silenced_user_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

single_thread_spec.rb

DEV: Refactor chat specs related to message creation

2023-08-31 11:21:23 +02:00

thread_preview_spec.rb

DEV: improves reliability of delete/restore/update specs (#24265)

2023-11-07 11:34:35 +01:00

transcript_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

unfollow_dm_channel_spec.rb

DEV: makes every spec use new messages helper (#23163)

2023-08-21 16:31:58 +02:00

update_last_read_spec.rb

DEV: Fix RSpec/SpecFilePathSuffix / enable 3 chat spec files (#24750)

2023-12-06 22:25:11 +01:00

uploads_spec.rb

DEV: skip flaky upload spec for large image thumbnails (#24745)

2023-12-06 19:08:56 +08:00

user_card_spec.rb

DEV: Fix random typos (#24756)

2023-12-06 22:25:26 +01:00

user_chat_preferences_spec.rb

FIX: correctly check chat tab is present (#23200)

2023-08-23 13:06:29 +02:00

visit_channel_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00